From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09E9C4338F for ; Thu, 29 Jul 2021 13:53:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED13C60EBC for ; Thu, 29 Jul 2021 13:52:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED13C60EBC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 661E882E23; Thu, 29 Jul 2021 15:52:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HgRr5rfN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5F5C282E7A; Thu, 29 Jul 2021 15:52:55 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9829682E02 for ; Thu, 29 Jul 2021 15:52:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id m11so3948187qtx.7 for ; Thu, 29 Jul 2021 06:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MuOtYJmB18447LQvX/DJtJZRdDVECk1enErVictfuYM=; b=HgRr5rfN99MOQ7cc35XKBgVzZWUPaMkxYj0lbJKwyJBSsmi5uOqGAX1w5fqJrekoxC 77Shr4aSPWIIA/fAnjYD7mK4xjKEzl6/yhesUjHqRq1TeWUWjBD7Yq3Z1K5EspPBEeE+ PaRKoSbtUoItQ+ZIKclkj6Dg/OMEhZsaxJthY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MuOtYJmB18447LQvX/DJtJZRdDVECk1enErVictfuYM=; b=UEvHbctl7z0g8KnSDj956V/G5My0MgPU7I9SIDGwjip68GcYPQr9ZRrU0AkPQGHSG2 j0uhuPPGYhUIrL64xp9vl0bubpes3nW00xBSvOKeiMzEiNs2Zt2i0KF9waxi0hZn5qlY vlW9tKZi8xwFQaxTJ2PP85powgnsuXOtQJ35ux6FOU8jbxUvb9jhtblDlTBG/AFoftWg xhLlK3wtSqdsrmhE2aBN+57DzNOGmdoJcNW8IFX1dgcKnnoV8v7UE042EnEpYGYcUX/P NU8p6lwkvswjXKByrr/GH5EP/j5kejvE33JpxKJxwe+F/RCWOgMkQ2bVA18qcg/uVHB1 IBzA== X-Gm-Message-State: AOAM532X9sahwKMfMEtotr2wEACIwrsvP+Pvc1CDqWdIaCNEcMHHFKd7 u9zRD18CojN/mqTw6omImYW/uQ== X-Google-Smtp-Source: ABdhPJxjeSL9UTy2aiJ1dqIp0esGJO/iAFESwjlKMmwqo4kYOgmO4p8bQfSwjjIZ69I8mjWXMu8JFA== X-Received: by 2002:a05:622a:1aaa:: with SMTP id s42mr1169609qtc.334.1627566770308; Thu, 29 Jul 2021 06:52:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id j24sm1239937qtr.52.2021.07.29.06.52.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jul 2021 06:52:49 -0700 (PDT) Date: Thu, 29 Jul 2021 09:52:47 -0400 From: Tom Rini To: Simon Glass Cc: Heinrich Schuchardt , U-Boot Mailing List , Ilias Apalodimas , Pali =?iso-8859-1?Q?Roh=E1r?= , Mark Kettenis Subject: Re: [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL Message-ID: <20210729135247.GO9379@bill-the-cat> References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-4-sjg@chromium.org> <20210726220735.GA8013@bill-the-cat> <5dba1547-37cc-14f0-1514-1dc337b0d25e@gmx.de> <20210728235513.GJ9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+dV+xilh7QQozWTa" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --+dV+xilh7QQozWTa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 07:44:37PM -0600, Simon Glass wrote: > Hi, >=20 > On Wed, 28 Jul 2021 at 17:55, Tom Rini wrote: > > > > On Thu, Jul 29, 2021 at 01:45:49AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > On 7/27/21 12:07 AM, Tom Rini wrote: > > > > On Fri, Jul 02, 2021 at 12:36:18PM -0600, Simon Glass wrote: > > > > > > > > > This feature should never have been made available when driver mo= del > > > > > or devicetree are disabled. Add these as conditions, so that we d= on't > > > > > create even more barriers to migration. > > > > > > > > > > Add a note about the substantial size increment associated with t= his > > > > > option. > > > > > > > > > > Signed-off-by: Simon Glass > > > > > --- > > > > > > > > > > Changes in v2: > > > > > - Split out new patch to make EFI_LOADER depend on DM and OF_CONT= ROL > > > > > - Note the approximate size of this feature in the help > > > > > > > > > > lib/efi_loader/Kconfig | 4 +++- > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > > > > index 6242caceb7f..466abfed300 100644 > > > > > --- a/lib/efi_loader/Kconfig > > > > > +++ b/lib/efi_loader/Kconfig > > > > > @@ -1,6 +1,6 @@ > > > > > config EFI_LOADER > > > > > bool "Support running UEFI applications" > > > > > - depends on OF_LIBFDT && ( \ > > > > > + depends on OF_LIBFDT && DM && OF_CONTROL && ( \ > > > > > > Didn't Tom eliminate all boards without CONFIG_DM? Shouldn't we get r= id > > > of this symbol? > > > > No, but I did send out a message about that today as we're very close. > > Much closer than I had expected us to be. >=20 > Note we will still have SPL_DM, I think. Right. > > > Are there boards using DM and not OF_CONTROL or OF_CONTROL and not DM? > > > > Yes, a few. It's vexpress_aemv8a_semi, warp (fixed by > > https://patchwork.ozlabs.org/project/uboot/patch/20210402180552.1075997= -2-pbrobinson@gmail.com/ > > so false positive), cm_t335, devkit8000, armadillo-800eva, kzm9g and sn= iper. > > > > > Why are these separate symbols? Isn't this symbol to be eliminated, t= oo? > > > > Simon? >=20 > If we do eliminate DM it will be in a separate series. Like Tom I am > pleasantly surprised at how close we are. >=20 > But please let's consider patches on their merits. It is fine to reply > with a wishlist but even better to reply with a follow-up patch. OK. So, build-wise, EFI_LOADER does not require OF_CONTROL. > Somewhat related, I think we need to create a separate symbol which > means (OF_CONTROL && !OF_PLATDATA) so we can just check one thing. >=20 > Also I think we should push of-platdata, since otherwise we're going > to hit the same problem of migrating SPL boards to DM one day. Note that we don't have CONFIG_OF_PLATDATA just CONFIG_(SPL|TPL)_OF_PLATDATA. > > > lib/efi_loader/efi_disk.c is the only place where we maintain duplica= te > > > code for DM and non-DM. A dependency on CONFIG_BLK (which itself depe= nds > > > on CONFIG_DM) would make more sense to me. But only in a patch > > > eliminating the non-BLK code. > > > > I just know that off-hand, partition + disk + block has some corner > > case, but maybe that corner case is unintentional in terms of usage > > today. > > > > > > > ARM && (SYS_CPU =3D arm1136 || \ > > > > > SYS_CPU =3D arm1176 || \ > > > > > SYS_CPU =3D armv7 || \ > > > > > @@ -25,6 +25,8 @@ config EFI_LOADER > > > > > will expose the UEFI API to a loaded application, ena= bling it to > > > > > reuse U-Boot's device drivers. > > > > > > > > > > + For ARM 32-bit, this adds about 90KB to the size of U-Boot. > > > > > + > > > > > > There is no unit ISO prefix K. Do you mean KiB? > > > > > > 90 KiB may be the value today. Will you update it regularly? Otherwise > > > don't put a number here. > > > > > > I can't see that the effect on size is truly architecture specific. W= hy > > > do you refer to 32bit ARM? > > > > > > Such a comment would better fit into a documentation chapter on > > > downsizing U-Boot. > > > > Yes, we should probably drop that specific note. >=20 > From my POV I really like these notes in Kconfig. They appear in a few > places and provide people with rough guidance. I'd like to see more of > them. I don't know how we can keep them up-to-date, although I'd argue > that they should stay constant, if we are holding to our no-bloat > ideal. I feel like EFI gets a bit of an undeserved reputation here. It's not growing any worse than the rest of the world is over fixes and error correction (which is to say, 16/32/40 bytes here and there). And there's not "big" new default features coming in. --=20 Tom --+dV+xilh7QQozWTa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmECsqgACgkQFHw5/5Y0 tyyF6gwAtDSObtD8/6oJhx62//Lencf5xKuRA8KYkVwz228raP/ED5jdS6wZZjr+ iCRzkJeIzZPNOHbfR9Taco8jThmyxNPE8HCUGRnlf6bbLJGp2ay1TECBaKeQEhRD 7K/ydUIXrntbOv9m3/XVwMREJxdVSKplltKE5MsLSpntUwPwd7X80x2W/5uXDPVn tshSx/Pn+nfwACd7KCQwlVLWWcLJBE4LpDy+L8tUUkrYnsXGxKKKKG4N/vJE/O0j 0XHH3Dc4Ak2C/9mHenSglneDKHyV/Ri8p4lanFlDpx82iRPcevqCkSwKP9LmaAEv TBbuBQmFVn/5eQTyhe67umUnvHYhZAdiCMkHkw7FyVYh91VwlLOOzY1L+gLglRWN q+T/ElzwZRkWcj+X79m/vM7v23/gNVarVGe+6fw3UnfQCwxuT1U0Q6pgNjYuN9Nn YRVhp/FNMCnMFlz4no2y9aFeCW6ujkwVUeyhMVLZN+3h21l7v0aX9XMlaVY9u0G3 csLpQqNs =bd1v -----END PGP SIGNATURE----- --+dV+xilh7QQozWTa--