From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02202C4338F for ; Thu, 29 Jul 2021 14:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA147604DC for ; Thu, 29 Jul 2021 14:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236602AbhG2OVF (ORCPT ); Thu, 29 Jul 2021 10:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234176AbhG2OVC (ORCPT ); Thu, 29 Jul 2021 10:21:02 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F20C0613D5 for ; Thu, 29 Jul 2021 07:20:57 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id m1so10554703pjv.2 for ; Thu, 29 Jul 2021 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F1MJS4je1Oiq7mhlbgvshdM+wBGyXHC/8oJzd/GZ1Bg=; b=Ow6fkhcPEh5V54oLfWWwMO7N3w8hOXvUHnRCEDo6zEciRgrCaJsWFsAcGnHwmh2vzD FPMisuZ3FNXTf1ixYZPueZXd8SlW0Sz5U+WAicNuv3cCxFOuib10hY1RfAbe25NVplGQ cFbNTcFvibLllrPwkX1NyOUGsfubqOt4JDVkl6QEMBEexnkifJfcBERFxqsXLxDQlC6C sWvxUebaqrJx4zyMhNnHramYFQuvyDG0DUp+CZ8TnJsj2WONURIPg4QNHM4xLMgwjz4d aQIxu9xpzTPCVDDZQL0Apsap6Nh+R7+Z0NH4Xj2u0w2G5KRLYVz10F7gqa8OYyYtCME9 Ig2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F1MJS4je1Oiq7mhlbgvshdM+wBGyXHC/8oJzd/GZ1Bg=; b=cTW6uqA7U5SQoJDi92dYGYnNh0A67WrSRvpoATz264ks+BEwrXyzijdoPdScPvfy46 RD+hRQMw281usLa3L1W+AH2a47X+wJfdpb9NNLhP/O9aFjzO8+yxkaxnQ5IqFGE+eZnK xEQkjfZXblNC2vDthM6pxg1wYlU6PoEZgS0v0hM746XyZqoUPAH5DhaOi0XtXKq8A0SG 56hUa8HYJIllwsLMjdk4oxdBmMmZcPrXxCHGyjL01/RTU7yv77ccUIwCqLQwLimGse8j 5p7g8W8t9gInYsURblJ6EbzFNpLIr3mLFYxI/YCSD6K5IJxYkrwWIFzJUcioDMTFm9sk vs3w== X-Gm-Message-State: AOAM530Pz0HEUpZWFODQVaOU/HpAVKVaWUkLY5E2gtZvRVOFjYDtXUwC KidpNP+VXAB3Rhyyd5iZzWs= X-Google-Smtp-Source: ABdhPJwJqoUiFy7YXuGI7xJHhZ4oqQidNFSSfrsgUMREpiAhvQS66r555cMNOfkEqZZH73MivZZI6w== X-Received: by 2002:a17:902:a9c3:b029:12c:31c7:9b81 with SMTP id b3-20020a170902a9c3b029012c31c79b81mr4901232plr.30.1627568456660; Thu, 29 Jul 2021 07:20:56 -0700 (PDT) Received: from ojas ([122.161.51.5]) by smtp.gmail.com with ESMTPSA id p3sm4091663pgi.20.2021.07.29.07.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:20:56 -0700 (PDT) Date: Thu, 29 Jul 2021 19:50:43 +0530 From: Ojaswin Mujoo To: Stefan Wahren Cc: Greg KH , nsaenz@kernel.org, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: <20210729142043.GA25192@ojas> References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> <20210728200607.GB17046@ojas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 10:21:41PM +0200, Stefan Wahren wrote: > Am 28.07.21 um 22:06 schrieb Ojaswin Mujoo: > > On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote: > >> On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > >>> Before this config was defined, the cdev used to be created > >>> unconditionally. When an earlier commit introduced this config, the > >>> default behavior was set to disabled, which might surprise some > >>> unsuspecting users. Hence, make this config default to 'Y' to be more > >>> backward consistent. > >>> > >>> Signed-off-by: Ojaswin Mujoo > >>> --- > >>> drivers/staging/vc04_services/Kconfig | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > >>> index 63caa6818d37..2b70c37cdd09 100644 > >>> --- a/drivers/staging/vc04_services/Kconfig > >>> +++ b/drivers/staging/vc04_services/Kconfig > >>> @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > >>> > >>> config VCHIQ_CDEV > >>> bool "VCHIQ Character Driver" > >>> + default y > >> > >> default y is only if the machine will not work without this option. > >> Is that the case here? If not, then please do not have this as the > >> default. > > Got it Greg. > > > > From my testing, the Raspberry Pi does seem to boot correctly without > > this although some userspace libraries might not work. > > > > Since the machine itself works, I guess I'll drop this patch. > > The idea is good, but the patch needs improvement :) > > Acceptable solution might be that BCM2835_VCHIQ selects VCHIQ_CDEV. Thanks for the suggestion, Stefan. So on testing with select, it seems like select defines a hard reverse dependency i.e if BCM2835_VCHIQ=y then VCHIQ_CDEV=y and it can't be set to n. Checking the Kconfig launguae doc, I found that we could use "imply" to define weak reverse dependencies, such that BCM2835_VCHIQ=y auto selects VCHIQ_CDEV=y but we can also change it back to n if required. I tested this out and it seems to work fine. I believe we can se imply here as it better suits the use case. Thank you, Ojaswin > > > > > Thank you! > > Ojaswin > >> thanks, > >> > >> greg k-h > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04F2C4338F for ; Thu, 29 Jul 2021 14:22:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A859F60560 for ; Thu, 29 Jul 2021 14:22:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A859F60560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uag43HPhB96hRg2SlgiAKTSQMoA6hMXvgTEuYxPuFMk=; b=MSKsqCpoC+5v6B JY5rL4ygzteV76bQO2gPex0OJcRB+RpgnViMsJG62sSSDntujh6a/VnWv4/V/Jax7Dr08wf3/ng1r k3dH5VxcCT3Azh8Rmi6vPZ76TSIhXBIt5FnMNWBBV4RmuGgT1s0o2GcER0IEDt8tgpGcow9W//k6m zdBdOrmmlg2X1URi2WXj03Pxg3L+I4DOkjlppRdh0POVTPNkZ6iYZF3rVKDmbjy90ERWDkYqmTPVG pLv4is8A7DPaul9Qau0E4MSMWp8uH4Vj073YK/nZXvU+ITvEbthmIMM8tezjscME5d8ZVn3FaPcHR wkiJ9x6rbgLE330es2Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m96uD-004VSb-QG; Thu, 29 Jul 2021 14:21:01 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m96u9-004VRj-Mh for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 14:20:59 +0000 Received: by mail-pl1-x629.google.com with SMTP id d1so7196248pll.1 for ; Thu, 29 Jul 2021 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F1MJS4je1Oiq7mhlbgvshdM+wBGyXHC/8oJzd/GZ1Bg=; b=Ow6fkhcPEh5V54oLfWWwMO7N3w8hOXvUHnRCEDo6zEciRgrCaJsWFsAcGnHwmh2vzD FPMisuZ3FNXTf1ixYZPueZXd8SlW0Sz5U+WAicNuv3cCxFOuib10hY1RfAbe25NVplGQ cFbNTcFvibLllrPwkX1NyOUGsfubqOt4JDVkl6QEMBEexnkifJfcBERFxqsXLxDQlC6C sWvxUebaqrJx4zyMhNnHramYFQuvyDG0DUp+CZ8TnJsj2WONURIPg4QNHM4xLMgwjz4d aQIxu9xpzTPCVDDZQL0Apsap6Nh+R7+Z0NH4Xj2u0w2G5KRLYVz10F7gqa8OYyYtCME9 Ig2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F1MJS4je1Oiq7mhlbgvshdM+wBGyXHC/8oJzd/GZ1Bg=; b=NiiH/zu4wOtGU7EYOF9UgWTtXjZUKG1UPM+u0BKYzqWlLoks2hZlUMYsLbdAVP4PTr 9BLQwAQglHyHhbbCd5V2snnmNRuCYPpvI24FsPTR9+Q9rTyHIjsQgeduKW+M6LurWy+r EMxdUGSrpu/oIUbQGKhqhttD+usDT0Q8OE/3P8Ge6l/Bqon8c0uCsPlDgaj2ph1791Oq EUBOX0HjiXWzoY8lVs78ntZG5PsMkDUIkf1itNMUFBxUmHZ1Rg3EXQnRj3LFa+XZ6PXV dW/cjxWGbwM1GcOA5aGihpJxgqZkafDHIzIwJFshPCRFxtF7QFpspGHhFoQnUQXDANG6 pV3A== X-Gm-Message-State: AOAM533p256CQFeDDE8h8XlkwXPnC8nP6Pj80BoqN1RwZb1Mfuy5nHzr 3wtGS9ZAZq9pV/urxQOEHHY= X-Google-Smtp-Source: ABdhPJwJqoUiFy7YXuGI7xJHhZ4oqQidNFSSfrsgUMREpiAhvQS66r555cMNOfkEqZZH73MivZZI6w== X-Received: by 2002:a17:902:a9c3:b029:12c:31c7:9b81 with SMTP id b3-20020a170902a9c3b029012c31c79b81mr4901232plr.30.1627568456660; Thu, 29 Jul 2021 07:20:56 -0700 (PDT) Received: from ojas ([122.161.51.5]) by smtp.gmail.com with ESMTPSA id p3sm4091663pgi.20.2021.07.29.07.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:20:56 -0700 (PDT) Date: Thu, 29 Jul 2021 19:50:43 +0530 From: Ojaswin Mujoo To: Stefan Wahren Cc: Greg KH , nsaenz@kernel.org, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: <20210729142043.GA25192@ojas> References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> <20210728200607.GB17046@ojas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_072057_787540_7CBC494B X-CRM114-Status: GOOD ( 28.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 10:21:41PM +0200, Stefan Wahren wrote: > Am 28.07.21 um 22:06 schrieb Ojaswin Mujoo: > > On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote: > >> On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > >>> Before this config was defined, the cdev used to be created > >>> unconditionally. When an earlier commit introduced this config, the > >>> default behavior was set to disabled, which might surprise some > >>> unsuspecting users. Hence, make this config default to 'Y' to be more > >>> backward consistent. > >>> > >>> Signed-off-by: Ojaswin Mujoo > >>> --- > >>> drivers/staging/vc04_services/Kconfig | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > >>> index 63caa6818d37..2b70c37cdd09 100644 > >>> --- a/drivers/staging/vc04_services/Kconfig > >>> +++ b/drivers/staging/vc04_services/Kconfig > >>> @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > >>> > >>> config VCHIQ_CDEV > >>> bool "VCHIQ Character Driver" > >>> + default y > >> > >> default y is only if the machine will not work without this option. > >> Is that the case here? If not, then please do not have this as the > >> default. > > Got it Greg. > > > > From my testing, the Raspberry Pi does seem to boot correctly without > > this although some userspace libraries might not work. > > > > Since the machine itself works, I guess I'll drop this patch. > > The idea is good, but the patch needs improvement :) > > Acceptable solution might be that BCM2835_VCHIQ selects VCHIQ_CDEV. Thanks for the suggestion, Stefan. So on testing with select, it seems like select defines a hard reverse dependency i.e if BCM2835_VCHIQ=y then VCHIQ_CDEV=y and it can't be set to n. Checking the Kconfig launguae doc, I found that we could use "imply" to define weak reverse dependencies, such that BCM2835_VCHIQ=y auto selects VCHIQ_CDEV=y but we can also change it back to n if required. I tested this out and it seems to work fine. I believe we can se imply here as it better suits the use case. Thank you, Ojaswin > > > > > Thank you! > > Ojaswin > >> thanks, > >> > >> greg k-h > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel