From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MIME_BASE64_TEXT,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEDCC4320A for ; Thu, 29 Jul 2021 16:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D046860F42 for ; Thu, 29 Jul 2021 16:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbhG2QBs (ORCPT ); Thu, 29 Jul 2021 12:01:48 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:31265 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S238486AbhG2QAO (ORCPT ); Thu, 29 Jul 2021 12:00:14 -0400 X-UUID: 36b79c4521e141579b1629a2cd57443d-20210729 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=FmMPo1YNUA+2iUSxBL6ChqAQr9+S6f3vHwPsCvfChoo=; b=IPdNOmnVtffvAZPsvYRXBno+LDszfNichAqebQd6xhHt5wjPUQeF7ofMuRkkaJLmL3mmaa23XlV4u8D44MO9A/sZjaWPecFBCEVHnWnUIu0yHLmW2n8J37wBQRGTU36zpNqkLGW/uUKVUrJMfnyMKJ1ebuAYzE23HM9sUutPN14=; X-UUID: 36b79c4521e141579b1629a2cd57443d-20210729 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 206471542; Thu, 29 Jul 2021 23:59:18 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Jul 2021 23:59:16 +0800 Received: from localhost.localdomain (10.15.20.246) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 29 Jul 2021 23:59:15 +0800 From: Rocco Yue To: David Ahern CC: "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Matthias Brugger , , , , , , Rocco Yue Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message Date: Thu, 29 Jul 2021 23:42:51 +0800 Message-ID: <20210729154251.1380-1-rocco.yue@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 84ED98E54976BBFA2B0C83D314996E8EF6CAE2511184AF380DDEB250A244991C2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIxLTA3LTI5IGF0IDA4OjQxIC0wNjAwLCBEYXZpZCBBaGVybiB3cm90ZToNCj4g T24gNy8yOS8yMSAzOjAyIEFNLCBSb2NjbyBZdWUgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS91YXBpL2xpbnV4L2lmX2xpbmsuaCBiL2luY2x1ZGUvdWFwaS9saW51eC9pZl9saW5rLmgN Cj4+IGluZGV4IDQ4ODJlODE1MTRiNi4uZWE2Yzg3MmM1ZjJjIDEwMDY0NA0KPj4gLS0tIGEvaW5j bHVkZS91YXBpL2xpbnV4L2lmX2xpbmsuaA0KPj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L2lm X2xpbmsuaA0KPj4gQEAgLTM0Nyw3ICszNDcsNyBAQCBlbnVtIHsNCj4+ICAJICovDQo+PiAgCUlG TEFfUEFSRU5UX0RFVl9OQU1FLA0KPj4gIAlJRkxBX1BBUkVOVF9ERVZfQlVTX05BTUUsDQo+PiAt DQo+PiArCUlGTEFfUkFfTVRVLA0KPj4gIAlfX0lGTEFfTUFYDQo+PiAgfTsNCj4+ICANCj4+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvaXB2Ni5oIGIvaW5jbHVkZS91YXBpL2xpbnV4 L2lwdjYuaA0KPj4gaW5kZXggNzA2MDM3NzVmZTkxLi4zZGJjZjIxMmI3NjYgMTAwNjQ0DQo+PiAt LS0gYS9pbmNsdWRlL3VhcGkvbGludXgvaXB2Ni5oDQo+PiArKysgYi9pbmNsdWRlL3VhcGkvbGlu dXgvaXB2Ni5oDQo+PiBAQCAtMTkwLDYgKzE5MCw3IEBAIGVudW0gew0KPj4gIAlERVZDT05GX05E SVNDX1RDTEFTUywNCj4+ICAJREVWQ09ORl9SUExfU0VHX0VOQUJMRUQsDQo+PiAgCURFVkNPTkZf UkFfREVGUlRSX01FVFJJQywNCj4+ICsJREVWQ09ORl9SQV9NVFUsDQo+PiAgCURFVkNPTkZfTUFY DQo+PiAgfTsNCj4+ICANCj4gDQo+IHlvdSBkbyBub3QgbmVlZCBib3RoIElGTEEgYW5kIERFVkNP TkYuIERyb3AgdGhlIERFVkNPTkYgY29tcGxldGVseS4gSUZMQQ0KPiBhdHRyaWJ1dGUgY2FuIGJl IHVzZWQgZm9yIGJvdGggaW5zcGVjdGlvbiBhbmQgbm90aWZpY2F0aW9uIG9uIGNoYW5nZS4NCg0K SGkgRGF2aWQsDQoNClRoYW5rcyBmb3IgeW91ciByZXZpZXcuDQoNCkJlY2F1c2UgdGhlIHB1cnBv c2Ugb2YgdGhpcyBwYXRjaCBpcyBmb3IgdXNlcnNwYWNlIHRvIGNvcnJlY3RseSByZWFkIHRoZQ0K cmFfbXR1IHZhbHVlIG9mIGRpZmZlcmVudCBuZXR3b3JrIGRldmljZSwgaWYgdGhlIERFVkNPTkYg aXMgY29tcGxldGVseSBkcm9wcGVkLA0KZG9lcyB0aGF0IG1lYW4gSSBjYW4gYWRkIHRoZSAicmFf bXR1IiBtZW1iZXIgaW4gdGhlICJzdHJ1Y3QgbmV0X2RldmljZSIgLg0KDQo+IEFsc28gZG8gbm90 IGFkZCBtYWlsaW5nIGxpc3RzIHRoYXQgY2F1c2UgYm91bmNlcy4gU3BlY2lmaWNhbGx5LCB5b3Ug dGVuZA0KPiB0byBhZGQgd3NkX3Vwc3RyZWFtQG1lZGlhdGVrLmNvbSBhcyBhIGNjIGFuZCBldmVy eSByZXNwb25zZSB0byB5b3UNCj4gZ2VuZXJhdGVzIGEgYm91bmNlIG1lc3NhZ2UgZm9yIHRoaXMg YWRkcmVzcy4NCg0KVGhhbmtzIGZvciBwb2ludGluZyBvdXQgdGhlIHByb2JsZW0sIEkgd2lsbCBy ZW1vdmUgaXQgZnJvbSB0aGUgbWFpbGluZyBsaXN0Lg0KDQpCZXN0IFJlZ2FyZHMsDQpSb2Njbw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56D7C4320A for ; Thu, 29 Jul 2021 16:04:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EFA560F4A for ; Thu, 29 Jul 2021 16:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6EFA560F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dNDT9rhH4fAn3qIW9+ZgkvhJoI3CKxCfTeJdf+PEqkE=; b=wiKapraVQqrM71 8pzM6n8PTTE4m9JRbeieqFdL9/+7uAtlGSNLneU57GXz0Yj7lxWA7St47fWDLfkYcjWoNLurednEj TvGDsbS6/Aies+sy58XGGRTJf0/E8dPFStg2LvlY5f/I6UWzqDfm8EmLLdRMwkuyuYHJanS6zPTnB C6Gg/iwA9LbovfIuDOo7GqXCRGdl2N0Ty7fNHEaAyBVXTLp/zNg1Lxf5awwcUP3sc5effrdGuR1cN vDf55XVeTSovLJsGvvBCQMoXbjHf5m4Zxm0ING/2aavxTIQQZMKRGwlr3cG71MKucUPkBM65ot7Y7 0CGtxtZsdqCz3gqEbECg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98WI-004vv9-7s; Thu, 29 Jul 2021 16:04:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98RQ-004seQ-S3; Thu, 29 Jul 2021 15:59:26 +0000 X-UUID: f5698c0d1ad844afa98908b8fadf58df-20210729 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=FmMPo1YNUA+2iUSxBL6ChqAQr9+S6f3vHwPsCvfChoo=; b=IPdNOmnVtffvAZPsvYRXBno+LDszfNichAqebQd6xhHt5wjPUQeF7ofMuRkkaJLmL3mmaa23XlV4u8D44MO9A/sZjaWPecFBCEVHnWnUIu0yHLmW2n8J37wBQRGTU36zpNqkLGW/uUKVUrJMfnyMKJ1ebuAYzE23HM9sUutPN14=; X-UUID: f5698c0d1ad844afa98908b8fadf58df-20210729 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1335201524; Thu, 29 Jul 2021 08:59:20 -0700 Received: from MTKMBS32N2.mediatek.inc (172.27.4.72) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Jul 2021 08:59:19 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Jul 2021 23:59:16 +0800 Received: from localhost.localdomain (10.15.20.246) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 29 Jul 2021 23:59:15 +0800 From: Rocco Yue To: David Ahern CC: "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Matthias Brugger , , , , , , Rocco Yue Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message Date: Thu, 29 Jul 2021 23:42:51 +0800 Message-ID: <20210729154251.1380-1-rocco.yue@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-TM-SNTS-SMTP: 84ED98E54976BBFA2B0C83D314996E8EF6CAE2511184AF380DDEB250A244991C2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_085924_978701_4F9959FE X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2021-07-29 at 08:41 -0600, David Ahern wrote: > On 7/29/21 3:02 AM, Rocco Yue wrote: >> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> index 4882e81514b6..ea6c872c5f2c 100644 >> --- a/include/uapi/linux/if_link.h >> +++ b/include/uapi/linux/if_link.h >> @@ -347,7 +347,7 @@ enum { >> */ >> IFLA_PARENT_DEV_NAME, >> IFLA_PARENT_DEV_BUS_NAME, >> - >> + IFLA_RA_MTU, >> __IFLA_MAX >> }; >> >> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h >> index 70603775fe91..3dbcf212b766 100644 >> --- a/include/uapi/linux/ipv6.h >> +++ b/include/uapi/linux/ipv6.h >> @@ -190,6 +190,7 @@ enum { >> DEVCONF_NDISC_TCLASS, >> DEVCONF_RPL_SEG_ENABLED, >> DEVCONF_RA_DEFRTR_METRIC, >> + DEVCONF_RA_MTU, >> DEVCONF_MAX >> }; >> > > you do not need both IFLA and DEVCONF. Drop the DEVCONF completely. IFLA > attribute can be used for both inspection and notification on change. Hi David, Thanks for your review. Because the purpose of this patch is for userspace to correctly read the ra_mtu value of different network device, if the DEVCONF is completely dropped, does that mean I can add the "ra_mtu" member in the "struct net_device" . > Also do not add mailing lists that cause bounces. Specifically, you tend > to add wsd_upstream@mediatek.com as a cc and every response to you > generates a bounce message for this address. Thanks for pointing out the problem, I will remove it from the mailing list. Best Regards, Rocco _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8BBC4338F for ; Thu, 29 Jul 2021 16:05:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79AA460F42 for ; Thu, 29 Jul 2021 16:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 79AA460F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KciX+iy2LV9gsApU9DRI5XIS0dqJjtu8RssqQpmurI4=; b=Wbu9I+Gw+65RAZ wIpaqr8/aH/cCRpgqHPtHUKmgFo9o3iMA4gjdjAH++5q4gaWovfdTyePAHfb6xAOXrhxDNpGVfHHv 2sfscFSVAfwlUn7b/Hal/ipPNUn533F2g9jtqkKXV9f5oQlSNa3jTvYKHZva13+kVar9oUo2ncQW0 PRF4/mOJAuep7nNoQ1xoUvrW6a8A09gIqW5+z63DCPoO7o/cTOetvm9xYMA6xNF1metHqwbsLAGFE vT4remUfRgDbClzAnOA+hGiUD0vlDpoIwMNbozc1/JkdbLcgT8uv4J65FGMSNhNzM8lobuDKqIFjR od8gZ6VzoWLpy3X85uaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98VD-004v3Y-AA; Thu, 29 Jul 2021 16:03:20 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98RQ-004seQ-S3; Thu, 29 Jul 2021 15:59:26 +0000 X-UUID: f5698c0d1ad844afa98908b8fadf58df-20210729 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=FmMPo1YNUA+2iUSxBL6ChqAQr9+S6f3vHwPsCvfChoo=; b=IPdNOmnVtffvAZPsvYRXBno+LDszfNichAqebQd6xhHt5wjPUQeF7ofMuRkkaJLmL3mmaa23XlV4u8D44MO9A/sZjaWPecFBCEVHnWnUIu0yHLmW2n8J37wBQRGTU36zpNqkLGW/uUKVUrJMfnyMKJ1ebuAYzE23HM9sUutPN14=; X-UUID: f5698c0d1ad844afa98908b8fadf58df-20210729 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1335201524; Thu, 29 Jul 2021 08:59:20 -0700 Received: from MTKMBS32N2.mediatek.inc (172.27.4.72) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Jul 2021 08:59:19 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Jul 2021 23:59:16 +0800 Received: from localhost.localdomain (10.15.20.246) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 29 Jul 2021 23:59:15 +0800 From: Rocco Yue To: David Ahern CC: "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Matthias Brugger , , , , , , Rocco Yue Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message Date: Thu, 29 Jul 2021 23:42:51 +0800 Message-ID: <20210729154251.1380-1-rocco.yue@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-TM-SNTS-SMTP: 84ED98E54976BBFA2B0C83D314996E8EF6CAE2511184AF380DDEB250A244991C2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_085924_978701_4F9959FE X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-07-29 at 08:41 -0600, David Ahern wrote: > On 7/29/21 3:02 AM, Rocco Yue wrote: >> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> index 4882e81514b6..ea6c872c5f2c 100644 >> --- a/include/uapi/linux/if_link.h >> +++ b/include/uapi/linux/if_link.h >> @@ -347,7 +347,7 @@ enum { >> */ >> IFLA_PARENT_DEV_NAME, >> IFLA_PARENT_DEV_BUS_NAME, >> - >> + IFLA_RA_MTU, >> __IFLA_MAX >> }; >> >> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h >> index 70603775fe91..3dbcf212b766 100644 >> --- a/include/uapi/linux/ipv6.h >> +++ b/include/uapi/linux/ipv6.h >> @@ -190,6 +190,7 @@ enum { >> DEVCONF_NDISC_TCLASS, >> DEVCONF_RPL_SEG_ENABLED, >> DEVCONF_RA_DEFRTR_METRIC, >> + DEVCONF_RA_MTU, >> DEVCONF_MAX >> }; >> > > you do not need both IFLA and DEVCONF. Drop the DEVCONF completely. IFLA > attribute can be used for both inspection and notification on change. Hi David, Thanks for your review. Because the purpose of this patch is for userspace to correctly read the ra_mtu value of different network device, if the DEVCONF is completely dropped, does that mean I can add the "ra_mtu" member in the "struct net_device" . > Also do not add mailing lists that cause bounces. Specifically, you tend > to add wsd_upstream@mediatek.com as a cc and every response to you > generates a bounce message for this address. Thanks for pointing out the problem, I will remove it from the mailing list. Best Regards, Rocco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel