From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF69C4320A for ; Thu, 29 Jul 2021 16:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07B3060EFD for ; Thu, 29 Jul 2021 16:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbhG2Q2F (ORCPT ); Thu, 29 Jul 2021 12:28:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:37828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbhG2Q2D (ORCPT ); Thu, 29 Jul 2021 12:28:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 078AD60EBC; Thu, 29 Jul 2021 16:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627576080; bh=CvOqRzt/g6Rw1NKHXA+7nr0/VVubdZQ+mfUdQfknYDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zso5K6vF7iLIIP6lLjyUL9fpnOp3o305FuRnjSxsPmk8K+Ddiy75rUZKv3UExaTT+ PuFo7E5v2ArPmWHJwGd7x5GgTj17UM7cu3881B5Dbd9dYlLZREQwSkt/jhsh8mZ90T Axj4x7cYV7slIkyW4dgbdUVQ68POmWR995wlCRkjYVSWSh4zXnjWhPceOTBMUcUK4i Mtt369mlBuAhAJGiMXI1QmhgSkEkzTgEqWNQ8Ig7nyfzqLQGasyoY+yNd0U8WAOxli EWuhzaKnQNr1fTWoZFpJK1Eaa47GagKjczycWqpQw43kNDJgTCdF9tzRifYdwZbID7 Spt2d1PE6vYUQ== Date: Thu, 29 Jul 2021 17:27:49 +0100 From: Mark Brown To: Mark Rutland Cc: "Madhavan T. Venkataraman" , jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list Message-ID: <20210729162749.GA51855@sirena.org.uk> References: <3f2aab69a35c243c5e97f47c4ad84046355f5b90> <20210630223356.58714-1-madvenka@linux.microsoft.com> <20210630223356.58714-4-madvenka@linux.microsoft.com> <20210728172523.GB47345@C02TD0UTHF1T.local> <20210729154804.GA59940@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20210729154804.GA59940@C02TD0UTHF1T.local> X-Cookie: VMS must die! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 29, 2021 at 04:48:04PM +0100, Mark Rutland wrote: > For clarity, let's take your bullet-point list above as a list of > examples, and make that: > /* > * As SYM_CODE functions don't follow the usual calling > * conventions, we assume by default that any SYM_CODE function > * cannot be unwound reliably. > * > * Note that this includes: > * > * - Exception handlers and entry assembly > * - Trampoline assembly (e.g., ftrace, kprobes) > * - Hypervisor-related assembly > * - Hibernation-related assembly > * - CPU start-stop, suspend-resume assembly > * - Kernel relocation assembly > */ This looks good to me too. --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEC1wUACgkQJNaLcl1U h9B3nAf/W+DFa6KhVwLfYCNK/YINgbYkQ2PX6aK5YaXVpNLdubnoFzZRc8SWVXsu xUvVzMn23qa6iywsltCV7vAoHHI/fBRaeAhytW4lAVXsboBCxYh69l4F7k+3S9+a kayTQ7uFxwItlvNqUot01COUpggzckyJs71brGRIR41duJI402C0l0wLlMc/2wAr aqKpI0j6iNKgScKmZCAyRhfrj0ZUBMhS4PgcQwrahC3s06auA+i3Hij0POLEcfvE +ItAzrC1QdhWErljx0BKYJKvIRbiGSHQvzV6S0iHycE4pnq/t69EVj1FPuUdILGS lBKOuDyU5wpEM5lxxfrPM0PRu+zm7w== =s+5z -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0663CC4320A for ; Thu, 29 Jul 2021 16:29:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C906E60EBC for ; Thu, 29 Jul 2021 16:29:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C906E60EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rx5X7QCq64XYq4d3MNYoUaankxQY6BgmJZoIsEUceiw=; b=IMXFL7Bs/1nXqwe82WUb6OG54t LCvxbwI9yyZHl2h1ltzNVUmhFoEac5LtgSDxYNRh5AXuSw+/0F1o++OK8jBv5S2S1vAdBui3XeOc+ GVECaW2S0ixwfDQUmrovbYt7qgbPLBBgugpM+P/SFteHtdhQoYryLAVLjxjwW6F0LpGxiJ4gp55wz XgXp3KSruQkHh72lYs/6lFZmaihqLRGUK+Uuxdse6VnRAOe9EhrdsRrdP7yvIjw1o6WlcUx8EvUSs bQthFcd8sILoflIgfN8ip+6lvBI8rnhs0D75/oqiu0d65B4mlvcuymwWhL1y1p6KBGLUeQYX4Pd/X TrcGZhxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98tA-0055Q4-4h; Thu, 29 Jul 2021 16:28:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m98t6-0055PV-Qw for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 16:28:02 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 078AD60EBC; Thu, 29 Jul 2021 16:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627576080; bh=CvOqRzt/g6Rw1NKHXA+7nr0/VVubdZQ+mfUdQfknYDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zso5K6vF7iLIIP6lLjyUL9fpnOp3o305FuRnjSxsPmk8K+Ddiy75rUZKv3UExaTT+ PuFo7E5v2ArPmWHJwGd7x5GgTj17UM7cu3881B5Dbd9dYlLZREQwSkt/jhsh8mZ90T Axj4x7cYV7slIkyW4dgbdUVQ68POmWR995wlCRkjYVSWSh4zXnjWhPceOTBMUcUK4i Mtt369mlBuAhAJGiMXI1QmhgSkEkzTgEqWNQ8Ig7nyfzqLQGasyoY+yNd0U8WAOxli EWuhzaKnQNr1fTWoZFpJK1Eaa47GagKjczycWqpQw43kNDJgTCdF9tzRifYdwZbID7 Spt2d1PE6vYUQ== Date: Thu, 29 Jul 2021 17:27:49 +0100 From: Mark Brown To: Mark Rutland Cc: "Madhavan T. Venkataraman" , jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list Message-ID: <20210729162749.GA51855@sirena.org.uk> References: <3f2aab69a35c243c5e97f47c4ad84046355f5b90> <20210630223356.58714-1-madvenka@linux.microsoft.com> <20210630223356.58714-4-madvenka@linux.microsoft.com> <20210728172523.GB47345@C02TD0UTHF1T.local> <20210729154804.GA59940@C02TD0UTHF1T.local> MIME-Version: 1.0 In-Reply-To: <20210729154804.GA59940@C02TD0UTHF1T.local> X-Cookie: VMS must die! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_092800_934864_579F411D X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3374818900335949984==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3374818900335949984== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 29, 2021 at 04:48:04PM +0100, Mark Rutland wrote: > For clarity, let's take your bullet-point list above as a list of > examples, and make that: > /* > * As SYM_CODE functions don't follow the usual calling > * conventions, we assume by default that any SYM_CODE function > * cannot be unwound reliably. > * > * Note that this includes: > * > * - Exception handlers and entry assembly > * - Trampoline assembly (e.g., ftrace, kprobes) > * - Hypervisor-related assembly > * - Hibernation-related assembly > * - CPU start-stop, suspend-resume assembly > * - Kernel relocation assembly > */ This looks good to me too. --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEC1wUACgkQJNaLcl1U h9B3nAf/W+DFa6KhVwLfYCNK/YINgbYkQ2PX6aK5YaXVpNLdubnoFzZRc8SWVXsu xUvVzMn23qa6iywsltCV7vAoHHI/fBRaeAhytW4lAVXsboBCxYh69l4F7k+3S9+a kayTQ7uFxwItlvNqUot01COUpggzckyJs71brGRIR41duJI402C0l0wLlMc/2wAr aqKpI0j6iNKgScKmZCAyRhfrj0ZUBMhS4PgcQwrahC3s06auA+i3Hij0POLEcfvE +ItAzrC1QdhWErljx0BKYJKvIRbiGSHQvzV6S0iHycE4pnq/t69EVj1FPuUdILGS lBKOuDyU5wpEM5lxxfrPM0PRu+zm7w== =s+5z -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- --===============3374818900335949984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3374818900335949984==--