All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: update comment at log_conflicting_inodes()
Date: Thu, 29 Jul 2021 19:29:16 +0200	[thread overview]
Message-ID: <20210729172916.GB5047@twin.jikos.cz> (raw)
In-Reply-To: <26f8585750e2eb8fc1f0bbaf975681277e93a1a8.1627568981.git.fdmanana@suse.com>

On Thu, Jul 29, 2021 at 03:30:21PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> A comment at log_conflicting_inodes() mentions that we check the inode's
> logged_trans field instead of using btrfs_inode_in_log() because the field
> last_log_commit is not updated when we log that an inode exists and the
> inode has the full sync flag (BTRFS_INODE_NEEDS_FULL_SYNC) set. The part
> about the full sync flag is not true anymore since commit 9acc8103ab594f
> ("btrfs: fix unpersisted i_size on fsync after expanding truncate"), so
> update the comment to not mention that part anymore.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-next, thanks.

      reply	other threads:[~2021-07-29 17:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 14:30 [PATCH] btrfs: update comment at log_conflicting_inodes() fdmanana
2021-07-29 17:29 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729172916.GB5047@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.