From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove no longer needed full sync flag check at inode_logged()
Date: Thu, 29 Jul 2021 19:30:12 +0200 [thread overview]
Message-ID: <20210729173012.GC5047@twin.jikos.cz> (raw)
In-Reply-To: <be665ad9dd952a442dbb8448539c87d2593e081a.1627568480.git.fdmanana@suse.com>
On Thu, Jul 29, 2021 at 03:29:01PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Now that we are checking if the inode's logged_trans is 0 to detect the
> possibility of the inode having been evicted and reloaded, the test for
> the full sync flag (BTRFS_INODE_NEEDS_FULL_SYNC) is no longer needed at
> tree-log.c:inode_logged(). Its purpose was to detect the possibility
> of a previous eviction as well, since when an inode is loaded the full
> sync flag is always set on it (and only cleared after the inode is
> logged).
>
> So just remove the check and update the comment. The check for the inode's
> logged_trans being 0 was added recently by the patch with the subject
> "btrfs: eliminate some false positives when checking if inode was logged".
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2021-07-29 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:29 [PATCH] btrfs: remove no longer needed full sync flag check at inode_logged() fdmanana
2021-07-29 17:30 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729173012.GC5047@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.