All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	kernel@pengutronix.de
Subject: Re: [PATCH v1 5/5] PCI: Drop duplicated tracking of a pci_dev's bound driver
Date: Fri, 30 Jul 2021 07:24:26 +0200	[thread overview]
Message-ID: <20210730052426.2zmjy62y3ipanad6@pengutronix.de> (raw)
In-Reply-To: <YQOKs8Lsk8Rej5W2@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On Fri, Jul 30, 2021 at 07:14:27AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jul 29, 2021 at 10:37:40PM +0200, Uwe Kleine-König wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> I know I can not take patches without any changelog text, maybe other
> maintainers are more lax :(

Ah right, I admit to not invest much car here, mainly because I
didn't expect that this patch makes it in very soon as there are many
maintainers involved in the patches this one depends on.

I'd write something like:

Currently it's tracked twice which driver is bound to a given pci
device. Now that all users of the pci specific one (struct
pci_dev::driver) are updated to use an access macro
(pci_driver_of_dev()), change the macro to use the information from the
driver core and remove the driver member from struct pci_dev.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-07-30  5:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 20:37 [PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's bound driver Uwe Kleine-König
2021-07-29 20:37 ` Uwe Kleine-König
2021-07-29 20:37 ` [PATCH v1 1/5] PCI: Simplify pci_device_remove() Uwe Kleine-König
2021-07-29 20:37 ` [PATCH v1 2/5] PCI: Drop useless check from pci_device_probe() Uwe Kleine-König
2021-07-29 20:37 ` [PATCH v1 3/5] PCI: Provide wrapper to access a pci_dev's bound driver Uwe Kleine-König
2021-07-29 20:37 ` [PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly Uwe Kleine-König
2021-07-29 20:37   ` Uwe Kleine-König
2021-07-30 20:37   ` Boris Ostrovsky
2021-07-30 20:37     ` Boris Ostrovsky
2021-07-31 12:08     ` Uwe Kleine-König
2021-07-31 12:08       ` Uwe Kleine-König
2021-08-02 13:06       ` Boris Ostrovsky
2021-08-02 13:06         ` Boris Ostrovsky
2021-07-29 20:37 ` [PATCH v1 5/5] PCI: Drop duplicated tracking of a pci_dev's bound driver Uwe Kleine-König
2021-07-30  5:14   ` Greg Kroah-Hartman
2021-07-30  5:24     ` Uwe Kleine-König [this message]
2021-07-30  5:14 ` [PATCH v1 0/5] " Greg Kroah-Hartman
2021-07-30  5:14   ` Greg Kroah-Hartman
2021-07-30  8:06 ` Andy Shevchenko
2021-07-30  8:06   ` Andy Shevchenko
2021-07-30 17:48   ` Uwe Kleine-König
2021-07-30 17:48     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730052426.2zmjy62y3ipanad6@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=bhelgaas@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.