From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38AFC4338F for ; Fri, 30 Jul 2021 12:05:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A80260F01 for ; Fri, 30 Jul 2021 12:05:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A80260F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8PTiiGOP+HNfkiH8E1ErEEOQq/MFAqLHE8viEQZiRrY=; b=DCGKC7/rSird/l lpSan59L+zBqbov8fa4b7ks3AQy0YEU1mAxBTTDG03TQvISNCvtvEtXyWJuYFYAOAskuv38lyUBOo e6UfDCIAVxUVvHheOpIVLVX+4devO7yGJy/BAiD4M2XGU1G3zzXSCbzNZzfFJy1PujfG6y33Bh0z1 d8qnX0IA+mI3ircYgRtvoBMFL7gzUle/TKgV+tB3hsuQQinUJkwqjfHa4oaIyp6hXjT8+XbY1xc5b Ez3o1oy7bUZdcQJWv9KbeN5yIR68mYyEQ7hhO7o0Fs9eoG5ifPrNq6nBvyV1Iu+aGFF8Ct7xsHpYu K5rIEgo4ws6sja9EgSsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9REz-008UbA-F6; Fri, 30 Jul 2021 12:03:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9REw-008UaE-66 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 12:03:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50DDC61050; Fri, 30 Jul 2021 12:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627646620; bh=l4xCjprPedI5vURhmWL/fgGTrXNfNk+rIsUtrTdUcBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TUZ1PqAwewIUZ4qgd8zQvv9222Tb0CDzahMW/GpC9/UlGIQ6js/bSKdBvTO+C35aa JtCKXeqo6LmqbdEGwkLSotD3hhBgP/C9WMV0Pwhbe2/QwUb7ecNXg9KUiM7Op3LQOg 7H/LfCPemAuVnZBUlGveVods7oInp0SVacs5sA7tAaJKO48w153dhM9DsJoCc7M9Ro xOGyKwWxcZNiN2BoKUc7WdniXDSAQfl/qbV4amfowjf+0y/FkMQtrGKQlbOcMIyMWz WNrUfGdWCj34I4Obu+omsDD5FB/E+Q14x1Yn0sWbNIjNjR0dpTe1atHaYIjx9MWQny hwNw0snE7olgw== Date: Fri, 30 Jul 2021 13:03:36 +0100 From: Will Deacon To: Shaokun Zhang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Marc Zyngier Subject: Re: [PATCH v2] arm64: cpufeature: Use defined macro instead of magic numbers Message-ID: <20210730120335.GA23589@willie-the-truck> References: <1626415089-57584-1-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1626415089-57584-1-git-send-email-zhangshaokun@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_050346_287864_3F2CBD2F X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 16, 2021 at 01:58:09PM +0800, Shaokun Zhang wrote: > Use defined macro to simplify the code and make it more readable. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Signed-off-by: Shaokun Zhang > --- > ChangeLog: > v1-->v2: > 1. Address Will's comment to make code more readable. > > arch/arm64/kernel/cpufeature.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 125d5c9471ac..93004bc8e1e8 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -1733,7 +1733,7 @@ static void cpu_has_fwb(const struct arm64_cpu_capabilities *__unused) > u64 val = read_sysreg_s(SYS_CLIDR_EL1); > > /* Check that CLIDR_EL1.LOU{U,IS} are both 0 */ > - WARN_ON(val & (7 << 27 | 7 << 21)); > + WARN_ON(CLIDR_LOUU(val) || CLIDR_LOUIS(val)); Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel