From: Michal Kubecek <mkubecek@suse.cz>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev,
Richard Cochran <richardcochran@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Shuah Khan <shuah@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rui Sousa <rui.sousa@nxp.com>,
Sebastien Laveze <sebastien.laveze@nxp.com>
Subject: Re: [net-next, v4, 05/11] ethtool: add a new command for getting PHC virtual clocks
Date: Sun, 29 Aug 2021 19:04:15 +0200 [thread overview]
Message-ID: <20210829170415.hztnbqswszx27hvf@lion.mk-sys.cz> (raw)
In-Reply-To: <20210625093513.38524-6-yangbo.lu@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3236 bytes --]
On Fri, Jun 25, 2021 at 05:35:07PM +0800, Yangbo Lu wrote:
> Add an interface for getting PHC (PTP Hardware Clock)
> virtual clocks, which are based on PHC physical clock
> providing hardware timestamp to network packets.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
Hello,
do you plan to submit also an ethtool (userspace utility) patch using
this interface?
Michal
> ---
> Changes for v3:
> - Added this patch.
> Changes for v4:
> - Updated doc.
> - Removed ioctl command.
> - Replied only the number of vclock index.
> ---
> Documentation/networking/ethtool-netlink.rst | 22 +++++
> include/linux/ethtool.h | 10 +++
> include/uapi/linux/ethtool_netlink.h | 15 ++++
> net/ethtool/Makefile | 2 +-
> net/ethtool/common.c | 13 +++
> net/ethtool/netlink.c | 10 +++
> net/ethtool/netlink.h | 2 +
> net/ethtool/phc_vclocks.c | 94 ++++++++++++++++++++
> 8 files changed, 167 insertions(+), 1 deletion(-)
> create mode 100644 net/ethtool/phc_vclocks.c
>
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index 6ea91e41593f..c86628e6a235 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -212,6 +212,7 @@ Userspace to kernel:
> ``ETHTOOL_MSG_FEC_SET`` set FEC settings
> ``ETHTOOL_MSG_MODULE_EEPROM_GET`` read SFP module EEPROM
> ``ETHTOOL_MSG_STATS_GET`` get standard statistics
> + ``ETHTOOL_MSG_PHC_VCLOCKS_GET`` get PHC virtual clocks info
> ===================================== ================================
>
> Kernel to userspace:
> @@ -250,6 +251,7 @@ Kernel to userspace:
> ``ETHTOOL_MSG_FEC_NTF`` FEC settings
> ``ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY`` read SFP module EEPROM
> ``ETHTOOL_MSG_STATS_GET_REPLY`` standard statistics
> + ``ETHTOOL_MSG_PHC_VCLOCKS_GET_REPLY`` PHC virtual clocks info
> ======================================== =================================
>
> ``GET`` requests are sent by userspace applications to retrieve device
> @@ -1477,6 +1479,25 @@ Low and high bounds are inclusive, for example:
> etherStatsPkts512to1023Octets 512 1023
> ============================= ==== ====
>
> +PHC_VCLOCKS_GET
> +===============
> +
> +Query device PHC virtual clocks information.
> +
> +Request contents:
> +
> + ==================================== ====== ==========================
> + ``ETHTOOL_A_PHC_VCLOCKS_HEADER`` nested request header
> + ==================================== ====== ==========================
> +
> +Kernel response contents:
> +
> + ==================================== ====== ==========================
> + ``ETHTOOL_A_PHC_VCLOCKS_HEADER`` nested reply header
> + ``ETHTOOL_A_PHC_VCLOCKS_NUM`` u32 PHC virtual clocks number
> + ``ETHTOOL_A_PHC_VCLOCKS_INDEX`` s32 PHC index array
> + ==================================== ====== ==========================
[...]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-29 17:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 9:35 [net-next, v4, 00/11] ptp: support virtual clocks and timestamping Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 01/11] ptp: add ptp virtual clock driver framework Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 02/11] ptp: support ptp physical/virtual clocks conversion Yangbo Lu
2021-06-27 9:50 ` [ptp] d7b8e363d0: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2021-06-27 9:50 ` kernel test robot
2021-06-25 9:35 ` [net-next, v4, 03/11] ptp: track available ptp vclocks information Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 04/11] ptp: add kernel API ptp_get_vclocks_index() Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 05/11] ethtool: add a new command for getting PHC virtual clocks Yangbo Lu
2021-08-29 17:04 ` Michal Kubecek [this message]
2021-06-25 9:35 ` [net-next, v4, 06/11] ptp: add kernel API ptp_convert_timestamp() Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 07/11] mptcp: setsockopt: convert to mptcp_setsockopt_sol_socket_timestamping() Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 08/11] net: sock: extend SO_TIMESTAMPING for PHC binding Yangbo Lu
2021-06-25 14:19 ` kernel test robot
2021-06-25 14:19 ` kernel test robot
2021-06-26 0:59 ` Mat Martineau
2021-06-30 8:29 ` Y.b. Lu
2021-06-25 9:35 ` [net-next, v4, 09/11] net: socket: support hardware timestamp conversion to PHC bound Yangbo Lu
2021-06-25 9:35 ` [net-next, v4, 10/11] selftests/net: timestamping: support binding PHC Yangbo Lu
2021-06-26 0:26 ` kernel test robot
2021-06-26 0:26 ` kernel test robot
2021-06-25 9:35 ` [net-next, v4, 11/11] MAINTAINERS: add entry for PTP virtual clock driver Yangbo Lu
-- strict thread matches above, loose matches on Subject: below --
2021-06-25 16:22 [net-next, v4, 05/11] ethtool: add a new command for getting PHC virtual clocks kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829170415.hztnbqswszx27hvf@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@nxp.com \
--cc=sebastien.laveze@nxp.com \
--cc=shuah@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.