From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B71C4332F for ; Mon, 27 Dec 2021 15:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239343AbhL0Pns (ORCPT ); Mon, 27 Dec 2021 10:43:48 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:40076 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbhL0Pkn (ORCPT ); Mon, 27 Dec 2021 10:40:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4CD161047; Mon, 27 Dec 2021 15:40:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5EC5C36AEA; Mon, 27 Dec 2021 15:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640619642; bh=H0HHYpbenK6uheiZGZ04BgxBP4iVEriNtRL4NINrOvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V6DPLBUJjnSDvqNUpVDEPNSXXyinGeWQ5rVlyZ/8UTQ8VuEb67q6Sc42f9lj6eN9z hC8OBBlzvzfT/PAisFgs3aUrAQS/+GPUKYz/CIoKL3gV8ZhxP1X1ER1meznpr/xSb+ e70aSDog+nMyvinCB3G9G7Kt95oXuP2iofBQPtFQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiasheng Jiang , Benjamin Tissoires Subject: [PATCH 5.15 008/128] HID: potential dereference of null pointer Date: Mon, 27 Dec 2021 16:29:43 +0100 Message-Id: <20211227151331.778935576@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211227151331.502501367@linuxfoundation.org> References: <20211227151331.502501367@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiasheng Jiang commit 13251ce1dd9bb525da2becb9b26fdfb94ca58659 upstream. The return value of devm_kzalloc() needs to be checked. To avoid hdev->dev->driver_data to be null in case of the failure of alloc. Fixes: 14c9c014babe ("HID: add vivaldi HID driver") Cc: stable@vger.kernel.org Signed-off-by: Jiasheng Jiang Signed-off-by: Benjamin Tissoires Link: https://lore.kernel.org/r/20211215083605.117638-1-jiasheng@iscas.ac.cn Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-vivaldi.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hid/hid-vivaldi.c +++ b/drivers/hid/hid-vivaldi.c @@ -57,6 +57,9 @@ static int vivaldi_probe(struct hid_devi int ret; drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL); + if (!drvdata) + return -ENOMEM; + hid_set_drvdata(hdev, drvdata); ret = hid_parse(hdev);