From: Dipen Patel <dipenp@nvidia.com>
To: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linus.walleij@linaro.org>,
<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<robh+dt@kernel.org>, <timestamp@lists.linux.dev>,
<krzysztof.kozlowski+dt@linaro.org>, <brgl@bgdev.pl>,
<corbet@lwn.net>, <gregkh@linuxfoundation.org>
Cc: Dipen Patel <dipenp@nvidia.com>
Subject: [PATCH V3 2/6] dt-bindings: timestamp: Add Tegra234 support
Date: Fri, 10 Mar 2023 11:06:30 -0800 [thread overview]
Message-ID: <20230310190634.5053-3-dipenp@nvidia.com> (raw)
In-Reply-To: <20230310190634.5053-1-dipenp@nvidia.com>
Added timestamp provider support for the Tegra234 in devicetree
bindings. In addition, it addresses review comments from the
previous review round as follows:
- Removes nvidia,slices property. This was not necessary as it
is a constant value and can be hardcoded inside the driver code.
- Adds nvidia,gpio-controller property. This simplifies how GTE driver
retrieves GPIO controller instance, see below explanation.
Without this property code would look like:
if (of_device_is_compatible(dev->of_node, "nvidia,tegra194-gte-aon"))
hte_dev->c = gpiochip_find("tegra194-gpio-aon",
tegra_get_gpiochip_from_name);
else if (of_device_is_compatible(dev->of_node, "nvidia,tegra234-gte-aon"))
hte_dev->c = gpiochip_find("tegra234-gpio-aon",
tegra_get_gpiochip_from_name);
else
return -ENODEV;
This means for every future addition of the compatible string, if else
condition statements have to be expanded.
With the property:
gpio_ctrl = of_parse_phandle(dev->of_node, "nvidia,gpio-controller", 0);
....
hte_dev->c = gpiochip_find(gpio_ctrl, tegra_get_gpiochip_from_of_node);
We haven't technically started making use of these bindings, so
backwards-compatibility shouldn't be an issue yet.
Signed-off-by: Dipen Patel <dipenp@nvidia.com>
---
v2:
- Removed nvidia,slices property
- Added nvidia,gpio-controller based on review comments from Thierry,
this will help simplify the hte provider driver.
v3:
- Explained changes in detail in commit message
- Added allOf section per review comment
.../timestamp/nvidia,tegra194-hte.yaml | 31 ++++++++++++-------
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
index c31e207d1652..eb904ac2f331 100644
--- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
+++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Tegra194 on chip generic hardware timestamping engine (HTE)
+title: Tegra on chip generic hardware timestamping engine (HTE) provider
maintainers:
- Dipen Patel <dipenp@nvidia.com>
@@ -23,6 +23,8 @@ properties:
enum:
- nvidia,tegra194-gte-aon
- nvidia,tegra194-gte-lic
+ - nvidia,tegra234-gte-aon
+ - nvidia,tegra234-gte-lic
reg:
maxItems: 1
@@ -38,14 +40,11 @@ properties:
minimum: 1
maximum: 256
- nvidia,slices:
- $ref: /schemas/types.yaml#/definitions/uint32
+ nvidia,gpio-controller:
+ $ref: /schemas/types.yaml#/definitions/phandle
description:
- HTE lines are arranged in 32 bit slice where each bit represents different
- line/signal that it can enable/configure for the timestamp. It is u32
- property and depends on the HTE instance in the chip. The value 3 is for
- GPIO GTE and 11 for IRQ GTE.
- enum: [3, 11]
+ The phandle to AON gpio controller instance. This is required to handle
+ namespace conversion between GPIO and GTE.
'#timestamp-cells':
description:
@@ -59,9 +58,20 @@ required:
- compatible
- reg
- interrupts
- - nvidia,slices
- "#timestamp-cells"
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nvidia,tegra194-gte-aon
+ - nvidia,tegra234-gte-aon
+ then:
+ required:
+ - nvidia,gpio-controller
+
additionalProperties: false
examples:
@@ -71,7 +81,7 @@ examples:
reg = <0xc1e0000 0x10000>;
interrupts = <0 13 0x4>;
nvidia,int-threshold = <1>;
- nvidia,slices = <3>;
+ nvidia,gpio-controller = <&gpio_aon>;
#timestamp-cells = <1>;
};
@@ -81,7 +91,6 @@ examples:
reg = <0x3aa0000 0x10000>;
interrupts = <0 11 0x4>;
nvidia,int-threshold = <1>;
- nvidia,slices = <11>;
#timestamp-cells = <1>;
};
--
2.17.1
next prev parent reply other threads:[~2023-03-10 19:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 19:06 [PATCH V3 0/6] Add Tegra234 HTE support Dipen Patel
2023-03-10 19:06 ` [PATCH V3 1/6] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-03-10 19:06 ` Dipen Patel [this message]
2023-03-12 15:47 ` [PATCH V3 2/6] dt-bindings: timestamp: Add Tegra234 support Krzysztof Kozlowski
2023-03-13 17:05 ` Dipen Patel
2023-03-13 17:55 ` Krzysztof Kozlowski
2023-03-13 21:49 ` Dipen Patel
2023-03-14 8:43 ` Krzysztof Kozlowski
2023-03-13 21:57 ` Linus Walleij
2023-03-13 23:49 ` Dipen Patel
2023-03-14 0:01 ` Dipen Patel
2023-03-14 8:35 ` Linus Walleij
2023-03-14 11:46 ` Jon Hunter
2023-03-10 19:06 ` [PATCH V3 3/6] hte: Re-phrase tegra API document Dipen Patel
2023-03-10 19:06 ` [PATCH V3 4/6] hte: Add Tegra234 provider Dipen Patel
2023-03-12 15:49 ` Krzysztof Kozlowski
2023-03-14 12:17 ` Jon Hunter
2023-03-10 19:06 ` [PATCH V3 5/6] gpio: tegra186: Add Tegra234 hte support Dipen Patel
2023-03-15 12:15 ` Bartosz Golaszewski
2023-03-10 19:06 ` [PATCH V3 6/6] arm64: tegra: Add GTE nodes Dipen Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310190634.5053-3-dipenp@nvidia.com \
--to=dipenp@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.