From: Rob Herring <robh@kernel.org>
To: Dipen Patel <dipenp@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
timestamp@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org,
brgl@bgdev.pl, corbet@lwn.net, gregkh@linuxfoundation.org
Subject: Re: [V5 04/10] dt-bindings: timestamp: Add nvidia,gpio-controller
Date: Wed, 12 Apr 2023 09:29:03 -0500 [thread overview]
Message-ID: <20230412142903.GA2313008-robh@kernel.org> (raw)
In-Reply-To: <20230406171837.11206-5-dipenp@nvidia.com>
On Thu, Apr 06, 2023 at 10:18:31AM -0700, Dipen Patel wrote:
> The tegra always-on (AON) GPIO HTE/GTE provider depends on the AON
> GPIO controller where it needs to do namespace conversion between GPIO
> line number (belonging to AON GPIO controller instance) and the GTE
> slice bits. The patch introduces nvidia,gpio-controller property to
> represent that dependency.
>
> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../timestamp/nvidia,tegra194-hte.yaml | 36 ++++++++++++++++---
> 1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> index 855dad3f2023..66eaa3fab8cc 100644
> --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> @@ -51,6 +51,12 @@ properties:
> LIC instance has 11 slices and Tegra234 LIC has 17 slices.
> enum: [3, 11, 17]
>
> + nvidia,gpio-controller:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle to AON gpio controller instance. This is required to handle
> + namespace conversion between GPIO and GTE.
> +
> '#timestamp-cells':
> description:
> This represents number of line id arguments as specified by the
> @@ -59,6 +65,12 @@ properties:
> mentioned in the nvidia GPIO device tree binding document.
> const: 1
>
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#timestamp-cells"
> +
> allOf:
> - if:
> properties:
> @@ -94,11 +106,15 @@ allOf:
> nvidia,slices:
> const: 17
>
> -required:
> - - compatible
> - - reg
> - - interrupts
> - - "#timestamp-cells"
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nvidia,tegra234-gte-aon
> + then:
> + required:
> + - nvidia,gpio-controller
Adding a new required property is an ABI break. But you just added this
in patch 2. If this is required as part of nvidia,tegra234-gte-aon
support, then it should all be 1 patch.
>
> additionalProperties: false
>
> @@ -112,6 +128,16 @@ examples:
> #timestamp-cells = <1>;
> };
>
> + - |
> + tegra234_hte_aon: timestamp@c1e0000 {
> + compatible = "nvidia,tegra234-gte-aon";
> + reg = <0xc1e0000 0x10000>;
> + interrupts = <0 13 0x4>;
> + nvidia,int-threshold = <1>;
> + nvidia,gpio-controller = <&gpio_aon>;
> + #timestamp-cells = <1>;
> + };
> +
Really need a whole other example for 1 property?
> - |
> tegra_hte_lic: timestamp@3aa0000 {
> compatible = "nvidia,tegra194-gte-lic";
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-04-12 14:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 17:18 [V5 00/10] Add Tegra234 HTE support Dipen Patel
2023-04-06 17:18 ` [V5 01/10] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-04-06 17:18 ` [V5 02/10] dt-bindings: timestamp: Add Tegra234 support Dipen Patel
2023-04-06 17:18 ` [V5 03/10] dt-bindings: timestamp: Deprecate nvidia,slices property Dipen Patel
2023-04-12 14:24 ` Rob Herring
2023-04-06 17:18 ` [V5 04/10] dt-bindings: timestamp: Add nvidia,gpio-controller Dipen Patel
2023-04-12 14:29 ` Rob Herring [this message]
2023-04-12 17:10 ` Dipen Patel
2023-04-06 17:18 ` [V5 05/10] arm64: tegra: Add Tegra234 GTE nodes Dipen Patel
2023-04-06 17:18 ` [V5 06/10] hte: Re-phrase tegra API document Dipen Patel
2023-04-06 17:18 ` [V5 07/10] hte: Add Tegra234 provider Dipen Patel
2023-04-06 17:18 ` [V5 08/10] hte: Deprecate nvidia,slices property Dipen Patel
2023-04-06 17:18 ` [V5 09/10] hte: handle nvidia,gpio-controller property Dipen Patel
2023-04-06 17:18 ` [V5 10/10] gpio: tegra186: Add Tegra234 hte support Dipen Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412142903.GA2313008-robh@kernel.org \
--to=robh@kernel.org \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.