From: Dipen Patel <dipenp@nvidia.com>
To: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linus.walleij@linaro.org>,
<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<robh+dt@kernel.org>, <timestamp@lists.linux.dev>,
<krzysztof.kozlowski+dt@linaro.org>, <brgl@bgdev.pl>,
<corbet@lwn.net>, <gregkh@linuxfoundation.org>
Cc: Dipen Patel <dipenp@nvidia.com>
Subject: [V6 2/9] dt-bindings: timestamp: Add Tegra234 support
Date: Thu, 13 Apr 2023 17:44:48 -0700 [thread overview]
Message-ID: <20230414004455.19275-3-dipenp@nvidia.com> (raw)
In-Reply-To: <20230414004455.19275-1-dipenp@nvidia.com>
Added timestamp provider support for the Tegra234 in devicetree
bindings. From Tegra234 SoC onwards, the nvidia,gpio-controller
property is required. This is needed as the tegra always-on (AON) GPIO
HTE/GTE provider depends on the AON GPIO controller where it needs to
do namespace conversion between GPIO line number (belonging to AON
GPIO controller instance) and the GTE slice bits.
Signed-off-by: Dipen Patel <dipenp@nvidia.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
v2:
- Removed nvidia,slices property
- Added nvidia,gpio-controller based on review comments from Thierry,
this will help simplify the hte provider driver.
v3:
- Explained changes in detail in commit message
- Added allOf section per review comment
v4:
- Logically divide the v3 patch as follows
- Created Tegra234 support patch
- Created depracate nvidia,slices property patch
- Created addition of the nvidia,gpio-controller property patch
v6:
- Merges the patch 3 from v5 into this patch
.../timestamp/nvidia,tegra194-hte.yaml | 60 +++++++++++++++++--
1 file changed, 56 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
index c31e207d1652..5de1eca9cbcd 100644
--- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
+++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Tegra194 on chip generic hardware timestamping engine (HTE)
+title: Tegra on chip generic hardware timestamping engine (HTE) provider
maintainers:
- Dipen Patel <dipenp@nvidia.com>
@@ -23,6 +23,8 @@ properties:
enum:
- nvidia,tegra194-gte-aon
- nvidia,tegra194-gte-lic
+ - nvidia,tegra234-gte-aon
+ - nvidia,tegra234-gte-lic
reg:
maxItems: 1
@@ -43,9 +45,14 @@ properties:
description:
HTE lines are arranged in 32 bit slice where each bit represents different
line/signal that it can enable/configure for the timestamp. It is u32
- property and depends on the HTE instance in the chip. The value 3 is for
- GPIO GTE and 11 for IRQ GTE.
- enum: [3, 11]
+ property and the value depends on the HTE instance in the chip.
+ enum: [3, 11, 17]
+
+ nvidia,gpio-controller:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ The phandle to AON gpio controller instance. This is required to handle
+ namespace conversion between GPIO and GTE.
'#timestamp-cells':
description:
@@ -62,6 +69,51 @@ required:
- nvidia,slices
- "#timestamp-cells"
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nvidia,tegra194-gte-aon
+ - nvidia,tegra234-gte-aon
+ then:
+ properties:
+ nvidia,slices:
+ const: 3
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nvidia,tegra194-gte-lic
+ then:
+ properties:
+ nvidia,slices:
+ const: 11
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nvidia,tegra234-gte-lic
+ then:
+ properties:
+ nvidia,slices:
+ const: 17
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nvidia,tegra234-gte-aon
+ then:
+ required:
+ - nvidia,gpio-controller
+
additionalProperties: false
examples:
--
2.17.1
next prev parent reply other threads:[~2023-04-14 0:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 0:44 [V6 0/9] Add Tegra234 HTE support Dipen Patel
2023-04-14 0:44 ` [V6 1/9] MAINTAINERS: Add HTE/timestamp subsystem details Dipen Patel
2023-04-14 0:44 ` Dipen Patel [this message]
2023-04-14 0:44 ` [V6 3/9] dt-bindings: timestamp: Deprecate nvidia,slices property Dipen Patel
2023-04-14 0:44 ` [V6 4/9] arm64: tegra: Add Tegra234 GTE nodes Dipen Patel
2023-04-20 16:05 ` Thierry Reding
2023-04-14 0:44 ` [V6 5/9] hte: Re-phrase tegra API document Dipen Patel
2023-04-14 0:44 ` [V6 6/9] hte: Add Tegra234 provider Dipen Patel
2023-04-14 0:44 ` [V6 7/9] hte: Deprecate nvidia,slices property Dipen Patel
2023-04-14 0:44 ` [V6 8/9] hte: handle nvidia,gpio-controller property Dipen Patel
2023-04-14 0:44 ` [V6 9/9] gpio: tegra186: Add Tegra234 hte support Dipen Patel
2023-04-14 7:36 ` [V6 0/9] Add Tegra234 HTE support Krzysztof Kozlowski
2023-04-14 8:07 ` Linus Walleij
2023-04-14 17:15 ` Dipen Patel
2023-04-14 10:43 ` Thierry Reding
2023-04-14 17:14 ` Dipen Patel
2023-04-14 20:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414004455.19275-3-dipenp@nvidia.com \
--to=dipenp@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.