All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libevent and libsqlite3 checked when nfsv4 is disabled
@ 2023-05-10 11:56 Wiktor Jaskulski
  2023-05-11 19:39 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Wiktor Jaskulski @ 2023-05-10 11:56 UTC (permalink / raw
  To: linux-nfs; +Cc: wjaskulski

From: wjaskulski <wjaskulski@adva.com>

Even if nfsv4 is disabled component fsidd has libevent and libsqlite3 as dependencies.

Problems with compilation and error logs can be found at:
https://github.com/gentoo/gentoo/pull/30789
https://bugs.gentoo.org/904718

Signed-off-by: Wiktor Jaskulski <wjaskulski@adva.com>
---
 configure.ac | 38 +++++++++++++++-----------------------
 1 file changed, 15 insertions(+), 23 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4ade528d..519cacbf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -335,42 +335,34 @@ AC_CHECK_HEADER(rpc/rpc.h, ,
                 AC_MSG_ERROR([Header file rpc/rpc.h not found - maybe try building with --enable-tirpc]))
 CPPFLAGS="${nfsutils_save_CPPFLAGS}"
 
+dnl check for libevent libraries and headers
+AC_LIBEVENT
+
+dnl Check for sqlite3
+AC_SQLITE3_VERS
+
+case $libsqlite3_cv_is_recent in
+yes) ;;
+unknown)
+   dnl do not fail when cross-compiling
+   AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
+*)
+   AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
+esac
+
 if test "$enable_nfsv4" = yes; then
-  dnl check for libevent libraries and headers
-  AC_LIBEVENT
 
   dnl check for the keyutils libraries and headers
   AC_KEYUTILS
 
-  dnl Check for sqlite3
-  AC_SQLITE3_VERS
-
   if test "$enable_nfsdcld" = "yes"; then
 	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
 		AC_MSG_ERROR([Cannot find header needed for nfsdcld]))
-
-    case $libsqlite3_cv_is_recent in
-    yes) ;;
-    unknown)
-      dnl do not fail when cross-compiling
-      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
-    *)
-      AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
-    esac
   fi
 
   if test "$enable_nfsdcltrack" = "yes"; then
 	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
 		AC_MSG_ERROR([Cannot find header needed for nfsdcltrack]))
-
-    case $libsqlite3_cv_is_recent in
-    yes) ;;
-    unknown)
-      dnl do not fail when cross-compiling
-      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
-    *)
-      AC_MSG_ERROR([nfsdcltrack requires sqlite-devel]) ;;
-    esac
   fi
 
 else
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libevent and libsqlite3 checked when nfsv4 is disabled
  2023-05-10 11:56 [PATCH] libevent and libsqlite3 checked when nfsv4 is disabled Wiktor Jaskulski
@ 2023-05-11 19:39 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2023-05-11 19:39 UTC (permalink / raw
  To: Wiktor Jaskulski, linux-nfs; +Cc: wjaskulski



On 5/10/23 7:56 AM, Wiktor Jaskulski wrote:
> From: wjaskulski <wjaskulski@adva.com>
> 
> Even if nfsv4 is disabled component fsidd has libevent and libsqlite3 as dependencies.
> 
> Problems with compilation and error logs can be found at:
> https://github.com/gentoo/gentoo/pull/30789
> https://bugs.gentoo.org/904718
> 
> Signed-off-by: Wiktor Jaskulski <wjaskulski@adva.com>
Committed... (tag: nfs-utils-2-6-4-rc1)

steved
> ---
>   configure.ac | 38 +++++++++++++++-----------------------
>   1 file changed, 15 insertions(+), 23 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4ade528d..519cacbf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -335,42 +335,34 @@ AC_CHECK_HEADER(rpc/rpc.h, ,
>                   AC_MSG_ERROR([Header file rpc/rpc.h not found - maybe try building with --enable-tirpc]))
>   CPPFLAGS="${nfsutils_save_CPPFLAGS}"
>   
> +dnl check for libevent libraries and headers
> +AC_LIBEVENT
> +
> +dnl Check for sqlite3
> +AC_SQLITE3_VERS
> +
> +case $libsqlite3_cv_is_recent in
> +yes) ;;
> +unknown)
> +   dnl do not fail when cross-compiling
> +   AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> +*)
> +   AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> +esac
> +
>   if test "$enable_nfsv4" = yes; then
> -  dnl check for libevent libraries and headers
> -  AC_LIBEVENT
>   
>     dnl check for the keyutils libraries and headers
>     AC_KEYUTILS
>   
> -  dnl Check for sqlite3
> -  AC_SQLITE3_VERS
> -
>     if test "$enable_nfsdcld" = "yes"; then
>   	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
>   		AC_MSG_ERROR([Cannot find header needed for nfsdcld]))
> -
> -    case $libsqlite3_cv_is_recent in
> -    yes) ;;
> -    unknown)
> -      dnl do not fail when cross-compiling
> -      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> -    *)
> -      AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> -    esac
>     fi
>   
>     if test "$enable_nfsdcltrack" = "yes"; then
>   	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
>   		AC_MSG_ERROR([Cannot find header needed for nfsdcltrack]))
> -
> -    case $libsqlite3_cv_is_recent in
> -    yes) ;;
> -    unknown)
> -      dnl do not fail when cross-compiling
> -      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> -    *)
> -      AC_MSG_ERROR([nfsdcltrack requires sqlite-devel]) ;;
> -    esac
>     fi
>   
>   else


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-11 19:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-10 11:56 [PATCH] libevent and libsqlite3 checked when nfsv4 is disabled Wiktor Jaskulski
2023-05-11 19:39 ` Steve Dickson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.