From: Stephen Hemminger <stephen@networkplumber.org>
To: <pbhagavatula@marvell.com>
Cc: <david.marchand@redhat.com>, <dev@dpdk.org>, <stable@dpdk.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: fix side effects in align mul macros
Date: Tue, 4 Jul 2023 09:01:26 -0700 [thread overview]
Message-ID: <20230704090126.236ee995@hermes.local> (raw)
In-Reply-To: <20210510194008.403-1-pbhagavatula@marvell.com>
On Tue, 11 May 2021 01:10:06 +0530
<pbhagavatula@marvell.com> wrote:
> Avoid expanding parameters inside the macro multiple times.
> For example:
> RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);
> Here rte_rdtsc() call is expanded multiple times in the macro
> causing it to return different values that leads to unintended
> side effects.
This was already fixed.
prev parent reply other threads:[~2023-07-04 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 17:18 [dpdk-dev] [PATCH 1/2] eal: fix side effects in align mul macros pbhagavatula
2021-05-09 17:18 ` [dpdk-dev] [PATCH 2/2] eal: fix side effects in ptr align macros pbhagavatula
2021-05-09 19:39 ` Stephen Hemminger
2021-05-10 9:50 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-05-10 13:34 ` David Marchand
2021-05-10 14:02 ` [dpdk-dev] [PATCH v2 1/2] eal: fix side effects in align mul macros pbhagavatula
2021-05-10 14:02 ` [dpdk-dev] [PATCH v2 2/2] eal: fix side effects in ptr align macros pbhagavatula
2021-05-10 19:40 ` [dpdk-dev] [PATCH v3 1/2] eal: fix side effects in align mul macros pbhagavatula
2021-05-10 19:40 ` [dpdk-dev] [PATCH v3 2/2] eal: fix side effects in ptr align macros pbhagavatula
2021-05-11 2:12 ` Wang, Haiyue
2021-05-11 8:44 ` Pavan Nikhilesh Bhagavatula
2021-05-12 1:13 ` Wang, Haiyue
2023-07-03 18:55 ` [PATCH] eal: avoid issues in macro expansion of alignment Stephen Hemminger
2023-07-03 23:23 ` [PATCH v2] " Stephen Hemminger
2023-07-04 8:43 ` Morten Brørup
2023-07-04 16:00 ` Stephen Hemminger
2023-07-04 22:16 ` Morten Brørup
2023-07-14 16:37 ` Stephen Hemminger
2023-07-04 16:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704090126.236ee995@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@marvell.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.