From: Daniel Kiper <dkiper@net-space.pl>
To: Patrick Plenefisch <simonpatp@gmail.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG
Date: Thu, 8 Feb 2024 21:05:55 +0100 [thread overview]
Message-ID: <20240208200555.cjzwq2fgg4xkkaws@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAOCpoWdDozmaN5dzOrj+4-6-O-R0m5299cOUupg3jmnH7Lr56w@mail.gmail.com>
On Thu, Feb 08, 2024 at 02:52:37PM -0500, Patrick Plenefisch wrote:
> Hmm, what would the logical parts be? The solution for both cachevol and
> integrity is the same.
It seems to me at least code refactoring which you are doing could be
taken out to a separate patch. Maybe something else... Anyway, in general
smaller patches ease reviewing...
> I do know another part needs to be added as I still need to investigate some
> warnings, but I'll likely need to do that this weekend when I have some more
> time.
Cool! Thanks!
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2024-02-08 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 21:37 [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG Patrick Plenefisch
2024-02-08 16:57 ` Daniel Kiper
2024-02-08 19:52 ` Patrick Plenefisch
2024-02-08 20:05 ` Daniel Kiper [this message]
2024-02-19 2:00 ` Patrick Plenefisch
2024-04-26 23:10 ` Glenn Washburn
2024-04-26 23:13 ` Glenn Washburn
2024-04-27 1:02 ` Patrick Plenefisch
2024-04-27 9:25 ` Glenn Washburn
2024-04-27 19:26 ` Patrick Plenefisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208200555.cjzwq2fgg4xkkaws@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=simonpatp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.