From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A341DFF4; Mon, 1 Apr 2024 17:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711991129; cv=none; b=SdAj6HgAdiAFVQ3Pgj6iwUJXdr/3eomnTreB3xrwBJC0fxvj/yUvra/M+Zzwrow7plHl2oB/OTZ6ISmkvx9x2caJRXNDXVC2eERjunelBkYfGZso2P3zvJUfYuJOEV3WQ1FrTI/X/1y7qVyhFtatrfiCakGfH6y2/Qsxdds3g+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711991129; c=relaxed/simple; bh=sSjj58zK0Koh4XShh8WsbKn0Jdz9kTOLEXhUZ9Vj7rI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QDYVSrU6Y26UyRApTK00SyfwxK5VP4zWJkTESv2FgBXzIDGj0DPAFx8xDijdSuza6Lo8L9UA2gU9XEKccrDKnV4FHMULC8yQSgAClaxyn/yEqwdkzdn6jh0gEimBVq24wQAlwF4SXfe2Fo9t3dJB4H6RPlx/6OXDnkB1t8oSWH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RR01aodm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RR01aodm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD61C433F1; Mon, 1 Apr 2024 17:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711991129; bh=sSjj58zK0Koh4XShh8WsbKn0Jdz9kTOLEXhUZ9Vj7rI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RR01aodmfmEhumxOIM3JHrrGDJKT3BR8M+c5xAKFyAGhY0SH4XpaJXlqjlHB3FAFe M9GnaRdJkKpJaYaE0vmBavY/J+zDmGpwpdFNVzYrV4fi/xoNKXPxdHSbO5NPs4hlj2 H2CbNllKy0RfRc4zDgwY+bg/QzBdeXbhAueyOM40= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cosmin Tanislav , Nuno Sa , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 6.1 171/272] iio: accel: adxl367: fix DEVID read after reset Date: Mon, 1 Apr 2024 17:46:01 +0200 Message-ID: <20240401152536.100188534@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240401152530.237785232@linuxfoundation.org> References: <20240401152530.237785232@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cosmin Tanislav commit 1b926914bbe4e30cb32f268893ef7d82a85275b8 upstream. regmap_read_poll_timeout() will not sleep before reading, causing the first read to return -ENXIO on I2C, since the chip does not respond to it while it is being reset. The datasheet specifies that a soft reset operation has a latency of 7.5ms. Add a 15ms sleep between reset and reading the DEVID register, and switch to a simple regmap_read() call. Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver") Signed-off-by: Cosmin Tanislav Reviewed-by: Nuno Sa Link: https://lore.kernel.org/r/20240207033657.206171-1-demonsingur@gmail.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/accel/adxl367.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -1444,9 +1444,11 @@ static int adxl367_verify_devid(struct a unsigned int val; int ret; - ret = regmap_read_poll_timeout(st->regmap, ADXL367_REG_DEVID, val, - val == ADXL367_DEVID_AD, 1000, 10000); + ret = regmap_read(st->regmap, ADXL367_REG_DEVID, &val); if (ret) + return dev_err_probe(st->dev, ret, "Failed to read dev id\n"); + + if (val != ADXL367_DEVID_AD) return dev_err_probe(st->dev, -ENODEV, "Invalid dev id 0x%02X, expected 0x%02X\n", val, ADXL367_DEVID_AD); @@ -1543,6 +1545,8 @@ int adxl367_probe(struct device *dev, co if (ret) return ret; + fsleep(15000); + ret = adxl367_verify_devid(st); if (ret) return ret;