From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v5 02/10] PCI: Deprecate iomap-table functions
Date: Thu, 4 Apr 2024 09:38:54 +0800 [thread overview]
Message-ID: <202404040920.QIxhNeMu-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240403080712.13986-5-pstanner@redhat.com>
References: <20240403080712.13986-5-pstanner@redhat.com>
TO: Philipp Stanner <pstanner@redhat.com>
TO: Hans de Goede <hdegoede@redhat.com>
TO: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
TO: Maxime Ripard <mripard@kernel.org>
TO: Thomas Zimmermann <tzimmermann@suse.de>
TO: David Airlie <airlied@gmail.com>
TO: Daniel Vetter <daniel@ffwll.ch>
TO: Bjorn Helgaas <helgaas@kernel.org>
TO: Sam Ravnborg <sam@ravnborg.org>
TO: dakr@redhat.com
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
CC: linux-pci@vger.kernel.org
CC: Philipp Stanner <pstanner@redhat.com>
Hi Philipp,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus drm-misc/drm-misc-next linus/master v6.9-rc2 next-20240403]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/PCI-Add-new-set-of-devres-functions/20240403-160932
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240403080712.13986-5-pstanner%40redhat.com
patch subject: [PATCH v5 02/10] PCI: Deprecate iomap-table functions
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
config: i386-randconfig-141-20240404 (https://download.01.org/0day-ci/archive/20240404/202404040920.QIxhNeMu-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404040920.QIxhNeMu-lkp@intel.com/
smatch warnings:
drivers/pci/devres.c:897 pcim_iomap_regions_request_all() error: we previously assumed 'legacy_iomap_table' could be null (see line 894)
vim +/legacy_iomap_table +897 drivers/pci/devres.c
acc2364fe66106 Philipp Stanner 2024-01-31 848
acc2364fe66106 Philipp Stanner 2024-01-31 849 /**
34e90b966504f3 Philipp Stanner 2024-04-03 850 * pcim_iomap_regions_request_all - Request all BARs and iomap specified ones (DEPRECATED)
acc2364fe66106 Philipp Stanner 2024-01-31 851 * @pdev: PCI device to map IO resources for
acc2364fe66106 Philipp Stanner 2024-01-31 852 * @mask: Mask of BARs to iomap
4a97db2d40b2a0 Philipp Stanner 2024-04-03 853 * @name: Name associated with the requests
acc2364fe66106 Philipp Stanner 2024-01-31 854 *
34e90b966504f3 Philipp Stanner 2024-04-03 855 * Returns: 0 on success, negative error code on failure.
34e90b966504f3 Philipp Stanner 2024-04-03 856 *
acc2364fe66106 Philipp Stanner 2024-01-31 857 * Request all PCI BARs and iomap regions specified by @mask.
34e90b966504f3 Philipp Stanner 2024-04-03 858 *
34e90b966504f3 Philipp Stanner 2024-04-03 859 * To release these resources manually, call pcim_release_region() for the
34e90b966504f3 Philipp Stanner 2024-04-03 860 * regions and pcim_iounmap() for the mappings.
34e90b966504f3 Philipp Stanner 2024-04-03 861 *
34e90b966504f3 Philipp Stanner 2024-04-03 862 * This function is DEPRECATED. Don't use it in new code.
34e90b966504f3 Philipp Stanner 2024-04-03 863 * Use pcim_request_all_regions() + pcim_iomap*() instead.
acc2364fe66106 Philipp Stanner 2024-01-31 864 */
acc2364fe66106 Philipp Stanner 2024-01-31 865 int pcim_iomap_regions_request_all(struct pci_dev *pdev, int mask,
acc2364fe66106 Philipp Stanner 2024-01-31 866 const char *name)
acc2364fe66106 Philipp Stanner 2024-01-31 867 {
34e90b966504f3 Philipp Stanner 2024-04-03 868 short bar;
34e90b966504f3 Philipp Stanner 2024-04-03 869 int ret;
34e90b966504f3 Philipp Stanner 2024-04-03 870 void __iomem **legacy_iomap_table;
acc2364fe66106 Philipp Stanner 2024-01-31 871
34e90b966504f3 Philipp Stanner 2024-04-03 872 ret = pcim_request_all_regions(pdev, name);
34e90b966504f3 Philipp Stanner 2024-04-03 873 if (ret != 0)
34e90b966504f3 Philipp Stanner 2024-04-03 874 return ret;
acc2364fe66106 Philipp Stanner 2024-01-31 875
34e90b966504f3 Philipp Stanner 2024-04-03 876 for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
34e90b966504f3 Philipp Stanner 2024-04-03 877 if (!mask_contains_bar(mask, bar))
34e90b966504f3 Philipp Stanner 2024-04-03 878 continue;
34e90b966504f3 Philipp Stanner 2024-04-03 879 if (!pcim_iomap(pdev, bar, 0))
34e90b966504f3 Philipp Stanner 2024-04-03 880 goto err;
34e90b966504f3 Philipp Stanner 2024-04-03 881 }
34e90b966504f3 Philipp Stanner 2024-04-03 882
34e90b966504f3 Philipp Stanner 2024-04-03 883 return 0;
34e90b966504f3 Philipp Stanner 2024-04-03 884
34e90b966504f3 Philipp Stanner 2024-04-03 885 err:
34e90b966504f3 Philipp Stanner 2024-04-03 886 /*
34e90b966504f3 Philipp Stanner 2024-04-03 887 * Here it gets tricky: pcim_iomap() above has most likely
34e90b966504f3 Philipp Stanner 2024-04-03 888 * failed because it got an OOM when trying to create the
34e90b966504f3 Philipp Stanner 2024-04-03 889 * legacy-table.
34e90b966504f3 Philipp Stanner 2024-04-03 890 * We check here if that has happened. If not, pcim_iomap()
34e90b966504f3 Philipp Stanner 2024-04-03 891 * must have failed because of EINVAL.
34e90b966504f3 Philipp Stanner 2024-04-03 892 */
34e90b966504f3 Philipp Stanner 2024-04-03 893 legacy_iomap_table = (void __iomem **)pcim_iomap_table(pdev);
34e90b966504f3 Philipp Stanner 2024-04-03 @894 ret = legacy_iomap_table ? -EINVAL : -ENOMEM;
34e90b966504f3 Philipp Stanner 2024-04-03 895
34e90b966504f3 Philipp Stanner 2024-04-03 896 while (--bar >= 0)
34e90b966504f3 Philipp Stanner 2024-04-03 @897 pcim_iounmap(pdev, legacy_iomap_table[bar]);
34e90b966504f3 Philipp Stanner 2024-04-03 898
34e90b966504f3 Philipp Stanner 2024-04-03 899 pcim_release_all_regions(pdev);
34e90b966504f3 Philipp Stanner 2024-04-03 900
34e90b966504f3 Philipp Stanner 2024-04-03 901 return ret;
acc2364fe66106 Philipp Stanner 2024-01-31 902 }
acc2364fe66106 Philipp Stanner 2024-01-31 903 EXPORT_SYMBOL(pcim_iomap_regions_request_all);
acc2364fe66106 Philipp Stanner 2024-01-31 904
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-04-04 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 1:38 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-03 8:07 [PATCH v5 00/10] Make PCI's devres API more consistent Philipp Stanner
2024-04-03 8:07 ` [PATCH v5 02/10] PCI: Deprecate iomap-table functions Philipp Stanner
2024-04-04 6:29 ` Dan Carpenter
2024-04-04 7:15 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404040920.QIxhNeMu-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.