From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C1F0C144D1A for ; Fri, 5 Apr 2024 08:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712304045; cv=none; b=aPpn7wxPbSajcQpPE0ivX9f9DODbzO0grd1TVirHZt4d59iLnb2JTjy1jJZoNRmP9UPi+63q8dVidaTH2A5IwNqC1Iiur483oQO99vSPLIVdIwNomDtg3VpdEobL3yfw/AfdbeJS1c+YP5hWDpPqdWgBSxlz1B4f+rcVT1K9W0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712304045; c=relaxed/simple; bh=oZuhb1s6XFcdK4qhiPqywi4shXCxzFqbwESan+8EU2U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Wc4iQla1PQONISg955W3ZRMMQNBWcRm0kfgeZWGFMKlb2+bDIokNJ7Z+hKyw73uVU0kJPBzpMtAtv0AnWTxxK6uS6nxx2wH1almDFP6mVTmgk1FRaq42c1u6q0Szld+phDgywd64i2ic80RSaux8joIG/dDTNZZAOcX8eAKf2uA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E87611007; Fri, 5 Apr 2024 01:01:13 -0700 (PDT) Received: from a077893.blr.arm.com (a077893.blr.arm.com [10.162.41.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 076453F64C; Fri, 5 Apr 2024 01:00:38 -0700 (PDT) From: Anshuman Khandual To: linux-arm-kernel@lists.infradead.org Cc: Anshuman Khandual , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , Mark Rutland , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RFC 5/8] KVM: arm64: Explicitly handle MDSELR_EL1 traps as UNDEFINED Date: Fri, 5 Apr 2024 13:30:05 +0530 Message-Id: <20240405080008.1225223-6-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240405080008.1225223-1-anshuman.khandual@arm.com> References: <20240405080008.1225223-1-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently read_sanitised_id_aa64dfr0_el1() caps the ID_AA64DFR0.DebugVer to ID_AA64DFR0_DebugVer_V8P8, resulting in FEAT_Debugv8p9 not being exposed to the guest. MDSELR_EL1 register access in the guest, is currently trapped by the existing configuration of the fine-grained traps. As the register is not described in sys_reg_descs[] table emulate_sys_reg() will warn that this is unknown access before injecting an UNDEFINED exception into the guest. Any well-behaved guests shouldn't try to use this register, but any badly-behaved guests could, thus resulting in unnecessary warnings. To avoid such warnings, access to MDSELR_EL1 should be explicitly handled as UNDEFINED via updating sys_reg_desc[] as required. Cc: Marc Zyngier Cc: Oliver Upton Cc: James Morse Cc: Suzuki K Poulose Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org Cc: kvmarm@lists.linux.dev Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- arch/arm64/kvm/sys_regs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index c9f4f387155f..2956bdcd358e 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -2203,6 +2203,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { { SYS_DESC(SYS_MDSCR_EL1), trap_debug_regs, reset_val, MDSCR_EL1, 0 }, DBG_BCR_BVR_WCR_WVR_EL1(2), DBG_BCR_BVR_WCR_WVR_EL1(3), + { SYS_DESC(SYS_MDSELR_EL1), undef_access }, DBG_BCR_BVR_WCR_WVR_EL1(4), DBG_BCR_BVR_WCR_WVR_EL1(5), DBG_BCR_BVR_WCR_WVR_EL1(6), -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AEE0C67861 for ; Fri, 5 Apr 2024 08:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KddtOr9j9Sp7ogIlktgk9h+FfTwvVkEBFm9gFdOL5g8=; b=Ez44ZQIVedfxBs AQESdG8CGIIC4J2f1qp6nxy1nEbbeqLq1OAmdxAr9jzkjZMJqgMtSsVMRP9mqkSlmJY2kXthkF7Wp 60SndfbbBvCv7vYVF30nAg+UbU3pCIacsvR5b6/Wz94ZhDeFIsRS1HfU8rZJJyWSHv1Jxt/kDVi3Y 4PV1Ynuyj9A9AkUoTYZhD6zIzT59VxtuLqh9dEy+fdmnE7tsrOeImPklo5yGzoqR0MZYuPQRLnLiu NyisCg7QtLDrQHtPnuKmlAvAyUGf8FlhSJC9h//TbkNSaogQFXsHVt2ueniu9TpVAzxnq8eXENZnb E8hYPHVtEDLGd94owYrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rseVM-00000005pSS-3fkP; Fri, 05 Apr 2024 08:00:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rseVA-00000005pJG-1J4P for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 08:00:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E87611007; Fri, 5 Apr 2024 01:01:13 -0700 (PDT) Received: from a077893.blr.arm.com (a077893.blr.arm.com [10.162.41.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 076453F64C; Fri, 5 Apr 2024 01:00:38 -0700 (PDT) From: Anshuman Khandual To: linux-arm-kernel@lists.infradead.org Cc: Anshuman Khandual , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , Mark Rutland , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RFC 5/8] KVM: arm64: Explicitly handle MDSELR_EL1 traps as UNDEFINED Date: Fri, 5 Apr 2024 13:30:05 +0530 Message-Id: <20240405080008.1225223-6-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240405080008.1225223-1-anshuman.khandual@arm.com> References: <20240405080008.1225223-1-anshuman.khandual@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_010044_902559_BB1023CC X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently read_sanitised_id_aa64dfr0_el1() caps the ID_AA64DFR0.DebugVer to ID_AA64DFR0_DebugVer_V8P8, resulting in FEAT_Debugv8p9 not being exposed to the guest. MDSELR_EL1 register access in the guest, is currently trapped by the existing configuration of the fine-grained traps. As the register is not described in sys_reg_descs[] table emulate_sys_reg() will warn that this is unknown access before injecting an UNDEFINED exception into the guest. Any well-behaved guests shouldn't try to use this register, but any badly-behaved guests could, thus resulting in unnecessary warnings. To avoid such warnings, access to MDSELR_EL1 should be explicitly handled as UNDEFINED via updating sys_reg_desc[] as required. Cc: Marc Zyngier Cc: Oliver Upton Cc: James Morse Cc: Suzuki K Poulose Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org Cc: kvmarm@lists.linux.dev Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- arch/arm64/kvm/sys_regs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index c9f4f387155f..2956bdcd358e 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -2203,6 +2203,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { { SYS_DESC(SYS_MDSCR_EL1), trap_debug_regs, reset_val, MDSCR_EL1, 0 }, DBG_BCR_BVR_WCR_WVR_EL1(2), DBG_BCR_BVR_WCR_WVR_EL1(3), + { SYS_DESC(SYS_MDSELR_EL1), undef_access }, DBG_BCR_BVR_WCR_WVR_EL1(4), DBG_BCR_BVR_WCR_WVR_EL1(5), DBG_BCR_BVR_WCR_WVR_EL1(6), -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel