All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [linux-next:master 4646/5042] fs/exfat/file.c:554 exfat_extend_valid_size() error: uninitialized symbol 'err'.
Date: Wed, 10 Apr 2024 17:52:49 +0800	[thread overview]
Message-ID: <202404101738.kyon9qo2-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Yuezhang Mo <Yuezhang.Mo@sony.com>
CC: Namjae Jeon <linkinjeon@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   6ebf211bb11dfc004a2ff73a9de5386fa309c430
commit: 6397cc21e5c05f35a69e4aca247337a8d97cbbd4 [4646/5042] exfat: move extend valid_size into ->page_mkwrite()
:::::: branch date: 5 hours ago
:::::: commit date: 19 hours ago
config: i386-randconfig-141-20240410 (https://download.01.org/0day-ci/archive/20240410/202404101738.kyon9qo2-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404101738.kyon9qo2-lkp@intel.com/

smatch warnings:
fs/exfat/file.c:554 exfat_extend_valid_size() error: uninitialized symbol 'err'.

vim +/err +554 fs/exfat/file.c

5267456e953fd8 Sungjong Seo 2020-06-18  524  
6397cc21e5c05f Yuezhang Mo  2024-03-08  525  static int exfat_extend_valid_size(struct file *file, loff_t start, loff_t end)
11a347fb6cef62 Yuezhang Mo  2023-03-13  526  {
11a347fb6cef62 Yuezhang Mo  2023-03-13  527  	int err;
11a347fb6cef62 Yuezhang Mo  2023-03-13  528  	struct inode *inode = file_inode(file);
11a347fb6cef62 Yuezhang Mo  2023-03-13  529  	struct address_space *mapping = inode->i_mapping;
11a347fb6cef62 Yuezhang Mo  2023-03-13  530  	const struct address_space_operations *ops = mapping->a_ops;
11a347fb6cef62 Yuezhang Mo  2023-03-13  531  
11a347fb6cef62 Yuezhang Mo  2023-03-13  532  	while (start < end) {
6397cc21e5c05f Yuezhang Mo  2024-03-08  533  		u32 len;
11a347fb6cef62 Yuezhang Mo  2023-03-13  534  		struct page *page = NULL;
11a347fb6cef62 Yuezhang Mo  2023-03-13  535  
6397cc21e5c05f Yuezhang Mo  2024-03-08  536  		len = PAGE_SIZE - (start & (PAGE_SIZE - 1));
11a347fb6cef62 Yuezhang Mo  2023-03-13  537  		if (start + len > end)
11a347fb6cef62 Yuezhang Mo  2023-03-13  538  			len = end - start;
11a347fb6cef62 Yuezhang Mo  2023-03-13  539  
11a347fb6cef62 Yuezhang Mo  2023-03-13  540  		err = ops->write_begin(file, mapping, start, len, &page, NULL);
11a347fb6cef62 Yuezhang Mo  2023-03-13  541  		if (err)
11a347fb6cef62 Yuezhang Mo  2023-03-13  542  			goto out;
11a347fb6cef62 Yuezhang Mo  2023-03-13  543  
11a347fb6cef62 Yuezhang Mo  2023-03-13  544  		err = ops->write_end(file, mapping, start, len, len, page, NULL);
11a347fb6cef62 Yuezhang Mo  2023-03-13  545  		if (err < 0)
11a347fb6cef62 Yuezhang Mo  2023-03-13  546  			goto out;
11a347fb6cef62 Yuezhang Mo  2023-03-13  547  		start += len;
11a347fb6cef62 Yuezhang Mo  2023-03-13  548  
11a347fb6cef62 Yuezhang Mo  2023-03-13  549  		balance_dirty_pages_ratelimited(mapping);
11a347fb6cef62 Yuezhang Mo  2023-03-13  550  		cond_resched();
11a347fb6cef62 Yuezhang Mo  2023-03-13  551  	}
11a347fb6cef62 Yuezhang Mo  2023-03-13  552  
11a347fb6cef62 Yuezhang Mo  2023-03-13  553  out:
11a347fb6cef62 Yuezhang Mo  2023-03-13 @554  	return err;
11a347fb6cef62 Yuezhang Mo  2023-03-13  555  }
11a347fb6cef62 Yuezhang Mo  2023-03-13  556  

:::::: The code at line 554 was first introduced by commit
:::::: 11a347fb6cef62ce47e84b97c45f2b2497c7593b exfat: change to get file size from DataLength

:::::: TO: Yuezhang Mo <Yuezhang.Mo@sony.com>
:::::: CC: Namjae Jeon <linkinjeon@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-04-10  9:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202404101738.kyon9qo2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.