From: kernel test robot <lkp@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v2 5/6] PCI/TSM: Authenticate devices via platform TSM
Date: Sat, 13 Apr 2024 15:34:47 +0800 [thread overview]
Message-ID: <202404131527.J7luI66n-lkp@intel.com> (raw)
In-Reply-To: <171291193308.3532867.129739584130889725.stgit@dwillia2-xfh.jf.intel.com>
Hi Dan,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on 4cece764965020c22cff7665b18a012006359095]
url: https://github.com/intel-lab-lkp/linux/commits/Dan-Williams/configfs-tsm-Namespace-TSM-report-symbols/20240412-171254
base: 4cece764965020c22cff7665b18a012006359095
patch link: https://lore.kernel.org/r/171291193308.3532867.129739584130889725.stgit%40dwillia2-xfh.jf.intel.com
patch subject: [RFC PATCH v2 5/6] PCI/TSM: Authenticate devices via platform TSM
config: i386-randconfig-r111-20240413 (https://download.01.org/0day-ci/archive/20240413/202404131527.J7luI66n-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240413/202404131527.J7luI66n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404131527.J7luI66n-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/pci/tsm.o: in function `pci_tsm_doe_transfer':
>> drivers/pci/tsm.c:212:(.text+0x186): undefined reference to `pci_doe'
ld: drivers/pci/tsm.o: in function `pci_tsm_init':
>> drivers/pci/tsm.c:247:(.text+0x4d2): undefined reference to `pci_find_doe_mailbox'
vim +212 drivers/pci/tsm.c
204
205 int pci_tsm_doe_transfer(struct pci_dev *pdev, enum pci_doe_proto type,
206 const void *req, size_t req_sz, void *resp,
207 size_t resp_sz)
208 {
209 if (!pdev->tsm || !pdev->tsm->doe_mb)
210 return -ENXIO;
211
> 212 return pci_doe(pdev->tsm->doe_mb, PCI_VENDOR_ID_PCI_SIG, type, req,
213 req_sz, resp, resp_sz);
214 }
215 EXPORT_SYMBOL_GPL(pci_tsm_doe_transfer);
216
217 static unsigned long pci_tsm_devid(struct pci_dev *pdev)
218 {
219 return FIELD_PREP(GENMASK(15, 0),
220 PCI_DEVID(pdev->bus->number, pdev->devfn)) |
221 FIELD_PREP(GENMASK(31, 16), pci_domain_nr(pdev->bus));
222 }
223
224 void pci_tsm_init(struct pci_dev *pdev)
225 {
226 bool tee_cap;
227 u16 ide_cap;
228 int rc;
229
230 ide_cap = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_IDE);
231 tee_cap = pdev->devcap & PCI_EXP_DEVCAP_TEE;
232
233 if (ide_cap || tee_cap)
234 pci_dbg(pdev,
235 "Device security capabailities detected (%s%s ), init TSM\n",
236 ide_cap ? " ide" : "", tee_cap ? " tee" : "");
237 else
238 return;
239
240 struct pci_tsm *pci_tsm __free(kfree) = kzalloc(sizeof(*pci_tsm), GFP_KERNEL);
241 if (!pci_tsm)
242 return;
243
244 pci_tsm->ide_cap = ide_cap;
245 mutex_init(&pci_tsm->exec_lock);
246
> 247 pci_tsm->doe_mb = pci_find_doe_mailbox(pdev, PCI_VENDOR_ID_PCI_SIG,
248 PCI_DOE_PROTO_CMA);
249 if (!pci_tsm->doe_mb)
250 return;
251
252 rc = xa_insert(&pci_tsm_devs, pci_tsm_devid(pdev), pdev, GFP_KERNEL);
253 if (rc) {
254 pci_dbg(pdev, "failed to register TSM capable device\n");
255 return;
256 }
257
258 guard(rwsem_write)(&pci_tsm_rwsem);
259 pdev->tsm = no_free_ptr(pci_tsm);
260 pci_tsm_add(pdev);
261 }
262
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-04-13 7:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:51 [RFC PATCH v2 0/6] Towards a shared TSM sysfs-ABI for Confidential Computing Dan Williams
2024-04-12 8:51 ` [RFC PATCH v2 1/6] configfs-tsm: Namespace TSM report symbols Dan Williams
2024-04-12 8:51 ` [RFC PATCH v2 2/6] coco/guest: Move shared guest CC infrastructure to drivers/virt/coco/guest/ Dan Williams
2024-04-12 8:52 ` [RFC PATCH v2 3/6] x86/tdx: Introduce a "tdx" subsystem and "tsm" device Dan Williams
2024-04-12 8:52 ` [RFC PATCH v2 4/6] coco/tsm: Introduce a class device for TEE Security Managers Dan Williams
2024-04-12 8:52 ` [RFC PATCH v2 5/6] PCI/TSM: Authenticate devices via platform TSM Dan Williams
2024-04-13 3:14 ` kernel test robot
2024-04-13 7:34 ` kernel test robot [this message]
2024-04-13 11:11 ` kernel test robot
2024-04-19 22:07 ` Bjorn Helgaas
2024-04-27 1:27 ` Dan Williams
2024-04-22 2:21 ` Alexey Kardashevskiy
2024-04-27 2:58 ` Dan Williams
2024-05-06 15:14 ` Xu Yilun
2024-05-07 18:21 ` Dan Williams
2024-05-08 2:21 ` Xu Yilun
2024-05-07 8:46 ` Xu Yilun
2024-05-07 18:28 ` Dan Williams
2024-05-14 17:13 ` Zhi Wang
2024-04-12 8:52 ` [RFC PATCH v2 6/6] tdx_tsm: TEE Security Manager driver for TDX Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404131527.J7luI66n-lkp@intel.com \
--to=lkp@intel.com \
--cc=dan.j.williams@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.