From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Brian Norris <computersforpeace@gmail.com>,
Jaiganesh Narayanan <njaigane@codeaurora.org>
Cc: Johan Hovold <johan@kernel.org>,
Doug Anderson <dianders@chromium.org>,
<linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>
Subject: [PATCH] pinctrl: qcom: Fix behavior in abscense of open-drain support
Date: Wed, 24 Apr 2024 20:45:31 -0700 [thread overview]
Message-ID: <20240424-tlmm-open-drain-v1-1-9dd2041f0532@quicinc.com> (raw)
When a GPIO is configured as OPEN_DRAIN gpiolib will in
gpiod_direction_output() attempt to configure the open-drain property of
the hardware and if this fails fall back to software emulation of this
state.
The TLMM block in most Qualcomm platform does not implement such
functionality, so this call would be expected to fail. But due to lack
of checks for this condition, the zero-initialized od_bit will cause
this request to silently corrupt the lowest bit in the config register
(which typically is part of the bias configuration) and happily continue
on.
Fix this by checking if the od_bit value is unspecified and if so fail
the request to avoid the unexpected state, and to make sure the software
fallback actually kicks in.
It is assumed for now that no implementation will come into existence
with BIT(0) being the open-drain bit, simply for convenience sake.
Fixes: 13355ca35cd1 ("pinctrl: qcom: ipq4019: add open drain support")
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++
drivers/pinctrl/qcom/pinctrl-msm.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index aeaf0d1958f5..329474dc21c0 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -313,6 +313,8 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
*mask |= BIT(g->i2c_pull_bit) >> *bit;
break;
case PIN_CONFIG_DRIVE_OPEN_DRAIN:
+ if (!g->od_bit)
+ return -EOPNOTSUPP;
*bit = g->od_bit;
*mask = 1;
break;
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h
index 63852ed70295..7b8cd1832112 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.h
+++ b/drivers/pinctrl/qcom/pinctrl-msm.h
@@ -51,7 +51,8 @@ struct pinctrl_pin_desc;
* @mux_bit: Offset in @ctl_reg for the pinmux function selection.
* @pull_bit: Offset in @ctl_reg for the bias configuration.
* @drv_bit: Offset in @ctl_reg for the drive strength configuration.
- * @od_bit: Offset in @ctl_reg for controlling open drain.
+ * @od_bit: Offset in @ctl_reg for controlling open drain. 0 if
+ * not supported by target.
* @oe_bit: Offset in @ctl_reg for controlling output enable.
* @in_bit: Offset in @io_reg for the input bit value.
* @out_bit: Offset in @io_reg for the output bit value.
---
base-commit: 5e4f84f18c4ee9b0ccdc19e39b7de41df21699dd
change-id: 20240424-tlmm-open-drain-8b014c1cfa1a
Best regards,
--
Bjorn Andersson <quic_bjorande@quicinc.com>
next reply other threads:[~2024-04-25 3:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 3:45 Bjorn Andersson [this message]
2024-04-25 12:02 ` [PATCH] pinctrl: qcom: Fix behavior in abscense of open-drain support Johan Hovold
2024-04-25 13:47 ` Bjorn Andersson
2024-04-26 22:08 ` Brian Norris
2024-04-26 23:43 ` Bjorn Andersson
2024-04-27 6:18 ` Brian Norris
2024-05-03 7:28 ` Linus Walleij
2024-05-03 7:35 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424-tlmm-open-drain-v1-1-9dd2041f0532@quicinc.com \
--to=quic_bjorande@quicinc.com \
--cc=andersson@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=njaigane@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.