From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Nirmoy Das" <nirmoy.das@intel.com>,
"Oak Zeng" <oak.zeng@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>
Subject: [PATCH v5 1/5] drm/xe: Introduce has_atomic_enable_pte_bit device info
Date: Fri, 26 Apr 2024 12:56:51 +0200 [thread overview]
Message-ID: <20240426105655.23738-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20240426105655.23738-1-nirmoy.das@intel.com>
Add has_atomic_enable_pte_bit to specify that a device
has PTE_AE bit in its PTE feild. Currently XE2 and PVC
supports this so set this for those two.
This will help consolidate setting atomic access bit in PTE
logic which is spread between multiple files.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Oak Zeng <oak.zeng@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/xe/xe_device_types.h | 2 ++
drivers/gpu/drm/xe/xe_pci.c | 3 +++
drivers/gpu/drm/xe/xe_pci_types.h | 1 +
3 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 0f68c55ea405..7cddb00f9c35 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -281,6 +281,8 @@ struct xe_device {
u8 has_heci_gscfi:1;
/** @info.skip_guc_pc: Skip GuC based PM feature init */
u8 skip_guc_pc:1;
+ /** @info.has_atomic_enable_pte_bit: Device has atomic enable PTE bit */
+ u8 has_atomic_enable_pte_bit:1;
#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
struct {
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index a0cf5dd803c2..5618318e6f3a 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -146,6 +146,7 @@ static const struct xe_graphics_desc graphics_xehpc = {
.vram_flags = XE_VRAM_FLAGS_NEED64K,
.has_asid = 1,
+ .has_atomic_enable_pte_bit = 1,
.has_flat_ccs = 0,
.has_usm = 1,
};
@@ -163,6 +164,7 @@ static const struct xe_graphics_desc graphics_xelpg = {
#define XE2_GFX_FEATURES \
.dma_mask_size = 46, \
.has_asid = 1, \
+ .has_atomic_enable_pte_bit = 1, \
.has_flat_ccs = 1, \
.has_range_tlb_invalidation = 1, \
.has_usm = 1, \
@@ -629,6 +631,7 @@ static int xe_info_init(struct xe_device *xe,
xe->info.va_bits = graphics_desc->va_bits;
xe->info.vm_max_level = graphics_desc->vm_max_level;
xe->info.has_asid = graphics_desc->has_asid;
+ xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
xe->info.has_flat_ccs = graphics_desc->has_flat_ccs;
xe->info.has_range_tlb_invalidation = graphics_desc->has_range_tlb_invalidation;
xe->info.has_usm = graphics_desc->has_usm;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index b1ad12fa22d6..e1f2b4879fc2 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -25,6 +25,7 @@ struct xe_graphics_desc {
u8 max_remote_tiles:2;
u8 has_asid:1;
+ u8 has_atomic_enable_pte_bit:1;
u8 has_flat_ccs:1;
u8 has_range_tlb_invalidation:1;
u8 has_usm:1;
--
2.42.0
next prev parent reply other threads:[~2024-04-26 11:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:56 [PATCH v5 0/5] Refactor default device atomic settings Nirmoy Das
2024-04-26 10:56 ` Nirmoy Das [this message]
2024-04-26 10:56 ` [PATCH v5 2/5] drm/xe: Move vm bind bo validation to a helper function Nirmoy Das
2024-04-26 10:56 ` [PATCH v5 3/5] drm/xe: Introduce has_device_atomics_on_smem device info Nirmoy Das
2024-04-26 10:56 ` [PATCH v5 4/5] drm/xe: Add function to check if BO has single placement Nirmoy Das
2024-04-26 10:56 ` [PATCH v5 5/5] drm/xe: Refactor default device atomic settings Nirmoy Das
2024-04-26 21:04 ` Souza, Jose
2024-04-29 9:05 ` Nirmoy Das
2024-04-29 13:46 ` Souza, Jose
2024-04-29 14:15 ` Nirmoy Das
2024-04-26 12:49 ` ✓ CI.Patch_applied: success for Refactor default device atomic settings (rev3) Patchwork
2024-04-26 12:49 ` ✓ CI.checkpatch: " Patchwork
2024-04-26 12:50 ` ✓ CI.KUnit: " Patchwork
2024-04-26 13:05 ` ✓ CI.Build: " Patchwork
2024-04-26 13:08 ` ✓ CI.Hooks: " Patchwork
2024-04-26 13:09 ` ✓ CI.checksparse: " Patchwork
2024-04-26 13:40 ` ✓ CI.BAT: " Patchwork
2024-04-26 16:26 ` ✗ CI.FULL: failure " Patchwork
2024-04-26 20:41 ` ✓ CI.Patch_applied: success for Refactor default device atomic settings (rev4) Patchwork
2024-04-26 20:42 ` ✓ CI.checkpatch: " Patchwork
2024-04-26 20:43 ` ✓ CI.KUnit: " Patchwork
2024-04-29 9:11 ` ✗ CI.Patch_applied: failure for Refactor default device atomic settings (rev5) Patchwork
2024-04-29 15:43 ` [PATCH v5 0/5] Refactor default device atomic settings Mrozek, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426105655.23738-2-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=oak.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.