From: Douglas Anderson <dianders@chromium.org>
To: dri-devel@lists.freedesktop.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
lvzhaoxiong@huaqin.corp-partner.google.com,
Jani Nikula <jani.nikula@linux.intel.com>,
Hsin-Yi Wang <hsinyi@google.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Joel Selvaraj <jo@jsfamily.in>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
Sam Ravnborg <sam@ravnborg.org>,
Douglas Anderson <dianders@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/8] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints
Date: Fri, 26 Apr 2024 16:58:38 -0700 [thread overview]
Message-ID: <20240426165839.v2.5.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid> (raw)
In-Reply-To: <20240426235857.3870424-1-dianders@chromium.org>
We really don't expect these errors to be printed over and over
again. When a driver hits the error it should bail out. Just use a
normal error print.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v2:
- New
drivers/gpu/drm/drm_mipi_dsi.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index b7c75a4396e6..8bc2db971e93 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -770,7 +770,7 @@ EXPORT_SYMBOL(mipi_dsi_generic_write);
* @payload: buffer containing the payload
* @size: size of payload buffer
*
- * Like mipi_dsi_generic_write() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_generic_write() but includes a dev_err()
* call for you and returns 0 upon success, not the number of bytes sent.
*
* Return: 0 on success or a negative error code on failure.
@@ -783,8 +783,8 @@ int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,
ret = mipi_dsi_generic_write(dsi, payload, size);
if (ret < 0) {
- dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
- (int)size, payload, (int)ret);
+ dev_err(dev, "sending generic data %*ph failed: %d\n",
+ (int)size, payload, (int)ret);
return ret;
}
@@ -814,8 +814,8 @@ void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,
ret = mipi_dsi_generic_write(dsi, payload, size);
if (ret < 0) {
ctx->accum_err = ret;
- dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
- (int)size, payload, ctx->accum_err);
+ dev_err(dev, "sending generic data %*ph failed: %d\n",
+ (int)size, payload, ctx->accum_err);
}
}
EXPORT_SYMBOL(mipi_dsi_generic_write_multi);
@@ -914,7 +914,7 @@ EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer);
* @data: buffer containing data to be transmitted
* @len: size of transmission buffer
*
- * Like mipi_dsi_dcs_write_buffer() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_dcs_write_buffer() but includes a dev_err()
* call for you and returns 0 upon success, not the number of bytes sent.
*
* Return: 0 on success or a negative error code on failure.
@@ -927,8 +927,8 @@ int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
if (ret < 0) {
- dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
- (int)len, data, (int)ret);
+ dev_err(dev, "sending dcs data %*ph failed: %d\n",
+ (int)len, data, (int)ret);
return ret;
}
@@ -958,8 +958,8 @@ void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
if (ret < 0) {
ctx->accum_err = ret;
- dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
- (int)len, data, ctx->accum_err);
+ dev_err(dev, "sending dcs data %*ph failed: %d\n",
+ (int)len, data, ctx->accum_err);
}
}
EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_multi);
--
2.44.0.769.g3c40516874-goog
next prev parent reply other threads:[~2024-04-26 23:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 23:58 [PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs Douglas Anderson
2024-04-26 23:58 ` [PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq() Douglas Anderson
2024-04-27 1:44 ` Dmitry Baryshkov
2024-04-27 6:22 ` Sam Ravnborg
2024-04-29 21:42 ` Doug Anderson
2024-04-26 23:58 ` [PATCH v2 2/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_generic_write_seq() Douglas Anderson
2024-04-26 23:58 ` [PATCH v2 3/8] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq() Douglas Anderson
2024-04-27 2:05 ` Dmitry Baryshkov
2024-04-26 23:58 ` [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi() Douglas Anderson
2024-04-27 6:32 ` Sam Ravnborg
2024-04-29 14:13 ` Doug Anderson
2024-04-29 9:38 ` Neil Armstrong
2024-04-29 14:26 ` Doug Anderson
2024-04-29 15:39 ` Jani Nikula
2024-05-01 15:49 ` Doug Anderson
2024-05-01 15:57 ` Dmitry Baryshkov
2024-05-06 6:21 ` Linus Walleij
2024-04-26 23:58 ` Douglas Anderson [this message]
2024-04-26 23:58 ` [PATCH v2 6/8] drm/panel: novatek-nt36672e: Switch to mipi_dsi_dcs_write_seq_multi() Douglas Anderson
2024-04-26 23:58 ` [PATCH v2 7/8] drm/panel: boe-tv101wum-nl6: Don't use a table for initting commands Douglas Anderson
2024-04-26 23:58 ` [PATCH v2 8/8] drm/panel: boe-tv101wum-nl6: Convert hex to lowercase Douglas Anderson
2024-04-27 8:48 ` Dmitry Baryshkov
2024-04-29 9:20 ` [PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426165839.v2.5.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid \
--to=dianders@chromium.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jo@jsfamily.in \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.