From: Denys Dmytriyenko <denis@denix.org>
To: reatmon@ti.com
Cc: "Limaye, Aniket" <a-limaye@ti.com>,
meta-ti@lists.yoctoproject.org, b-padhi@ti.com
Subject: Re: [meta-ti][master/scarthgap][PATCH] conf: machine: add AM69-SK machine configuration
Date: Fri, 26 Apr 2024 15:01:00 -0400 [thread overview]
Message-ID: <20240426190100.GJ28791@denix.org> (raw)
In-Reply-To: <7e4668e3-d834-4d55-bd17-9a6a98f96251@ti.com>
On Thu, Apr 25, 2024 at 02:36:10PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
>
>
> On 4/24/2024 10:59 PM, Limaye, Aniket wrote:
> >On 4/24/2024 6:53 PM, Ryan Eatmon wrote:
> >>
> >>We have consistently named the machines with -evm and not -sk.
> >>Is there a good reason to not name this am69-evm?
> >>
> >Well this is just following the naming convention that got
> >accepted in u-boot:
> >
> >https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/configs?h=ti-u-boot-2024.04
> >
> >Yeah other parts have been like "am62x_evm_*_defconfig" and such,
> >but for am69 we have gone with "am69_sk_*_defconfig"
> >
> >Even the dts files for these, everywhere, have -sk suffixes.
> >
> >Hence the change here as well.
>
> Just because the configs in uboot have sk does not imply that the
> machine name in meta-ti needs to have sk. From my understanding,
> generally the sk comes first and latest a full up evm. But the
> Yocto machine usually supports all of the variations and so they
> were named with -evm to be the broadest possible name.
>
> My personal preference would be to eliminate the -evm for all of the
> machines and just go with the soc name.
Just make sure that won't conflict with the SoC family name, as currently
the part of the machine name w/o -evm is what's used for SoC name...
> But if we are going to have
> it then I think they should be consistent.
>
>
> >Regards,
> >Aniket
> >
> >>
> >>
> >>On 4/24/2024 3:35 AM, Aniket Limaye wrote:
> >>>From: Beleswar Padhi <b-padhi@ti.com>
> >>>
> >>>As of commits [1] and [2] in ti-u-boot-2024.04 and upstream respectively
> >>>there is a separate defconfig to build u-boot for j784s4-evm and am69-sk
> >>>
> >>>Hence, introduce new yocto machine configs for am69-sk. Also remove am69
> >>>devicetree builds from the j784s4-evm conf
> >>>
> >>>[1]: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04&id=8a46af7a39e6218e4de5c6195697af36201c778c
> >>>[2]: https://source.denx.de/u-boot/u-boot/-/commit/740759d558e632e1540d620baadbcc46fdf24db2
> >>>
> >>>Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> >>>Signed-off-by: Aniket Limaye <a-limaye@ti.com>
> >>>---
> >>> meta-ti-bsp/conf/machine/am69-sk-k3r5.conf | 11 +++++++++++
> >>> meta-ti-bsp/conf/machine/am69-sk.conf | 20 ++++++++++++++++++++
> >>> meta-ti-bsp/conf/machine/j784s4-evm.conf | 1 -
> >>> 3 files changed, 31 insertions(+), 1 deletion(-)
> >>> create mode 100644 meta-ti-bsp/conf/machine/am69-sk-k3r5.conf
> >>> create mode 100644 meta-ti-bsp/conf/machine/am69-sk.conf
> >>>
> >>>diff --git a/meta-ti-bsp/conf/machine/am69-sk-k3r5.conf
> >>>b/meta-ti-bsp/conf/machine/am69-sk-k3r5.conf
> >>>new file mode 100644
> >>>index 00000000..9d2b4cd6
> >>>--- /dev/null
> >>>+++ b/meta-ti-bsp/conf/machine/am69-sk-k3r5.conf
> >>>@@ -0,0 +1,11 @@
> >>>+#@TYPE: Machine
> >>>+#@NAME: AM69 SK (R5F)
> >>>+#@DESCRIPTION: Machine configuration for the TI AM69 SK (R5F core)
> >>>+
> >>>+require conf/machine/include/k3r5.inc
> >>>+
> >>>+SYSFW_SOC = "j784s4"
> >>>+SYSFW_CONFIG = "evm"
> >>>+SYSFW_SUFFIX = "hs-fs"
> >>>+
> >>>+UBOOT_MACHINE = "am69_sk_r5_defconfig"
> >>>diff --git a/meta-ti-bsp/conf/machine/am69-sk.conf
> >>>b/meta-ti-bsp/conf/machine/am69-sk.conf
> >>>new file mode 100644
> >>>index 00000000..233a4618
> >>>--- /dev/null
> >>>+++ b/meta-ti-bsp/conf/machine/am69-sk.conf
> >>>@@ -0,0 +1,20 @@
> >>>+#@TYPE: Machine
> >>>+#@NAME: AM69 SK
> >>>+#@DESCRIPTION: Machine configuration for the TI AM69 SK
> >>>+
> >>>+require conf/machine/include/j784s4.inc
> >>>+
> >>>+TFA_K3_USART = "0x8"
> >>>+OPTEE_K3_USART = "0x8"
> >>>+
> >>>+KERNEL_DEVICETREE_PREFIX = " \
> >>>+ ti/k3-am69-sk \
> >>>+ ti/k3-fpdlink \
> >>>+ ti/k3-v3link \
> >>>+"
> >>>+
> >>>+KERNEL_DEVICETREE = " \
> >>>+ ti/k3-am69-sk.dtb \
> >>>+"
> >>>+
> >>>+UBOOT_MACHINE = "am69_sk_a72_defconfig"
> >>>diff --git a/meta-ti-bsp/conf/machine/j784s4-evm.conf
> >>>b/meta-ti-bsp/conf/machine/j784s4-evm.conf
> >>>index e451bf47..6573e5c5 100644
> >>>--- a/meta-ti-bsp/conf/machine/j784s4-evm.conf
> >>>+++ b/meta-ti-bsp/conf/machine/j784s4-evm.conf
> >>>@@ -11,7 +11,6 @@ KERNEL_DEVICETREE_PREFIX = " \
> >>> ti/k3-j784s4 \
> >>> ti/k3-fpdlink \
> >>> ti/k3-j7200-evm-mcspi-loopback \
> >>>- ti/k3-am69-sk \
> >>> ti/k3-v3link \
> >>> "
> >>
next prev parent reply other threads:[~2024-04-26 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 8:35 [meta-ti][master/scarthgap][PATCH] conf: machine: add AM69-SK machine configuration Aniket Limaye
2024-04-24 13:23 ` Ryan Eatmon
2024-04-25 3:59 ` Limaye, Aniket
2024-04-25 19:36 ` Ryan Eatmon
2024-04-26 19:01 ` Denys Dmytriyenko [this message]
2024-04-26 21:08 ` Ryan Eatmon
2024-04-29 13:51 ` Limaye, Aniket
2024-04-29 15:00 ` Ryan Eatmon
2024-04-29 17:56 ` Limaye, Aniket
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426190100.GJ28791@denix.org \
--to=denis@denix.org \
--cc=a-limaye@ti.com \
--cc=b-padhi@ti.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.