From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Gil Fine <gil.fine@linux.intel.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, gil.fine@intel.com,
linux-usb@vger.kernel.org, lukas@wunner.de,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] thunderbolt: Fix uninitialized variable in tb_tunnel_alloc_usb3()
Date: Sat, 27 Apr 2024 08:07:38 +0300 [thread overview]
Message-ID: <20240427050738.GA3969176@black.fi.intel.com> (raw)
In-Reply-To: <20240425232417.3509833-1-gil.fine@linux.intel.com>
On Fri, Apr 26, 2024 at 02:24:17AM +0300, Gil Fine wrote:
> Currently in case of no bandwidth available for USB3 tunnel, we are left with
> uninitialized variable that can lead to huge negative allocated bandwidth.
>
> Fix this by initializing the variable to zero.
> While there, fix the kernel-doc to describe more accurately the purpose of the
> function tb_tunnel_alloc_usb3().
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/linux-usb/6289898b-cd63-4fb8-906a-1b6977321af9@moroto.mountain/
> Fixes: 7e227d09f80d ("thunderbolt: Allow USB3 bandwidth to be lower than maximum supported")
> Signed-off-by: Gil Fine <gil.fine@linux.intel.com>
I fixed the commit ID to match the one in my tree and applied to
thunderbolt.git/next, thanks!
prev parent reply other threads:[~2024-04-27 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 23:24 [PATCH] thunderbolt: Fix uninitialized variable in tb_tunnel_alloc_usb3() Gil Fine
2024-04-27 5:07 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240427050738.GA3969176@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gil.fine@intel.com \
--cc=gil.fine@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.