From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DD64204B for ; Sat, 27 Apr 2024 11:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714217909; cv=none; b=N1rAkXX65tpwY0ifeRQXnOH3EbKEqyDqzqHGYQiZG9WQ2IVxSF5B8pdzD1qGaF/ApYhkj4zDj0GYKf8dLazPoJgJ3FVRERQODvULWmZvShEov0r6Bk5EwbCfHjU1k52bMgbPfsXRGk017ElJVyrzl2YPhVNdFOG+SDUwbZ4+CmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714217909; c=relaxed/simple; bh=p8O2sAM2IxpLXYnB4aXc6lDvtD3kwwkCCZ0i/MQiGKg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F8FMMd3jJlGhO1Jz2Fo5S2SrSYiqnuv2OK3GAFYaOjWT6O48HCNJhfDfsBWuThhaZXaXcFa/F1t/HFafwVVG9NdqLRrM9xl8n9M3hu5Bmi6taHGCaAPd7dgmcS+Mi3PWUPJaVab8qJgFLodhy0dSin3hoFrXrnivZTPDjauF+fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WHmyZQ/y; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WHmyZQ/y" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6ee0642f718so3052629b3a.0 for ; Sat, 27 Apr 2024 04:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714217908; x=1714822708; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Np//FY4PRW7HBHaV5Y9xc/c4l4DQaCwD4Awtz2s21Ww=; b=WHmyZQ/yM1AjGbOsKmFc2eXmnX2Heg+JZEZmebwLAGilKJr49+I4ZGkdWOFYiAeYI9 MXg2KymXYFUta7riUD5r2zwR+koPDCAY6NXpXEx2/7aSP0o/JHFIsuxmMkJRVgk1E7E9 kW1gJmAYGpgE7pjjd249mJwU0WBjG2jXet2Dd7FHc+7FN8GbBWMPW7q+KDQVoAxecHOs WaZfkx7uREGEO8Q5xolXeUGdywH/5DUbQ5OcOZDs2u0mKwt7B5o1N0eZR7vYYuDtpPkU 4XaDTGN8jX2IteQ3o7c38N9B8qOkU/smw+yZ6v2K4S32T/GFUnlfR6qdHIAeGYC/IYVF s1Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714217908; x=1714822708; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Np//FY4PRW7HBHaV5Y9xc/c4l4DQaCwD4Awtz2s21Ww=; b=DuAKIeCo+eROKOwn23hx5viyukE9xCJiD3wpAXTp3U7T3OAtBMIGWjwWr8YjrrSKKs ub62dZ0fZYpmwuq+S8KHBcSv/KPe+k3mOuy68/mhORRRvzF89xQuYC5fmH2sTfP1olNH D2nQFPnzS2IFUybE/e64v+BYPS9TEfsHA31NlhVkc85l0DPwOttyO1oVKEqkD9GexYPq EpUHAg+WfetL8cS3HWi46XJbcu9LuT+60H/3LCwYa8s/4hSy3DxvgCqoCoMVh56vkjbd e1B5r7HKV6nFFUl42qBq+3jc3p/FGojo2vNTYljJEFn9pCiL00McGn2Qcqe3kIDpntbC p5QQ== X-Forwarded-Encrypted: i=1; AJvYcCWZR+yUPvo1mXA7oYddZCPv9lzdkouhcRP75wCSUlaOdXTWWwJ28E6bXVjHObC7cIL5wmM86PPMVS3enfdPuk8YahQSPJBJtZRHvgrB X-Gm-Message-State: AOJu0YzcACDcbjnFawrNoVbdMQwm9n2AQjTITwT+7YOxBzMrjD/G+mGl DnUd5k9EAoUIhZhqOBB2pTBNRm1YHYkNS7ynsrJ16cwUHzfRji9LvuPO+afHAw== X-Google-Smtp-Source: AGHT+IEF55H/1kS+Cfrgsn1sJ6Q8f7kM2jkzMm6mfROP3v0+pv0LxPc83s4Ah40q/gygS+pPW4uANg== X-Received: by 2002:a17:90a:c687:b0:2b0:763b:370e with SMTP id n7-20020a17090ac68700b002b0763b370emr3311655pjt.18.1714217907747; Sat, 27 Apr 2024 04:38:27 -0700 (PDT) Received: from thinkpad ([117.213.97.210]) by smtp.gmail.com with ESMTPSA id s11-20020a17090ae68b00b002adb62b633bsm10608534pjy.43.2024.04.27.04.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 04:38:27 -0700 (PDT) Date: Sat, 27 Apr 2024 17:08:17 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 09/11] PCI: imx: Consolidate redundant if-checks Message-ID: <20240427113817.GN1981@thinkpad> References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com> <20240402-pci2_upstream-v3-9-803414bdb430@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240402-pci2_upstream-v3-9-803414bdb430@nxp.com> On Tue, Apr 02, 2024 at 10:33:45AM -0400, Frank Li wrote: > Consolidated redundant if-checks pertaining to imx_pcie->phy. Instead of > two separate checks, merged them into one to improve code readability. > > if (imx_pcie->phy) { > ... code 1 > } > > if (imx_pcie->phy) { > ... code 2 > } > > Merge into one if block. > > if (imx_pcie->phy) { > ... code 1 > ... code 2 > } > > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-imx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-imx.c b/drivers/pci/controller/dwc/pcie-imx.c > index 653d8e8ee1abc..378808262d16b 100644 > --- a/drivers/pci/controller/dwc/pcie-imx.c > +++ b/drivers/pci/controller/dwc/pcie-imx.c > @@ -1103,9 +1103,7 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) > dev_err(dev, "pcie PHY power up failed\n"); > goto err_clk_disable; > } > - } > > - if (imx_pcie->phy) { > ret = phy_power_on(imx_pcie->phy); > if (ret) { > dev_err(dev, "waiting for PHY ready timeout!\n"); > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F166C4345F for ; Sat, 27 Apr 2024 11:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vxT7qvSoauOLPDi1mJep4S6IBP6+gbhlG5NTTwQhxyk=; b=hF5PflZ2B80ByE WIFBpPAnRFgBkYovdYg8IwFoOnKm/mSfJsDCpM059eQEXILaqXnmtJSgApDnptPCginfBWFFAcpUb NgIBMwNXlFITINRwYJ+2lwLqAPR97p1tMqQjCrhzxWO72efDhQ3xSODapMHQt9jJxzn2BT6tAoFlS zHWSpotG8vMqt0292+Oug3fnZz1oaraoOm8Gc3E9lZ2xu/Z+UpkEenlm3rFqRA0VMuI9bmXOLQX2O RsrxJ2NrK8x831T+piurE7iv7hMcOSOoQLFr3wNY5OSfMpCDdVNETTlm5dRuyXP3vaIqP3rRrko9n +VEySAP2/eQgiwon1mpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0gO1-0000000FSPC-0dLm; Sat, 27 Apr 2024 11:38:33 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0gNy-0000000FSOY-0Xy9 for linux-arm-kernel@lists.infradead.org; Sat, 27 Apr 2024 11:38:31 +0000 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2a2d0ca3c92so2180685a91.0 for ; Sat, 27 Apr 2024 04:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714217908; x=1714822708; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Np//FY4PRW7HBHaV5Y9xc/c4l4DQaCwD4Awtz2s21Ww=; b=J4uPf94tyDbiY0vdWFGDxTYcUeyf2Jlb+te+EsCPXkVM7mXmEjuRr8snAgpE8H+nxC 0bCvB8zaPcInt6HtrT19Caf5a3qcLZlnGGnhR9hTXFiHJVsZUJ5lsz4AKqb2It+QACEl mv7EZeorOVmCnjB45NaD8QCrbFJ9kfXcocprQmwBjRSE/LO4UAnk2xPfF/tuCMxswqph t5L2fSh3QXgYBae2ycrymNXhdmEDntZo6tXe9ijLJVvEkm2epIaEH4WiyV00G8YvCJo0 M9LUqupbuYHhzbbYRJMFWjS6nFgopm8lzAdlwQUqxTROwj3nBU7cS8607bQ1vpvuEbzE 6qKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714217908; x=1714822708; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Np//FY4PRW7HBHaV5Y9xc/c4l4DQaCwD4Awtz2s21Ww=; b=sXcjcnw+grnggYb4Fd8kQvRt6ycmoJkWfaHYBPIv5/0PD0O20XNA7tonjsssg76m9O Hyv5NwYzVIJFMFWq6pdM53b3T+SEITc/ExG3VNtez/p7Wah0YVO5x68+9IUgVbO+NLEu bAhWUCFYgZBjhOI5QOGEIVqTfxz7ym94J/hFaGY47RvlPJgKQRfh4vSx3DmyAKmb8vzC o6gMhvpH9scwmNhjSljATBaL/nXceFkY+znO5maRB2oW9gctFSA0nXz01vHOsmQIve6J 7DMF0v52wnu+iU+fE7y0i3kjlTeqBPTKn56swPDxXFu+/AEU3b1457xjfEPBSDF584Y9 8Yyw== X-Forwarded-Encrypted: i=1; AJvYcCWQ1m8+LbhCY+qODaHn3xzqo9mNOtsDs2PQrcmpuasm+jnL87LClH+bTJftbluaZpw6AWsVyvITQTZ6AYBmFHi9obUPrDepAZCaASDkcCeO4n86M8s= X-Gm-Message-State: AOJu0YxksfusVlaw6kDO0qpLR2EpPHaW8ViwQziNwxy+BAbT4b49dvcF AGjyUX143KU9q+J57T/S8JF5ZQj1mKycpe+KhqvDEzJb+I9yt3H+MB9ubnzbGA== X-Google-Smtp-Source: AGHT+IEF55H/1kS+Cfrgsn1sJ6Q8f7kM2jkzMm6mfROP3v0+pv0LxPc83s4Ah40q/gygS+pPW4uANg== X-Received: by 2002:a17:90a:c687:b0:2b0:763b:370e with SMTP id n7-20020a17090ac68700b002b0763b370emr3311655pjt.18.1714217907747; Sat, 27 Apr 2024 04:38:27 -0700 (PDT) Received: from thinkpad ([117.213.97.210]) by smtp.gmail.com with ESMTPSA id s11-20020a17090ae68b00b002adb62b633bsm10608534pjy.43.2024.04.27.04.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 04:38:27 -0700 (PDT) Date: Sat, 27 Apr 2024 17:08:17 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 09/11] PCI: imx: Consolidate redundant if-checks Message-ID: <20240427113817.GN1981@thinkpad> References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com> <20240402-pci2_upstream-v3-9-803414bdb430@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240402-pci2_upstream-v3-9-803414bdb430@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_043830_218913_12F45436 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDIsIDIwMjQgYXQgMTA6MzM6NDVBTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gQ29uc29saWRhdGVkIHJlZHVuZGFudCBpZi1jaGVja3MgcGVydGFpbmluZyB0byBpbXhfcGNp ZS0+cGh5LiBJbnN0ZWFkIG9mCj4gdHdvIHNlcGFyYXRlIGNoZWNrcywgbWVyZ2VkIHRoZW0gaW50 byBvbmUgdG8gaW1wcm92ZSBjb2RlIHJlYWRhYmlsaXR5Lgo+IAo+IGlmIChpbXhfcGNpZS0+cGh5 KSB7Cj4gCS4uLiBjb2RlIDEKPiB9Cj4gCj4gaWYgKGlteF9wY2llLT5waHkpIHsKPiAJLi4uIGNv ZGUgMgo+IH0KPiAKPiBNZXJnZSBpbnRvIG9uZSBpZiBibG9jay4KPiAKPiBpZiAoaW14X3BjaWUt PnBoeSkgewo+IAkuLi4gY29kZSAxCj4gCS4uLiBjb2RlIDIKPiB9Cj4gCj4gU2lnbmVkLW9mZi1i eTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+CgpSZXZpZXdlZC1ieTogTWFuaXZhbm5hbiBT YWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4KCi0gTWFuaQoKPiAt LS0KPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1pbXguYyB8IDIgLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNp L2NvbnRyb2xsZXIvZHdjL3BjaWUtaW14LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLWlteC5jCj4gaW5kZXggNjUzZDhlOGVlMWFiYy4uMzc4ODA4MjYyZDE2YiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWlteC5jCj4gKysrIGIvZHJpdmVy cy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1pbXguYwo+IEBAIC0xMTAzLDkgKzExMDMsNyBAQCBz dGF0aWMgaW50IGlteF9wY2llX2hvc3RfaW5pdChzdHJ1Y3QgZHdfcGNpZV9ycCAqcHApCj4gIAkJ CWRldl9lcnIoZGV2LCAicGNpZSBQSFkgcG93ZXIgdXAgZmFpbGVkXG4iKTsKPiAgCQkJZ290byBl cnJfY2xrX2Rpc2FibGU7Cj4gIAkJfQo+IC0JfQo+ICAKPiAtCWlmIChpbXhfcGNpZS0+cGh5KSB7 Cj4gIAkJcmV0ID0gcGh5X3Bvd2VyX29uKGlteF9wY2llLT5waHkpOwo+ICAJCWlmIChyZXQpIHsK PiAgCQkJZGV2X2VycihkZXYsICJ3YWl0aW5nIGZvciBQSFkgcmVhZHkgdGltZW91dCFcbiIpOwo+ IAo+IC0tIAo+IDIuMzQuMQo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprg rqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK