From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-42ac.mail.infomaniak.ch (smtp-42ac.mail.infomaniak.ch [84.16.66.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75043175A9 for ; Mon, 29 Apr 2024 12:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.66.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714394363; cv=none; b=CYYlr5GT8rCWmT51dulM/S7ewCtw1H+ZcLdobsuEJi0dNP1Nx0B+FyCubKWuE5GBKFK1zdtZwEY7UxeQXttDWb8gBBU/36VkoSF3iufCVuEIgYOLnN8Fu4Maa9B+ty7JZHcEFk+joJgYv5UgGrYvCt+vZt8d0+/Tz+nmwHcW4qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714394363; c=relaxed/simple; bh=xQ8IhuGGKzgAOYqouVROPG5PwWz+5I9v/foLO8Is22A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=imiBCZldcLLqLP/+hRqexAW1rWgvWQ2Lvpb42X2hkhLR1ec2LDmZlcQB/1s7l81ca5m+w9hIKzcoZpLWlncCeTO8a9iRoGVq0B8xUafBEz/+LXticRAQkt+EH5BTQnZrDj+ngoLNQ4wvsoD+/Puxug1WHzLNyvRBh/8dRNHdcRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=rFwDiDYF; arc=none smtp.client-ip=84.16.66.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="rFwDiDYF" Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4VSjZ61JRYzfY; Mon, 29 Apr 2024 14:39:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1714394350; bh=xQ8IhuGGKzgAOYqouVROPG5PwWz+5I9v/foLO8Is22A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rFwDiDYFNB8MxT+ieMChfPIAdInVvvEJdRgRTxPGApFXlh/QprCCHOWvjRrUYHguF nZhQ4PxUCPLZNQGOgx42jZGckE6sYYVJkIyjyp3+Amez+B617zmBCOO7RRhfVYtvEC EQP1B8jyNjb13m/oJMz5c5+AG9oyT8B9/QvO63lw= Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4VSjZ46STDzT34; Mon, 29 Apr 2024 14:39:08 +0200 (CEST) Date: Mon, 29 Apr 2024 14:39:08 +0200 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Kees Cook Cc: Christian Brauner , Jakub Kicinski , Mark Brown , Shengyu Li , Shuah Khan , "David S . Miller" , =?utf-8?Q?G=C3=BCnther?= Noack , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 2/5] selftests/landlock: Fix FS tests when run on a private mount point Message-ID: <20240429.Chahf2sai1au@digikod.net> References: <20240426172252.1862930-1-mic@digikod.net> <20240426172252.1862930-3-mic@digikod.net> <202404261237.C703A7B1F4@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202404261237.C703A7B1F4@keescook> X-Infomaniak-Routing: alpha On Fri, Apr 26, 2024 at 12:38:17PM -0700, Kees Cook wrote: > On Fri, Apr 26, 2024 at 07:22:49PM +0200, Mickaël Salaün wrote: > > According to the test environment, the mount point of the test's working > > directory may be shared or not, which changes the visibility of the > > nested "tmp" mount point for the test's parent process calling > > umount("tmp"). > > > > This was spotted while running tests on different Linux distributions, > > with different mount point configurations. > > Which distros did what? Actually it's not related to distros, but rather container runtime (Docker) vs. non-container environment. With Docker (at least on my environment) all mount points are private, which is not the case (by default) when running the same UML environment not in a container. See https://github.com/landlock-lsm/landlock-test-tools/pull/4 I'll update the description.