From: Yannic Moog <y.moog@phytec.de>
To: Simon Glass <sjg@chromium.org>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Tom Rini <trini@konsulko.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Benjamin Hahn <b.hahn@phytec.de>,
Teresa Remmet <t.remmet@phytec.de>,
Yashwanth Varakala <y.varakala@phytec.de>,
<upstream@lists.phytec.de>, <u-boot@lists.denx.de>,
Yannic Moog <y.moog@phytec.de>
Subject: [PATCH RFC 2/6] tools: binman: ftest: pass allow_fake_blob to _DoReadFileDtb
Date: Wed, 29 Jan 2025 11:29:47 +0100 [thread overview]
Message-ID: <20250129-binman_faked_optional-v1-2-a4534bc67cbb@phytec.de> (raw)
In-Reply-To: <20250129-binman_faked_optional-v1-0-a4534bc67cbb@phytec.de>
Some test cases don't use _DoTestFile directly which accepts
allow_fake_blobs. However, they specifically test functionality that
requires external blobs not to be faked. Extend the _DoReadFileDtb
signature to allow passing that option to _DoTestFile.
Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
tools/binman/ftest.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
index 1f194f9ecae..82f839e33b0 100644
--- a/tools/binman/ftest.py
+++ b/tools/binman/ftest.py
@@ -505,9 +505,9 @@ class TestFunctional(unittest.TestCase):
return dtb.GetContents()
def _DoReadFileDtb(self, fname, use_real_dtb=False, use_expanded=False,
- verbosity=None, map=False, update_dtb=False,
- entry_args=None, reset_dtbs=True, extra_indirs=None,
- threads=None):
+ verbosity=None, allow_fake_blobs=True, map=False,
+ update_dtb=False, entry_args=None, reset_dtbs=True,
+ extra_indirs=None, threads=None):
"""Run binman and return the resulting image
This runs binman with a given test file and then reads the resulting
@@ -525,6 +525,7 @@ class TestFunctional(unittest.TestCase):
use_expanded: True to use expanded entries where available, e.g.
'u-boot-expanded' instead of 'u-boot'
verbosity: Verbosity level to use (0-3, None=don't set it)
+ allow_fake_blob: whether binman should fake missing ext blobs
map: True to output map files for the images
update_dtb: Update the offset and size of each entry in the device
tree before packing it into the image
@@ -562,7 +563,7 @@ class TestFunctional(unittest.TestCase):
retcode = self._DoTestFile(fname, map=map, update_dtb=update_dtb,
entry_args=entry_args, use_real_dtb=use_real_dtb,
use_expanded=use_expanded, verbosity=verbosity,
- extra_indirs=extra_indirs,
+ allow_fake_blobs=allow_fake_blobs, extra_indirs=extra_indirs,
threads=threads)
self.assertEqual(0, retcode)
out_dtb_fname = tools.get_output_filename('u-boot.dtb.out')
--
2.43.0
next prev parent reply other threads:[~2025-01-29 10:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 10:29 [PATCH RFC 0/6] Fix handling of optional blobs in binman Yannic Moog
2025-01-29 10:29 ` [PATCH RFC 1/6] tools: binman: ftest.py: fake ext blobs per default Yannic Moog
2025-02-10 13:06 ` Simon Glass
2025-02-13 7:15 ` Yannic Moog
2025-02-13 14:01 ` Simon Glass
2025-02-14 7:18 ` Yannic Moog
2025-02-14 13:48 ` Simon Glass
2025-02-17 7:07 ` Yannic Moog
2025-01-29 10:29 ` Yannic Moog [this message]
2025-02-10 13:09 ` [PATCH RFC 2/6] tools: binman: ftest: pass allow_fake_blob to _DoReadFileDtb Simon Glass
2025-01-29 10:29 ` [PATCH RFC 3/6] tools: binman: ftest: fix tests that require non-faked ext blobs Yannic Moog
2025-02-10 13:09 ` Simon Glass
2025-02-13 7:15 ` Yannic Moog
2025-01-29 10:29 ` [PATCH RFC 4/6] binman: fix faked optional entry handling Yannic Moog
2025-02-10 13:09 ` Simon Glass
2025-01-29 10:29 ` [PATCH RFC 5/6] binman: test: assert optional blobs don't cause non-functionality Yannic Moog
2025-02-10 13:07 ` Simon Glass
2025-01-29 10:29 ` [PATCH RFC 6/6] binman: doc: update Optional entries Yannic Moog
2025-02-10 13:08 ` Simon Glass
2025-02-13 7:21 ` Yannic Moog
2025-02-13 14:01 ` Simon Glass
2025-02-14 7:05 ` Yannic Moog
2025-02-14 13:48 ` Simon Glass
2025-02-17 7:21 ` Yannic Moog
2025-02-17 13:13 ` Simon Glass
2025-02-18 13:15 ` Yannic Moog
2025-02-19 0:01 ` Simon Glass
2025-05-27 7:34 ` Simon Glass
2025-05-27 8:12 ` Yannic Moog
2025-05-27 12:04 ` Simon Glass
2025-02-10 13:08 ` [PATCH RFC 0/6] Fix handling of optional blobs in binman Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129-binman_faked_optional-v1-2-a4534bc67cbb@phytec.de \
--to=y.moog@phytec.de \
--cc=alpernebiyasak@gmail.com \
--cc=b.hahn@phytec.de \
--cc=festevam@gmail.com \
--cc=sjg@chromium.org \
--cc=t.remmet@phytec.de \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=upstream@lists.phytec.de \
--cc=y.varakala@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.