* [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
@ 2025-02-12 13:50 Scott Fan
2025-02-12 14:24 ` Baruch Siach via buildroot
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Scott Fan @ 2025-02-12 13:50 UTC (permalink / raw)
To: buildroot; +Cc: Scott Fan, Bernd Kuhls, Thomas Petazzoni
As of release 3.49.0, the author has replaced the configure script used in
the precompiled amalgamation tarball with Autosetup instead of Autotools.
Fixes:
https://autobuild.buildroot.org/?reason=sqlite-3.49.0
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
1 file changed, 36 insertions(+), 23 deletions(-)
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index a23f6e1d66..30385f9821 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
endif
-ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
-SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
-endif
-
-ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
-SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
-endif
-
ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
endif
@@ -50,30 +42,51 @@ else
SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
endif
-SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
-
-ifeq ($(BR2_STATIC_LIBS),y)
-SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
-else
-SQLITE_CONF_OPTS += --disable-static-shell
-endif
-
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
-SQLITE_CONF_OPTS += --enable-threadsafe
+SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
else
SQLITE_CONF_OPTS += --disable-threadsafe
-SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
endif
ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
SQLITE_DEPENDENCIES += ncurses readline
-SQLITE_CONF_OPTS += --disable-editline --enable-readline
else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
SQLITE_DEPENDENCIES += libedit
-SQLITE_CONF_OPTS += --enable-editline --disable-readline
+SQLITE_CONF_OPTS += --disable-readline --editline
else
-SQLITE_CONF_OPTS += --disable-editline --disable-readline
+SQLITE_CONF_OPTS += --disable-readline
endif
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
+ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
+SQLITE_CONF_OPTS += --fts3
+endif
+
+ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
+SQLITE_CONF_OPTS += --disable-json
+endif
+
+SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
+
+define SQLITE_CONFIGURE_CMDS
+ (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
+ --prefix=/usr \
+ --host="$(GNU_TARGET_NAME)" \
+ --build="$(GNU_HOST_NAME)" \
+ --sysroot="$(STAGING_DIR)" \
+ $(SQLITE_CONF_OPTS) \
+ )
+endef
+
+define SQLITE_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define SQLITE_INSTALL_STAGING_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
+endef
+
+define SQLITE_INSTALL_TARGET_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-12 13:50 [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0 Scott Fan
@ 2025-02-12 14:24 ` Baruch Siach via buildroot
2025-02-12 15:47 ` Fiona Klute via buildroot
2025-02-13 4:50 ` [Buildroot] [PATCH v2] " Scott Fan
2025-02-18 20:40 ` [Buildroot] [PATCH] " Julien Olivain
2 siblings, 1 reply; 15+ messages in thread
From: Baruch Siach via buildroot @ 2025-02-12 14:24 UTC (permalink / raw)
To: Scott Fan; +Cc: buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Scott,
On Wed, Feb 12 2025, Scott Fan wrote:
> As of release 3.49.0, the author has replaced the configure script used in
> the precompiled amalgamation tarball with Autosetup instead of Autotools.
>
> Fixes:
> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
> ---
> package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
> 1 file changed, 36 insertions(+), 23 deletions(-)
>
> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> index a23f6e1d66..30385f9821 100644
> --- a/package/sqlite/sqlite.mk
> +++ b/package/sqlite/sqlite.mk
> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
> endif
>
> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
> -endif
> -
> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
> -endif
> -
> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
> endif
> @@ -50,30 +42,51 @@ else
> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
> endif
>
> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> -
> -ifeq ($(BR2_STATIC_LIBS),y)
> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
> -else
> -SQLITE_CONF_OPTS += --disable-static-shell
> -endif
> -
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> -SQLITE_CONF_OPTS += --enable-threadsafe
> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
> else
> SQLITE_CONF_OPTS += --disable-threadsafe
> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
> endif
>
> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
> SQLITE_DEPENDENCIES += ncurses readline
> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> SQLITE_DEPENDENCIES += libedit
> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
> +SQLITE_CONF_OPTS += --disable-readline --editline
> else
> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
> +SQLITE_CONF_OPTS += --disable-readline
> endif
>
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> +SQLITE_CONF_OPTS += --fts3
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
> +SQLITE_CONF_OPTS += --disable-json
> +endif
> +
> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> +
> +define SQLITE_CONFIGURE_CMDS
> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
> + --prefix=/usr \
> + --host="$(GNU_TARGET_NAME)" \
> + --build="$(GNU_HOST_NAME)" \
> + --sysroot="$(STAGING_DIR)" \
> + $(SQLITE_CONF_OPTS) \
> + )
> +endef
> +
> +define SQLITE_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define SQLITE_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
> +endef
> +
> +define SQLITE_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
> +endef
> +
> +$(eval $(generic-package))
We also need host-generic-package to replace the host-autotools-package
removed above.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-12 14:24 ` Baruch Siach via buildroot
@ 2025-02-12 15:47 ` Fiona Klute via buildroot
2025-02-13 3:59 ` Scott Fan
0 siblings, 1 reply; 15+ messages in thread
From: Fiona Klute via buildroot @ 2025-02-12 15:47 UTC (permalink / raw)
To: Baruch Siach, Scott Fan; +Cc: buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Scott, Baruch!
Am 12.02.25 um 15:24 schrieb Baruch Siach via buildroot:
> Hi Scott,
>
> On Wed, Feb 12 2025, Scott Fan wrote:
>> As of release 3.49.0, the author has replaced the configure script used in
>> the precompiled amalgamation tarball with Autosetup instead of Autotools.
>>
>> Fixes:
>> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>>
>> Signed-off-by: Scott Fan <fancp2007@gmail.com>
Together with the "host-generic-package" Baruch pointed out this fixed
my build, thanks! One thing looks odd though, see below.
Best regards,
Fiona
>> ---
>> package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
>> 1 file changed, 36 insertions(+), 23 deletions(-)
>>
>> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
>> index a23f6e1d66..30385f9821 100644
>> --- a/package/sqlite/sqlite.mk
>> +++ b/package/sqlite/sqlite.mk
>> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
>> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
>> endif
>>
>> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
>> -endif
>> -
>> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
>> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
>> -endif
>> -
>> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
>> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
>> endif
>> @@ -50,30 +42,51 @@ else
>> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
>> endif
>>
>> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> -
>> -ifeq ($(BR2_STATIC_LIBS),y)
>> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
>> -else
>> -SQLITE_CONF_OPTS += --disable-static-shell
>> -endif
>> -
>> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>> -SQLITE_CONF_OPTS += --enable-threadsafe
>> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
>> else
>> SQLITE_CONF_OPTS += --disable-threadsafe
>> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
>> endif
Why does --disable-threadsafe remain, while --enable-threadsafe is
removed in the other branch, and -DSQLITE_THREADSAFE=0 removed while
-DSQLITE_THREADSAFE=1 is added in the other branch? That seems
inconsistent. My setup has BR2_TOOLCHAIN_HAS_THREADS=y, so I can only
confirm the branch with threads works.
>> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
>> SQLITE_DEPENDENCIES += ncurses readline
>> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
>> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
>> SQLITE_DEPENDENCIES += libedit
>> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
>> +SQLITE_CONF_OPTS += --disable-readline --editline
>> else
>> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
>> +SQLITE_CONF_OPTS += --disable-readline
>> endif
>>
>> -$(eval $(autotools-package))
>> -$(eval $(host-autotools-package))
>> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> +SQLITE_CONF_OPTS += --fts3
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
>> +SQLITE_CONF_OPTS += --disable-json
>> +endif
>> +
>> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> +
>> +define SQLITE_CONFIGURE_CMDS
>> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
>> + --prefix=/usr \
>> + --host="$(GNU_TARGET_NAME)" \
>> + --build="$(GNU_HOST_NAME)" \
>> + --sysroot="$(STAGING_DIR)" \
>> + $(SQLITE_CONF_OPTS) \
>> + )
>> +endef
>> +
>> +define SQLITE_BUILD_CMDS
>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>> +endef
>> +
>> +define SQLITE_INSTALL_STAGING_CMDS
>> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
>> +endef
>> +
>> +define SQLITE_INSTALL_TARGET_CMDS
>> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
>> +endef
>> +
>> +$(eval $(generic-package))
>
> We also need host-generic-package to replace the host-autotools-package
> removed above.
>
> baruch
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-12 15:47 ` Fiona Klute via buildroot
@ 2025-02-13 3:59 ` Scott Fan
2025-02-13 6:39 ` Roy Kollen Svendsen
0 siblings, 1 reply; 15+ messages in thread
From: Scott Fan @ 2025-02-13 3:59 UTC (permalink / raw)
To: Fiona Klute; +Cc: Bernd Kuhls, Thomas Petazzoni, buildroot
Hi
On Wed, Feb 12, 2025 at 11:47 PM Fiona Klute via buildroot
<buildroot@buildroot.org> wrote:
>
> Hi Scott, Baruch!
>
> Am 12.02.25 um 15:24 schrieb Baruch Siach via buildroot:
> > Hi Scott,
> >
> > On Wed, Feb 12 2025, Scott Fan wrote:
> >> As of release 3.49.0, the author has replaced the configure script used in
> >> the precompiled amalgamation tarball with Autosetup instead of Autotools.
> >>
> >> Fixes:
> >> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
> >>
> >> Signed-off-by: Scott Fan <fancp2007@gmail.com>
>
> Together with the "host-generic-package" Baruch pointed out this fixed
> my build, thanks! One thing looks odd though, see below.
I will add the missing configurations for the "host-generic-package".
>
> Best regards,
> Fiona
>
> >> ---
> >> package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
> >> 1 file changed, 36 insertions(+), 23 deletions(-)
> >>
> >> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> >> index a23f6e1d66..30385f9821 100644
> >> --- a/package/sqlite/sqlite.mk
> >> +++ b/package/sqlite/sqlite.mk
> >> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
> >> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
> >> endif
> >>
> >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
> >> -endif
> >> -
> >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
> >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
> >> -endif
> >> -
> >> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
> >> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
> >> endif
> >> @@ -50,30 +42,51 @@ else
> >> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
> >> endif
> >>
> >> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> >> -
> >> -ifeq ($(BR2_STATIC_LIBS),y)
> >> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
> >> -else
> >> -SQLITE_CONF_OPTS += --disable-static-shell
> >> -endif
> >> -
> >> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> >> -SQLITE_CONF_OPTS += --enable-threadsafe
> >> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
> >> else
> >> SQLITE_CONF_OPTS += --disable-threadsafe
> >> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
> >> endif
>
> Why does --disable-threadsafe remain, while --enable-threadsafe is
> removed in the other branch, and -DSQLITE_THREADSAFE=0 removed while
> -DSQLITE_THREADSAFE=1 is added in the other branch? That seems
> inconsistent. My setup has BR2_TOOLCHAIN_HAS_THREADS=y, so I can only
> confirm the branch with threads works.
When using the ./configure --help command in the release 3.49.0 to
view the usage, you can only see the --disable-threadsafe option, but
not the --enable-threadsafe option. Autosetup will automatically
detect whether threads are supported and set SQLITE_THREADSAFE to 1 or
0. If threads are supported, SQLITE_THREADSAFE=1 is automatically set
by default, but you can force SQLITE_THREADSAFE=0 with the
--disable-threadsafe option.
In my opinion, Autosetup has already done what it should do. I will
delete the lines related to thread safety options in the sqlite.mk
file.
>
> >> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
> >> SQLITE_DEPENDENCIES += ncurses readline
> >> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
> >> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> >> SQLITE_DEPENDENCIES += libedit
> >> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
> >> +SQLITE_CONF_OPTS += --disable-readline --editline
> >> else
> >> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
> >> +SQLITE_CONF_OPTS += --disable-readline
> >> endif
> >>
> >> -$(eval $(autotools-package))
> >> -$(eval $(host-autotools-package))
> >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> >> +SQLITE_CONF_OPTS += --fts3
> >> +endif
> >> +
> >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
> >> +SQLITE_CONF_OPTS += --disable-json
> >> +endif
> >> +
> >> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> >> +
> >> +define SQLITE_CONFIGURE_CMDS
> >> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
> >> + --prefix=/usr \
> >> + --host="$(GNU_TARGET_NAME)" \
> >> + --build="$(GNU_HOST_NAME)" \
> >> + --sysroot="$(STAGING_DIR)" \
> >> + $(SQLITE_CONF_OPTS) \
> >> + )
> >> +endef
> >> +
> >> +define SQLITE_BUILD_CMDS
> >> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> >> +endef
> >> +
> >> +define SQLITE_INSTALL_STAGING_CMDS
> >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
> >> +endef
> >> +
> >> +define SQLITE_INSTALL_TARGET_CMDS
> >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
> >> +endef
> >> +
> >> +$(eval $(generic-package))
> >
> > We also need host-generic-package to replace the host-autotools-package
> > removed above.
> >
> > baruch
> >
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-12 13:50 [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0 Scott Fan
2025-02-12 14:24 ` Baruch Siach via buildroot
@ 2025-02-13 4:50 ` Scott Fan
2025-02-13 17:42 ` Fiona Klute via buildroot
2025-02-13 21:37 ` Julien Olivain
2025-02-18 20:40 ` [Buildroot] [PATCH] " Julien Olivain
2 siblings, 2 replies; 15+ messages in thread
From: Scott Fan @ 2025-02-13 4:50 UTC (permalink / raw)
To: buildroot; +Cc: Scott Fan, Bernd Kuhls, Thomas Petazzoni
As of release 3.49.0, the author has replaced the configure script used in
the precompiled amalgamation tarball with Autosetup instead of Autotools.
The "autotools-package" and "host-autotools-package" lines are no longer
available, so those have to be replaced by the "generic-package" and
"host-generic-package" lines in the .mk file.
The Autosetup configuration script does not support the
"enable-dynamic-extensions" and "disable-static-shell" options,
so the relevant lines in the .mk file are removed.
The Autosetup configuration script can automatically detect whether
threads are supported and set the relevant SQLITE_THREADSAFE flag,
so the relevant lines in the .mk file are removed.
Fixes:
https://autobuild.buildroot.org/?reason=sqlite-3.49.0
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v1 -> v2:
- add the 'host-generic-package' configurations in the .mk file
- remove the thread-safe related configurations in the .mk file
- update commit message
---
package/sqlite/sqlite.mk | 82 ++++++++++++++++++++++++++--------------
1 file changed, 54 insertions(+), 28 deletions(-)
diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index a23f6e1d66..5a8b033ce0 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
endif
-ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
-SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
-endif
-
-ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
-SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
-endif
-
ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
endif
@@ -50,30 +42,64 @@ else
SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
endif
-SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
-
-ifeq ($(BR2_STATIC_LIBS),y)
-SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
-else
-SQLITE_CONF_OPTS += --disable-static-shell
-endif
-
-ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
-SQLITE_CONF_OPTS += --enable-threadsafe
-else
-SQLITE_CONF_OPTS += --disable-threadsafe
-SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
-endif
-
ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
SQLITE_DEPENDENCIES += ncurses readline
-SQLITE_CONF_OPTS += --disable-editline --enable-readline
else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
SQLITE_DEPENDENCIES += libedit
-SQLITE_CONF_OPTS += --enable-editline --disable-readline
+SQLITE_CONF_OPTS += --disable-readline --editline
else
-SQLITE_CONF_OPTS += --disable-editline --disable-readline
+SQLITE_CONF_OPTS += --disable-readline
endif
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
+ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
+SQLITE_CONF_OPTS += --fts3
+endif
+
+ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
+SQLITE_CONF_OPTS += --disable-json
+endif
+
+SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
+
+define SQLITE_CONFIGURE_CMDS
+ (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
+ --prefix=/usr \
+ --host="$(GNU_TARGET_NAME)" \
+ --build="$(GNU_HOST_NAME)" \
+ --sysroot="$(STAGING_DIR)" \
+ $(SQLITE_CONF_OPTS) \
+ )
+endef
+
+define SQLITE_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define SQLITE_INSTALL_STAGING_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
+endef
+
+define SQLITE_INSTALL_TARGET_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+define HOST_SQLITE_CONFIGURE_CMDS
+ (cd $(@D); $(HOST_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
+ --prefix=/usr \
+ --host="$(GNU_HOST_NAME)" \
+ --build="$(GNU_HOST_NAME)" \
+ --sysroot="$(HOST_DIR)" \
+ $(SQLITE_CONF_OPTS) \
+ )
+endef
+
+define HOST_SQLITE_BUILD_CMDS
+ $(HOST_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define HOST_SQLITE_INSTALL_CMDS
+ $(HOST_MAKE_ENV) $(MAKE) DESTDIR="$(HOST_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))
+$(eval $(host-generic-package))
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 3:59 ` Scott Fan
@ 2025-02-13 6:39 ` Roy Kollen Svendsen
2025-02-13 8:19 ` Scott Fan
0 siblings, 1 reply; 15+ messages in thread
From: Roy Kollen Svendsen @ 2025-02-13 6:39 UTC (permalink / raw)
To: Scott Fan; +Cc: Fiona Klute, Bernd Kuhls, Thomas Petazzoni, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 5881 bytes --]
Hi,
Fixes:
2025-02-13T06:48:18 >>> sqlite 3.49.0 Configuring
...
2025-02-13T06:48:19 Error: Unknown option --target
Tested-By: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
tor. 13. feb. 2025 kl. 04:59 skrev Scott Fan <fancp2007@gmail.com>:
> Hi
>
> On Wed, Feb 12, 2025 at 11:47 PM Fiona Klute via buildroot
> <buildroot@buildroot.org> wrote:
> >
> > Hi Scott, Baruch!
> >
> > Am 12.02.25 um 15:24 schrieb Baruch Siach via buildroot:
> > > Hi Scott,
> > >
> > > On Wed, Feb 12 2025, Scott Fan wrote:
> > >> As of release 3.49.0, the author has replaced the configure script
> used in
> > >> the precompiled amalgamation tarball with Autosetup instead of
> Autotools.
> > >>
> > >> Fixes:
> > >> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
> > >>
> > >> Signed-off-by: Scott Fan <fancp2007@gmail.com>
> >
> > Together with the "host-generic-package" Baruch pointed out this fixed
> > my build, thanks! One thing looks odd though, see below.
>
> I will add the missing configurations for the "host-generic-package".
>
> >
> > Best regards,
> > Fiona
> >
> > >> ---
> > >> package/sqlite/sqlite.mk | 59
> ++++++++++++++++++++++++----------------
> > >> 1 file changed, 36 insertions(+), 23 deletions(-)
> > >>
> > >> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> > >> index a23f6e1d66..30385f9821 100644
> > >> --- a/package/sqlite/sqlite.mk
> > >> +++ b/package/sqlite/sqlite.mk
> > >> @@ -21,14 +21,6 @@ ifeq
> ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
> > >> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
> > >> endif
> > >>
> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
> > >> -endif
> > >> -
> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
> > >> -endif
> > >> -
> > >> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
> > >> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
> > >> endif
> > >> @@ -50,30 +42,51 @@ else
> > >> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
> > >> endif
> > >>
> > >> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> > >> -
> > >> -ifeq ($(BR2_STATIC_LIBS),y)
> > >> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
> > >> -else
> > >> -SQLITE_CONF_OPTS += --disable-static-shell
> > >> -endif
> > >> -
> > >> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> > >> -SQLITE_CONF_OPTS += --enable-threadsafe
> > >> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
> > >> else
> > >> SQLITE_CONF_OPTS += --disable-threadsafe
> > >> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
> > >> endif
> >
> > Why does --disable-threadsafe remain, while --enable-threadsafe is
> > removed in the other branch, and -DSQLITE_THREADSAFE=0 removed while
> > -DSQLITE_THREADSAFE=1 is added in the other branch? That seems
> > inconsistent. My setup has BR2_TOOLCHAIN_HAS_THREADS=y, so I can only
> > confirm the branch with threads works.
>
> When using the ./configure --help command in the release 3.49.0 to
> view the usage, you can only see the --disable-threadsafe option, but
> not the --enable-threadsafe option. Autosetup will automatically
> detect whether threads are supported and set SQLITE_THREADSAFE to 1 or
> 0. If threads are supported, SQLITE_THREADSAFE=1 is automatically set
> by default, but you can force SQLITE_THREADSAFE=0 with the
> --disable-threadsafe option.
>
> In my opinion, Autosetup has already done what it should do. I will
> delete the lines related to thread safety options in the sqlite.mk
> file.
>
>
> >
> > >> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
> > >> SQLITE_DEPENDENCIES += ncurses readline
> > >> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
> > >> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> > >> SQLITE_DEPENDENCIES += libedit
> > >> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
> > >> +SQLITE_CONF_OPTS += --disable-readline --editline
> > >> else
> > >> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
> > >> +SQLITE_CONF_OPTS += --disable-readline
> > >> endif
> > >>
> > >> -$(eval $(autotools-package))
> > >> -$(eval $(host-autotools-package))
> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> > >> +SQLITE_CONF_OPTS += --fts3
> > >> +endif
> > >> +
> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
> > >> +SQLITE_CONF_OPTS += --disable-json
> > >> +endif
> > >> +
> > >> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> > >> +
> > >> +define SQLITE_CONFIGURE_CMDS
> > >> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV)
> ./configure \
> > >> + --prefix=/usr \
> > >> + --host="$(GNU_TARGET_NAME)" \
> > >> + --build="$(GNU_HOST_NAME)" \
> > >> + --sysroot="$(STAGING_DIR)" \
> > >> + $(SQLITE_CONF_OPTS) \
> > >> + )
> > >> +endef
> > >> +
> > >> +define SQLITE_BUILD_CMDS
> > >> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> > >> +endef
> > >> +
> > >> +define SQLITE_INSTALL_STAGING_CMDS
> > >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D)
> install
> > >> +endef
> > >> +
> > >> +define SQLITE_INSTALL_TARGET_CMDS
> > >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D)
> install
> > >> +endef
> > >> +
> > >> +$(eval $(generic-package))
> > >
> > > We also need host-generic-package to replace the host-autotools-package
> > > removed above.
> > >
> > > baruch
> > >
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
[-- Attachment #1.2: Type: text/html, Size: 8741 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 6:39 ` Roy Kollen Svendsen
@ 2025-02-13 8:19 ` Scott Fan
2025-02-13 14:16 ` Scott Fan
0 siblings, 1 reply; 15+ messages in thread
From: Scott Fan @ 2025-02-13 8:19 UTC (permalink / raw)
To: Roy Kollen Svendsen; +Cc: Fiona Klute, Bernd Kuhls, Thomas Petazzoni, buildroot
Hi,
I had tested the patch v2 with the defconfig:
$ cat defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_NFS_UTILS=y
Everything is OK. The "sqlite" and "host-sqlite" targets that the
nfs_utils package depends on are both compiled and passed.
Scott Fan
On Thu, Feb 13, 2025 at 2:39 PM Roy Kollen Svendsen
<roykollensvendsen@gmail.com> wrote:
>
> Hi,
>
> Fixes:
> 2025-02-13T06:48:18 >>> sqlite 3.49.0 Configuring
> ...
> 2025-02-13T06:48:19 Error: Unknown option --target
>
> Tested-By: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
>
>
> tor. 13. feb. 2025 kl. 04:59 skrev Scott Fan <fancp2007@gmail.com>:
>>
>> Hi
>>
>> On Wed, Feb 12, 2025 at 11:47 PM Fiona Klute via buildroot
>> <buildroot@buildroot.org> wrote:
>> >
>> > Hi Scott, Baruch!
>> >
>> > Am 12.02.25 um 15:24 schrieb Baruch Siach via buildroot:
>> > > Hi Scott,
>> > >
>> > > On Wed, Feb 12 2025, Scott Fan wrote:
>> > >> As of release 3.49.0, the author has replaced the configure script used in
>> > >> the precompiled amalgamation tarball with Autosetup instead of Autotools.
>> > >>
>> > >> Fixes:
>> > >> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>> > >>
>> > >> Signed-off-by: Scott Fan <fancp2007@gmail.com>
>> >
>> > Together with the "host-generic-package" Baruch pointed out this fixed
>> > my build, thanks! One thing looks odd though, see below.
>>
>> I will add the missing configurations for the "host-generic-package".
>>
>> >
>> > Best regards,
>> > Fiona
>> >
>> > >> ---
>> > >> package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
>> > >> 1 file changed, 36 insertions(+), 23 deletions(-)
>> > >>
>> > >> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
>> > >> index a23f6e1d66..30385f9821 100644
>> > >> --- a/package/sqlite/sqlite.mk
>> > >> +++ b/package/sqlite/sqlite.mk
>> > >> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
>> > >> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
>> > >> endif
>> > >>
>> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
>> > >> -endif
>> > >> -
>> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
>> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
>> > >> -endif
>> > >> -
>> > >> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
>> > >> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
>> > >> endif
>> > >> @@ -50,30 +42,51 @@ else
>> > >> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
>> > >> endif
>> > >>
>> > >> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> > >> -
>> > >> -ifeq ($(BR2_STATIC_LIBS),y)
>> > >> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
>> > >> -else
>> > >> -SQLITE_CONF_OPTS += --disable-static-shell
>> > >> -endif
>> > >> -
>> > >> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>> > >> -SQLITE_CONF_OPTS += --enable-threadsafe
>> > >> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
>> > >> else
>> > >> SQLITE_CONF_OPTS += --disable-threadsafe
>> > >> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
>> > >> endif
>> >
>> > Why does --disable-threadsafe remain, while --enable-threadsafe is
>> > removed in the other branch, and -DSQLITE_THREADSAFE=0 removed while
>> > -DSQLITE_THREADSAFE=1 is added in the other branch? That seems
>> > inconsistent. My setup has BR2_TOOLCHAIN_HAS_THREADS=y, so I can only
>> > confirm the branch with threads works.
>>
>> When using the ./configure --help command in the release 3.49.0 to
>> view the usage, you can only see the --disable-threadsafe option, but
>> not the --enable-threadsafe option. Autosetup will automatically
>> detect whether threads are supported and set SQLITE_THREADSAFE to 1 or
>> 0. If threads are supported, SQLITE_THREADSAFE=1 is automatically set
>> by default, but you can force SQLITE_THREADSAFE=0 with the
>> --disable-threadsafe option.
>>
>> In my opinion, Autosetup has already done what it should do. I will
>> delete the lines related to thread safety options in the sqlite.mk
>> file.
>>
>>
>> >
>> > >> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
>> > >> SQLITE_DEPENDENCIES += ncurses readline
>> > >> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
>> > >> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
>> > >> SQLITE_DEPENDENCIES += libedit
>> > >> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
>> > >> +SQLITE_CONF_OPTS += --disable-readline --editline
>> > >> else
>> > >> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
>> > >> +SQLITE_CONF_OPTS += --disable-readline
>> > >> endif
>> > >>
>> > >> -$(eval $(autotools-package))
>> > >> -$(eval $(host-autotools-package))
>> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> > >> +SQLITE_CONF_OPTS += --fts3
>> > >> +endif
>> > >> +
>> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
>> > >> +SQLITE_CONF_OPTS += --disable-json
>> > >> +endif
>> > >> +
>> > >> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> > >> +
>> > >> +define SQLITE_CONFIGURE_CMDS
>> > >> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
>> > >> + --prefix=/usr \
>> > >> + --host="$(GNU_TARGET_NAME)" \
>> > >> + --build="$(GNU_HOST_NAME)" \
>> > >> + --sysroot="$(STAGING_DIR)" \
>> > >> + $(SQLITE_CONF_OPTS) \
>> > >> + )
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_BUILD_CMDS
>> > >> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_INSTALL_STAGING_CMDS
>> > >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_INSTALL_TARGET_CMDS
>> > >> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
>> > >> +endef
>> > >> +
>> > >> +$(eval $(generic-package))
>> > >
>> > > We also need host-generic-package to replace the host-autotools-package
>> > > removed above.
>> > >
>> > > baruch
>> > >
>> >
>> > _______________________________________________
>> > buildroot mailing list
>> > buildroot@buildroot.org
>> > https://lists.buildroot.org/mailman/listinfo/buildroot
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 8:19 ` Scott Fan
@ 2025-02-13 14:16 ` Scott Fan
0 siblings, 0 replies; 15+ messages in thread
From: Scott Fan @ 2025-02-13 14:16 UTC (permalink / raw)
To: Roy Kollen Svendsen; +Cc: Fiona Klute, Bernd Kuhls, Thomas Petazzoni, buildroot
Hi,
I also tested the following defconfig:
$ cat defconfig
BR2_x86_64=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_NFS_UTILS=y
Scott Fan
On Thu, Feb 13, 2025 at 4:19 PM Scott Fan <fancp2007@gmail.com> wrote:
>
> Hi,
>
> I had tested the patch v2 with the defconfig:
> $ cat defconfig
> BR2_aarch64=y
> BR2_TOOLCHAIN_BUILDROOT_CXX=y
> BR2_PACKAGE_NFS_UTILS=y
>
> Everything is OK. The "sqlite" and "host-sqlite" targets that the
> nfs_utils package depends on are both compiled and passed.
>
>
> Scott Fan
>
> On Thu, Feb 13, 2025 at 2:39 PM Roy Kollen Svendsen
> <roykollensvendsen@gmail.com> wrote:
> >
> > Hi,
> >
> > Fixes:
> > 2025-02-13T06:48:18 >>> sqlite 3.49.0 Configuring
> > ...
> > 2025-02-13T06:48:19 Error: Unknown option --target
> >
> > Tested-By: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
> >
> >
> > tor. 13. feb. 2025 kl. 04:59 skrev Scott Fan <fancp2007@gmail.com>:
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 4:50 ` [Buildroot] [PATCH v2] " Scott Fan
@ 2025-02-13 17:42 ` Fiona Klute via buildroot
2025-02-13 21:37 ` Julien Olivain
1 sibling, 0 replies; 15+ messages in thread
From: Fiona Klute via buildroot @ 2025-02-13 17:42 UTC (permalink / raw)
To: Scott Fan, buildroot; +Cc: Bernd Kuhls, Thomas Petazzoni
Am 13.02.25 um 05:50 schrieb Scott Fan:
> As of release 3.49.0, the author has replaced the configure script used in
> the precompiled amalgamation tarball with Autosetup instead of Autotools.
>
> The "autotools-package" and "host-autotools-package" lines are no longer
> available, so those have to be replaced by the "generic-package" and
> "host-generic-package" lines in the .mk file.
>
> The Autosetup configuration script does not support the
> "enable-dynamic-extensions" and "disable-static-shell" options,
> so the relevant lines in the .mk file are removed.
>
> The Autosetup configuration script can automatically detect whether
> threads are supported and set the relevant SQLITE_THREADSAFE flag,
> so the relevant lines in the .mk file are removed.
>
> Fixes:
> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
Tested-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
Target package works fine, thank you!
Fiona
> ---
> Changes v1 -> v2:
> - add the 'host-generic-package' configurations in the .mk file
> - remove the thread-safe related configurations in the .mk file
> - update commit message
> ---
> package/sqlite/sqlite.mk | 82 ++++++++++++++++++++++++++--------------
> 1 file changed, 54 insertions(+), 28 deletions(-)
>
> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> index a23f6e1d66..5a8b033ce0 100644
> --- a/package/sqlite/sqlite.mk
> +++ b/package/sqlite/sqlite.mk
> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
> SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
> endif
>
> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
> -endif
> -
> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
> -endif
> -
> ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
> SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
> endif
> @@ -50,30 +42,64 @@ else
> SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
> endif
>
> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> -
> -ifeq ($(BR2_STATIC_LIBS),y)
> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
> -else
> -SQLITE_CONF_OPTS += --disable-static-shell
> -endif
> -
> -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> -SQLITE_CONF_OPTS += --enable-threadsafe
> -else
> -SQLITE_CONF_OPTS += --disable-threadsafe
> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
> -endif
> -
> ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
> SQLITE_DEPENDENCIES += ncurses readline
> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
> else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> SQLITE_DEPENDENCIES += libedit
> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
> +SQLITE_CONF_OPTS += --disable-readline --editline
> else
> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
> +SQLITE_CONF_OPTS += --disable-readline
> endif
>
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
> +SQLITE_CONF_OPTS += --fts3
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
> +SQLITE_CONF_OPTS += --disable-json
> +endif
> +
> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
> +
> +define SQLITE_CONFIGURE_CMDS
> + (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
> + --prefix=/usr \
> + --host="$(GNU_TARGET_NAME)" \
> + --build="$(GNU_HOST_NAME)" \
> + --sysroot="$(STAGING_DIR)" \
> + $(SQLITE_CONF_OPTS) \
> + )
> +endef
> +
> +define SQLITE_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define SQLITE_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
> +endef
> +
> +define SQLITE_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
> +endef
> +
> +define HOST_SQLITE_CONFIGURE_CMDS
> + (cd $(@D); $(HOST_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
> + --prefix=/usr \
> + --host="$(GNU_HOST_NAME)" \
> + --build="$(GNU_HOST_NAME)" \
> + --sysroot="$(HOST_DIR)" \
> + $(SQLITE_CONF_OPTS) \
> + )
> +endef
> +
> +define HOST_SQLITE_BUILD_CMDS
> + $(HOST_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define HOST_SQLITE_INSTALL_CMDS
> + $(HOST_MAKE_ENV) $(MAKE) DESTDIR="$(HOST_DIR)" -C $(@D) install
> +endef
> +
> +$(eval $(generic-package))
> +$(eval $(host-generic-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 4:50 ` [Buildroot] [PATCH v2] " Scott Fan
2025-02-13 17:42 ` Fiona Klute via buildroot
@ 2025-02-13 21:37 ` Julien Olivain
2025-02-13 22:46 ` Waldemar Brodkorb
1 sibling, 1 reply; 15+ messages in thread
From: Julien Olivain @ 2025-02-13 21:37 UTC (permalink / raw)
To: Scott Fan; +Cc: buildroot, Bernd Kuhls, Thomas Petazzoni
On 13/02/2025 05:50, Scott Fan wrote:
> As of release 3.49.0, the author has replaced the configure script used
> in
> the precompiled amalgamation tarball with Autosetup instead of
> Autotools.
>
> The "autotools-package" and "host-autotools-package" lines are no
> longer
> available, so those have to be replaced by the "generic-package" and
> "host-generic-package" lines in the .mk file.
>
> The Autosetup configuration script does not support the
> "enable-dynamic-extensions" and "disable-static-shell" options,
> so the relevant lines in the .mk file are removed.
>
> The Autosetup configuration script can automatically detect whether
> threads are supported and set the relevant SQLITE_THREADSAFE flag,
> so the relevant lines in the .mk file are removed.
>
> Fixes:
> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 21:37 ` Julien Olivain
@ 2025-02-13 22:46 ` Waldemar Brodkorb
2025-02-14 2:23 ` Scott Fan
0 siblings, 1 reply; 15+ messages in thread
From: Waldemar Brodkorb @ 2025-02-13 22:46 UTC (permalink / raw)
To: Julien Olivain; +Cc: Scott Fan, buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Scott,
Julien Olivain wrote,
> On 13/02/2025 05:50, Scott Fan wrote:
> > As of release 3.49.0, the author has replaced the configure script used
> > in
> > the precompiled amalgamation tarball with Autosetup instead of
> > Autotools.
> >
> > The "autotools-package" and "host-autotools-package" lines are no longer
> > available, so those have to be replaced by the "generic-package" and
> > "host-generic-package" lines in the .mk file.
> >
> > The Autosetup configuration script does not support the
> > "enable-dynamic-extensions" and "disable-static-shell" options,
> > so the relevant lines in the .mk file are removed.
> >
> > The Autosetup configuration script can automatically detect whether
> > threads are supported and set the relevant SQLITE_THREADSAFE flag,
> > so the relevant lines in the .mk file are removed.
> >
> > Fixes:
> > https://autobuild.buildroot.org/?reason=sqlite-3.49.0
> >
> > Signed-off-by: Scott Fan <fancp2007@gmail.com>
>
> Applied to master, thanks.
On master I still get:
ERROR: Explicit --editline failed to find a matching library.
With BR2_PACKAGE_LIBEDIT=y instead of readline support.
Any idea? I am trying to build asterisk.
best regards
Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-13 22:46 ` Waldemar Brodkorb
@ 2025-02-14 2:23 ` Scott Fan
2025-02-14 3:44 ` Waldemar Brodkorb
0 siblings, 1 reply; 15+ messages in thread
From: Scott Fan @ 2025-02-14 2:23 UTC (permalink / raw)
To: Waldemar Brodkorb
Cc: Julien Olivain, buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Waldemar,
Thank you for your feedback.
I have sent a new patch to fix it, see the link below:
https://patchwork.ozlabs.org/project/buildroot/patch/20250214021416.392363-1-fancp2007@gmail.com/
Could you take a moment to test this patch for your work? thanks.
Scott Fan
On Fri, Feb 14, 2025 at 6:46 AM Waldemar Brodkorb <wbx@openadk.org> wrote:
>
> Hi Scott,
> Julien Olivain wrote,
>
> > On 13/02/2025 05:50, Scott Fan wrote:
> > > As of release 3.49.0, the author has replaced the configure script used
> > > in
> > > the precompiled amalgamation tarball with Autosetup instead of
> > > Autotools.
> > >
> > > The "autotools-package" and "host-autotools-package" lines are no longer
> > > available, so those have to be replaced by the "generic-package" and
> > > "host-generic-package" lines in the .mk file.
> > >
> > > The Autosetup configuration script does not support the
> > > "enable-dynamic-extensions" and "disable-static-shell" options,
> > > so the relevant lines in the .mk file are removed.
> > >
> > > The Autosetup configuration script can automatically detect whether
> > > threads are supported and set the relevant SQLITE_THREADSAFE flag,
> > > so the relevant lines in the .mk file are removed.
> > >
> > > Fixes:
> > > https://autobuild.buildroot.org/?reason=sqlite-3.49.0
> > >
> > > Signed-off-by: Scott Fan <fancp2007@gmail.com>
> >
> > Applied to master, thanks.
>
> On master I still get:
> ERROR: Explicit --editline failed to find a matching library.
>
> With BR2_PACKAGE_LIBEDIT=y instead of readline support.
>
> Any idea? I am trying to build asterisk.
>
> best regards
> Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-14 2:23 ` Scott Fan
@ 2025-02-14 3:44 ` Waldemar Brodkorb
2025-02-14 7:49 ` Scott Fan
0 siblings, 1 reply; 15+ messages in thread
From: Waldemar Brodkorb @ 2025-02-14 3:44 UTC (permalink / raw)
To: Scott Fan; +Cc: Julien Olivain, Bernd Kuhls, Thomas Petazzoni, buildroot
Hi Scott,
Scott Fan wrote,
> Hi Waldemar,
>
> Thank you for your feedback.
>
> I have sent a new patch to fix it, see the link below:
> https://patchwork.ozlabs.org/project/buildroot/patch/20250214021416.392363-1-fancp2007@gmail.com/
>
> Could you take a moment to test this patch for your work? thanks.
Thanks for the fast patch. But it now fails when compiling shell.c:
/home/wbx/buildroot/output/host/bin/aarch64-buildroot-linux-gnu-gcc -o sqlite3 \
shell.c sqlite3.c \
-I. -DSQLITE_ENABLE_MATH_FUNCTIONS -DSQLITE_OMIT_JSON -DSQLITE_THREADSAFE=1 -DHAVE_READLINE=1 -DSQLITE_HAVE_ZLIB=1 -DSQLITE_OMIT_READLINE_COMPLETION \
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g0 -D_FORTIFY_SOURCE=1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/wbx/buildroot/output/host/aarch64-buildroot-linux-gnu/sysroot/usr/include \
-Wl,-rpath,/usr/lib -lm -lz -ledit -lncurses
shell.c:151:11: fatal error: readline/readline.h: No such file or directory
151 | # include <readline/readline.h>
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
The configure command puts out:
NOTE: the local libedit but uses <readline/readline.h> so we
will compile with -DHAVE_READLINE=1 but will link with
libedit.
thanks for working on it.
best regards
Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
2025-02-14 3:44 ` Waldemar Brodkorb
@ 2025-02-14 7:49 ` Scott Fan
0 siblings, 0 replies; 15+ messages in thread
From: Scott Fan @ 2025-02-14 7:49 UTC (permalink / raw)
To: Waldemar Brodkorb
Cc: Julien Olivain, buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Waldemar,
I have sent a new patch (v2), see the link below:
https://patchwork.ozlabs.org/project/buildroot/patch/20250214074235.917242-1-fancp2007@gmail.com/
With this patch, I tested the following defconfig, it's ok.
$ cat defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_ASTERISK=y
Could you take a moment to test this patch for your work? thanks.
Scott Fan
On Fri, Feb 14, 2025 at 11:44 AM Waldemar Brodkorb <wbx@openadk.org> wrote:
>
> Hi Scott,
> Scott Fan wrote,
>
> > Hi Waldemar,
> >
> > Thank you for your feedback.
> >
> > I have sent a new patch to fix it, see the link below:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20250214021416.392363-1-fancp2007@gmail.com/
> >
> > Could you take a moment to test this patch for your work? thanks.
>
> Thanks for the fast patch. But it now fails when compiling shell.c:
> /home/wbx/buildroot/output/host/bin/aarch64-buildroot-linux-gnu-gcc -o sqlite3 \
> shell.c sqlite3.c \
> -I. -DSQLITE_ENABLE_MATH_FUNCTIONS -DSQLITE_OMIT_JSON -DSQLITE_THREADSAFE=1 -DHAVE_READLINE=1 -DSQLITE_HAVE_ZLIB=1 -DSQLITE_OMIT_READLINE_COMPLETION \
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g0 -D_FORTIFY_SOURCE=1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/wbx/buildroot/output/host/aarch64-buildroot-linux-gnu/sysroot/usr/include \
> -Wl,-rpath,/usr/lib -lm -lz -ledit -lncurses
> shell.c:151:11: fatal error: readline/readline.h: No such file or directory
> 151 | # include <readline/readline.h>
> | ^~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
>
> The configure command puts out:
> NOTE: the local libedit but uses <readline/readline.h> so we
> will compile with -DHAVE_READLINE=1 but will link with
> libedit.
>
> thanks for working on it.
>
> best regards
> Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
2025-02-12 13:50 [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0 Scott Fan
2025-02-12 14:24 ` Baruch Siach via buildroot
2025-02-13 4:50 ` [Buildroot] [PATCH v2] " Scott Fan
@ 2025-02-18 20:40 ` Julien Olivain
2 siblings, 0 replies; 15+ messages in thread
From: Julien Olivain @ 2025-02-18 20:40 UTC (permalink / raw)
To: Scott Fan; +Cc: buildroot, Bernd Kuhls, Thomas Petazzoni
Hi Scott,
On 12/02/2025 14:50, Scott Fan wrote:
> As of release 3.49.0, the author has replaced the configure script used
> in
> the precompiled amalgamation tarball with Autosetup instead of
> Autotools.
>
> Fixes:
> https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
This sqlite bump still generates runtime errors. See for example:
https://gitlab.com/buildroot.org/buildroot/-/jobs/9153298472
For info, you can run this test with the command:
utils/docker-run support/testing/run-tests \
-k -d dl -o output_folder \
tests.package.test_proj
Could you have a look please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2025-02-18 20:40 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-12 13:50 [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0 Scott Fan
2025-02-12 14:24 ` Baruch Siach via buildroot
2025-02-12 15:47 ` Fiona Klute via buildroot
2025-02-13 3:59 ` Scott Fan
2025-02-13 6:39 ` Roy Kollen Svendsen
2025-02-13 8:19 ` Scott Fan
2025-02-13 14:16 ` Scott Fan
2025-02-13 4:50 ` [Buildroot] [PATCH v2] " Scott Fan
2025-02-13 17:42 ` Fiona Klute via buildroot
2025-02-13 21:37 ` Julien Olivain
2025-02-13 22:46 ` Waldemar Brodkorb
2025-02-14 2:23 ` Scott Fan
2025-02-14 3:44 ` Waldemar Brodkorb
2025-02-14 7:49 ` Scott Fan
2025-02-18 20:40 ` [Buildroot] [PATCH] " Julien Olivain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.