All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed

From: Yang Jihong <yangjihong@bytedance.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, james.clark@arm.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH v2 2/2] perf evsel: Use evsel__name_is() helper
Date: Wed, 3 Apr 2024 15:45:12 +0800	[thread overview]
Message-ID: <20fd87a5-7c9b-458f-9f77-3235185db7f4@bytedance.com> (raw)
In-Reply-To: <ZgxzmkCGNXLipMVg@x1>

Hello,

On 4/3/24 05:07, Arnaldo Carvalho de Melo wrote:
> On Mon, Apr 01, 2024 at 02:27:24PM +0800, Yang Jihong wrote:
>> Code cleanup, replace strcmp(evsel__name(evsel, {NAME})) with
>> evsel__name_is() helper.
>>
>> No functional change.
> 
> Well, its not building:
> 
> builtin-trace.c: In function ‘cmd_trace’:
> builtin-trace.c:4919:90: error: macro "assert" passed 2 arguments, but takes just 1
>   4919 |         assert(evsel__name_is(trace.syscalls.events.bpf_output), "__augmented_syscalls__");
>        |                                                                                          ^
> In file included from /home/acme/git/perf-tools-next/tools/include/linux/kernel.h:7,
>                   from /home/acme/git/perf-tools-next/tools/include/linux/refcount.h:42,
>                   from util/cgroup.h:6,
>                   from builtin-trace.c:29:
> /usr/include/assert.h:50: note: macro "assert" defined here
> 
> I'll fix it, but please test build things next time.

Sorry. I compiled it in a new environment before. This environment does 
not support bpf skel, and the modified part of the code is included in 
HAVE_BPF_SKEL, so I did not find this problem when I compiled it in my 
environment.


Thanks for the correction. will confirm whether the modified code is 
actually compiled next time.


Thanks,
Yang

     prev parent reply	other threads:[~2024-04-03  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01  6:27 [PATCH v2 0/2] perf sched time -g/--call-graph option & perf Yang Jihong
2024-04-01  6:27 ` [PATCH v2 1/2] perf sched timehist: Fix -g/--call-graph option failure Yang Jihong
2024-04-01  6:27 ` [PATCH v2 2/2] perf evsel: Use evsel__name_is() helper Yang Jihong
2024-04-02 21:07   ` Arnaldo Carvalho de Melo
2024-04-02 21:10     ` Arnaldo Carvalho de Melo
2024-04-03  7:45     ` Yang Jihong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20fd87a5-7c9b-458f-9f77-3235185db7f4@bytedance.com \
    --to=yangjihong@bytedance.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.