From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/5] drm/omap: fix omap_gem_put_paddr() error handling Date: Thu, 18 Jun 2015 18:14:31 +0300 Message-ID: <2112018.EZgbtSlrso@avalon> References: <1434622239-15629-1-git-send-email-tomi.valkeinen@ti.com> <1434622239-15629-6-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTP id B8B2A6ED3E for ; Thu, 18 Jun 2015 08:13:42 -0700 (PDT) In-Reply-To: <1434622239-15629-6-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVGh1cnNkYXkgMTggSnVuZSAy MDE1IDEzOjEwOjM5IFRvbWkgVmFsa2VpbmVuIHdyb3RlOgo+IElmIHRpbGVyX3VucGluKCkgY2Fs bCBpbiBvbWFwX2dlbV9wdXRfcGFkZHIoKSBmYWlscywKPiBvbWFwX2dlbV9wdXRfcGFkZHIoKSB3 aWxsIGltbWVkaWF0ZWx5IHN0b3AgcHJvY2Vzc2luZyBhbmQgcmV0dXJuIGFuCj4gZXJyb3IuCj4g Cj4gVGhpcyBwYXRjaCByZW1vZXMgdGhhdCBlcnJvciBjaGVja2luZywgYW5kIGFsc28gcmVtb3Zl cwo+IG9tYXBfZ2VtX3B1dF9wYWRkcigpJ3MgcmV0dXJuIHZhbHVlLCBiZWNhdXNlOgo+IAo+ICAq IFRoZSBjYWxsZXIgb2Ygb21hcF9nZW1fcHV0X3BhZGRyKCkgY2FuIGRvIG5vdGhpbmcgaWYgYW4g ZXJyb3IKPiAgICBoYXBwZW5zLCBzbyBpdCdzIHBvaW50bGVzcyB0byByZXR1cm4gYW4gZXJyb3Ig dmFsdWUKPiAKPiAgKiBJZiB0aWxlcl91bnBpbigpIGZhaWxzLCB0aGUgR0VNIG9iamVjdCB3aWxs IHBvc3NpYmx5IGJlIGxlZnQgaW4gYW4KPiAgICB1bmRlZmluZWQgc3RhdGUsIHdoZXJlIHRoZSBE TU0gbWFwcGluZyBtYXkgaGF2ZSBiZWVuIHJlbW92ZWQsIGJ1dCB0aGUKPiAgICBHRU0gb2JqZWN0 IHN0aWxsIHRoaW5rcyBldmVyeXRoaW5nIGlzIGFzIGl0IHNob3VsZCBiZSwgbGVhZGluZyB0bwo+ ICAgIGNyYXNoZXMgbGF0ZXIuCj4gCj4gICogVGhlcmUncyBubyBwb2ludCBpbiByZXR1cm5pbmcg YW4gZXJyb3IgZnJvbSBhICJmcmVlIiBjYWxsLCBhcyB0aGUKPiAgICBjYWxsZXIgY2FuIGRvIG5v dGhpbmcgYWJvdXQgaXQuIFNvIGl0J3MgYmV0dGVyIHRvIGNsZWFuIHVwIGFzIG11Y2ggYXMKPiAg ICBwb3NzaWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxr ZWluZW5AdGkuY29tPgoKQWNrZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t YXBfZHJ2LmggfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZ2VtLmMgfCA4 ICsrKy0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5o Cj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5oIGluZGV4IDJlZjg5YzBjMzAw Ni4uMWFlODQ3N2U0Mjg5Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmgKPiBA QCAtMjExLDcgKzIxMSw3IEBAIHZvaWQgb21hcF9nZW1fZG1hX3N5bmMoc3RydWN0IGRybV9nZW1f b2JqZWN0ICpvYmosCj4gIAkJZW51bSBkbWFfZGF0YV9kaXJlY3Rpb24gZGlyKTsKPiAgaW50IG9t YXBfZ2VtX2dldF9wYWRkcihzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwKPiAgCQlkbWFfYWRk cl90ICpwYWRkciwgYm9vbCByZW1hcCk7Cj4gLWludCBvbWFwX2dlbV9wdXRfcGFkZHIoc3RydWN0 IGRybV9nZW1fb2JqZWN0ICpvYmopOwo+ICt2b2lkIG9tYXBfZ2VtX3B1dF9wYWRkcihzdHJ1Y3Qg ZHJtX2dlbV9vYmplY3QgKm9iaik7Cj4gIGludCBvbWFwX2dlbV9nZXRfcGFnZXMoc3RydWN0IGRy bV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCBwYWdlICoqKnBhZ2VzLAo+ICAJCWJvb2wgcmVtYXAp Owo+ICBpbnQgb21hcF9nZW1fcHV0X3BhZ2VzKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9nZW0uYwo+IGIvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9nZW0uYyBpbmRleCA1MWM1NjM1YWZmNjIuLmQwMWQ0 MDI0NTI5OAo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZ2Vt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2dlbS5jCj4gQEAgLTgwOCwx MCArODA4LDEwIEBAIGZhaWw6Cj4gIC8qIFJlbGVhc2UgcGh5c2ljYWwgYWRkcmVzcywgd2hlbiBE TUEgaXMgbm8gbG9uZ2VyIGJlaW5nIHBlcmZvcm1lZC4uIHRoaXMKPiAgICogY291bGQgcG90ZW50 aWFsbHkgdW5waW4gYW5kIHVubWFwIGJ1ZmZlcnMgZnJvbSBUSUxFUgo+ICAgKi8KPiAtaW50IG9t YXBfZ2VtX3B1dF9wYWRkcihzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikKPiArdm9pZCBvbWFw X2dlbV9wdXRfcGFkZHIoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmopCj4gIHsKPiAgCXN0cnVj dCBvbWFwX2dlbV9vYmplY3QgKm9tYXBfb2JqID0gdG9fb21hcF9ibyhvYmopOwo+IC0JaW50IHJl dCA9IDA7Cj4gKwlpbnQgcmV0Owo+IAo+ICAJbXV0ZXhfbG9jaygmb2JqLT5kZXYtPnN0cnVjdF9t dXRleCk7Cj4gIAlpZiAob21hcF9vYmotPnBhZGRyX2NudCA+IDApIHsKPiBAQCAtODIxLDcgKzgy MSw2IEBAIGludCBvbWFwX2dlbV9wdXRfcGFkZHIoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmop Cj4gIAkJCWlmIChyZXQpIHsKPiAgCQkJCWRldl9lcnIob2JqLT5kZXYtPmRldiwKPiAgCQkJCQki Y291bGQgbm90IHVucGluIHBhZ2VzOiAlZFxuIiwgcmV0KTsKPiAtCQkJCWdvdG8gZmFpbDsKPiAg CQkJfQo+ICAJCQlyZXQgPSB0aWxlcl9yZWxlYXNlKG9tYXBfb2JqLT5ibG9jayk7Cj4gIAkJCWlm IChyZXQpIHsKPiBAQCAtODMyLDkgKzgzMSw4IEBAIGludCBvbWFwX2dlbV9wdXRfcGFkZHIoc3Ry dWN0IGRybV9nZW1fb2JqZWN0ICpvYmopCj4gIAkJCW9tYXBfb2JqLT5ibG9jayA9IE5VTEw7Cj4g IAkJfQo+ICAJfQo+IC1mYWlsOgo+ICsKPiAgCW11dGV4X3VubG9jaygmb2JqLT5kZXYtPnN0cnVj dF9tdXRleCk7Cj4gLQlyZXR1cm4gcmV0Owo+ICB9Cj4gCj4gIC8qIEdldCByb3RhdGVkIHNjYW5v dXQgYWRkcmVzcyAob25seSB2YWxpZCBpZiBhbHJlYWR5IHBpbm5lZCksIGF0IHRoZQoKLS0gClJl Z2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=