From: Julia Lawall <julia.lawall@inria.fr>
To: Samin Guo <samin.guo@starfivetech.com>,
Hal Feng <hal.feng@starfivetech.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min() (fwd)
Date: Wed, 17 Apr 2024 14:34:27 +0200 (CEST) [thread overview]
Message-ID: <2119db14-c2a-9bd3-eae8-4faa5219dbc3@inria.fr> (raw)
---------- Forwarded message ----------
Date: Wed, 17 Apr 2024 20:21:23 +0800
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min()
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Samin Guo <samin.guo@starfivetech.com>
CC: Hal Feng <hal.feng@starfivetech.com>
CC: Andrew Lunn <andrew@lunn.ch>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 96fca68c4fbf77a8185eb10f7557e23352732ea2
commit: 7a561e9351ae7e3fb1f08584d40b49c1e55dde60 net: phy: motorcomm: Add pad drive strength cfg support
date: 9 months ago
:::::: branch date: 2 days ago
:::::: commit date: 9 months ago
config: i386-randconfig-053-20240417 (https://download.01.org/0day-ci/archive/20240417/202404172059.wU4sM9Qi-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202404172059.wU4sM9Qi-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/phy/motorcomm.c:885:12-14: WARNING opportunity for min()
vim +885 drivers/net/phy/motorcomm.c
7a561e9351ae7e3 Samin Guo 2023-07-20 877
7a561e9351ae7e3 Samin Guo 2023-07-20 878 static u32 yt8531_get_ldo_vol(struct phy_device *phydev)
7a561e9351ae7e3 Samin Guo 2023-07-20 879 {
7a561e9351ae7e3 Samin Guo 2023-07-20 880 u32 val;
7a561e9351ae7e3 Samin Guo 2023-07-20 881
7a561e9351ae7e3 Samin Guo 2023-07-20 882 val = ytphy_read_ext_with_lock(phydev, YT8521_CHIP_CONFIG_REG);
7a561e9351ae7e3 Samin Guo 2023-07-20 883 val = FIELD_GET(YT8531_RGMII_LDO_VOL_MASK, val);
7a561e9351ae7e3 Samin Guo 2023-07-20 884
7a561e9351ae7e3 Samin Guo 2023-07-20 @885 return val <= YT8531_LDO_VOL_1V8 ? val : YT8531_LDO_VOL_1V8;
7a561e9351ae7e3 Samin Guo 2023-07-20 886 }
7a561e9351ae7e3 Samin Guo 2023-07-20 887
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-04-17 12:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2119db14-c2a-9bd3-eae8-4faa5219dbc3@inria.fr \
--to=julia.lawall@inria.fr \
--cc=andrew@lunn.ch \
--cc=hal.feng@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=samin.guo@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.