* [PATCH] ACPI / scan: fix fixed event handler return value
@ 2015-03-13 5:52 Aaron Lu
2015-03-18 15:27 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lu @ 2015-03-13 5:52 UTC (permalink / raw
To: Rafael J. Wysocki; +Cc: Lv Zheng, linux-acpi
The fixed event handler should return a value that is either 0 or 1
meanning if the event is handled or not, instead of an acpi_status to
mean if the handler runs well or not.
Suggested-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
drivers/acpi/scan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index bbca7830e18a..3e5a2768c3b4 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1062,10 +1062,10 @@ static void acpi_device_notify_fixed(void *data)
acpi_device_notify(NULL, ACPI_FIXED_HARDWARE_EVENT, device);
}
-static acpi_status acpi_device_fixed_event(void *data)
+static u32 acpi_device_fixed_event(void *data)
{
acpi_os_execute(OSL_NOTIFY_HANDLER, acpi_device_notify_fixed, data);
- return AE_OK;
+ return ACPI_INTERRUPT_HANDLED;
}
static int acpi_device_install_notify_handler(struct acpi_device *device)
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI / scan: fix fixed event handler return value
2015-03-13 5:52 [PATCH] ACPI / scan: fix fixed event handler return value Aaron Lu
@ 2015-03-18 15:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-03-18 15:27 UTC (permalink / raw
To: Aaron Lu; +Cc: Lv Zheng, linux-acpi
On Friday, March 13, 2015 01:52:50 PM Aaron Lu wrote:
> The fixed event handler should return a value that is either 0 or 1
> meanning if the event is handled or not, instead of an acpi_status to
> mean if the handler runs well or not.
>
> Suggested-by: Lv Zheng <lv.zheng@intel.com>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Queued up for 4.1, thanks!
> ---
> drivers/acpi/scan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index bbca7830e18a..3e5a2768c3b4 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -1062,10 +1062,10 @@ static void acpi_device_notify_fixed(void *data)
> acpi_device_notify(NULL, ACPI_FIXED_HARDWARE_EVENT, device);
> }
>
> -static acpi_status acpi_device_fixed_event(void *data)
> +static u32 acpi_device_fixed_event(void *data)
> {
> acpi_os_execute(OSL_NOTIFY_HANDLER, acpi_device_notify_fixed, data);
> - return AE_OK;
> + return ACPI_INTERRUPT_HANDLED;
> }
>
> static int acpi_device_install_notify_handler(struct acpi_device *device)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-18 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 5:52 [PATCH] ACPI / scan: fix fixed event handler return value Aaron Lu
2015-03-18 15:27 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.