From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v16 0/6] User-space Ethtool Date: Wed, 15 Jul 2015 12:30:59 +0200 Message-ID: <2157868.FlQ157duik@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <10500550.BxuzPEpZpz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 6AE5E5A43 for ; Wed, 15 Jul 2015 12:32:12 +0200 (CEST) Received: by wiga1 with SMTP id a1so124691316wig.0 for ; Wed, 15 Jul 2015 03:32:12 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-15 10:15, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-14 20:56, Wang, Liang-min: > > > Thomas, > > > The mac_addr_set is needed for ethtool net-op as described in > > > examples/ethtool-ethtool/lib/rte_ethtool.c > > (rte_ethtool_net_set/get_mac_addr). > > > > That's why it should be the first patch of this series. > > You probably misread "another patch" which means different patch in same > > series. > > > That's why this API and rest of API's added into librte_ether are all prepared in the same patch: 001. > I'm confused on your comment here. Are you asking me to break the patch 001 into two patches in the same series? > Meaning 001 and 002, would that be more confusing? Yes exactly. 001: mac_addr_set 002: reg/eeprom Thanks