From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v5] OSSTEST: introduce a raisin build test
Date: Tue, 12 May 2015 18:36:21 +0100
Message-ID: <21842.14869.478809.933823@mariner.uk.xensource.com>
References: <1431450790-28686-1-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1431450790-28686-1-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini writes ("[PATCH v5] OSSTEST: introduce a raisin build test"):
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
...
> +    echo >>config XEN_URL=\\"$r{tree_xen}\\"
> +    echo >>config XEN_REVISION=\\"$r{revision_xen}\\"

This is very repetitive.  In ts-xen-build, the names of the variables
are irregular, but here they are regular.  I think you should refactor
this accordingly.

I don't understand what the \\ are doing here.  Perhaps you should use
'' like in ts-xen-build ?

> +sub divide () {
> +    # Only move hv to xeninstall, so that we can have
> +    # xenpolicy in tools tarball.
> +    #
> +    # The files inside boot/ after `make dist' are
> +    # xen-$XEN_VERSION: Xen binary
> +    # xen.gz/xen: symlink to xen-$XEN_VERSION
> +    # xen-$MAJOR: symlink to xen-$XEN_VERSION
> +    # xen-$MAJOR.$MINOR: symlink to xen-$XEN_VERSION
> +    # xen-sym-$XEN_VERSION: Xen symbol
> +    # xenpolicy-$XEN_VERSION: flask policy binary if xsm is enabled
> +    #
> +    # So the following snippet will leave xenpolicy* in
> +    # install/boot and get packaged to tools tarball.
> +    target_cmd_build($ho, 100, $builddir, <<END);
> +        cd raisin
> +        mkdir xendist
> +        for f in *dist; do
> +            mkdir -p \$f/lib
> +        done
> +        if test -d dist/boot; then
> +            if test -f dist/boot/xen.gz || test -f dist/boot/xen; then
> +                mkdir xendist/boot
> +                mvfiles=`find dist/boot -name 'xen[a-z]*' -prune -o -name 'xen*' -print`
> +                mv \$mvfiles xendist/boot/.

This, and much of stash(), is a clone-and-hack of ts-xen-build.

> +our @probs;
> +
> +sub trapping ($) {
> +    my ($sub) = @_;
> +    my $tok= eval { $sub->(); 1; };
> +    if (!$tok) { push @probs, $@; print STDERR "failure (trapped): $@\n"; }
> +}

Again, this is copied from ts-xen-build.

Ian.