From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v5] OSSTEST: introduce a raisin build test
Date: Wed, 13 May 2015 17:15:00 +0100 [thread overview]
Message-ID: <21843.30852.550437.285711@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1505121851170.20496@kaball.uk.xensource.com>
Stefano Stabellini writes ("Re: [PATCH v5] OSSTEST: introduce a raisin build test"):
> On Tue, 12 May 2015, Ian Jackson wrote:
> > I don't understand what the \\ are doing here. Perhaps you should use
> > '' like in ts-xen-build ?
>
> I need to retain the " in the output
raisin doesn't cope with '' in the config file ?
> > This is very repetitive. In ts-xen-build, the names of the variables
> > are irregular, but here they are regular. I think you should refactor
> > this accordingly.
>
> I think that the cure here would be worse than the disease. In bash
> would be fragile and difficult to read, but you probably would do it in
> perl, right? In that case I don't know how it would look like; in fact I
> wouldn't know how to write it. However if you are keen on it, feel free
> to provide a snippet of code and I'll try to include it in the patch.
Yes, it should be done in perl. Something like:
foreach my $treename (qw(xen seabios blah blah)) {
$buildcmd .= <<END;
echo >>config \U$treename\E_URL='$r{"tree_$treename"}'
echo >>config \U$treename\E_REVISION='$r{"revision_$treename"}'
END
}
(Untested; adjust to taste.)
> > Again, this is copied from ts-xen-build.
>
> Yes, it is. If this is not a descriptive comment, what would you have me
> do? I could move trapping somewhere else common, but I don't think that
> generalizing divide and stash is a good idea.
divide should be moved into BuildSupport, probably. There, it would
need a slightly longer name, and perhaps to take some more of its
variables as parameters.
It doesn't need to be "generalised", since you want it basically
as-is.
Ian.
next prev parent reply other threads:[~2015-05-13 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:13 [PATCH v5] OSSTEST: introduce a raisin build test Stefano Stabellini
2015-05-12 17:36 ` Ian Jackson
2015-05-12 18:04 ` Stefano Stabellini
2015-05-13 9:02 ` Ian Campbell
2015-05-13 16:15 ` Ian Jackson [this message]
2015-06-17 15:12 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21843.30852.550437.285711@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.