From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V4 1/7] libxl: export some functions for
 pvusb use
Date: Fri, 12 Jun 2015 16:14:07 +0100
Message-ID: <21882.63295.696541.742839@mariner.uk.xensource.com>
References: <1433906441-3280-1-git-send-email-cyliu@suse.com>
	<1433906441-3280-2-git-send-email-cyliu@suse.com>
	<21881.45721.649328.6336@mariner.uk.xensource.com>
	<20150611162839.GL14606@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150611162839.GL14606@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: george.dunlap@eu.citrix.com, ian.campbell@citrix.com, Simon Cao <caobosimon@gmail.com>, Chunyan Liu <cyliu@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [Xen-devel] [PATCH V4 1/7] libxl: export some functions for pvusb use"):
> On Thu, Jun 11, 2015 at 05:08:57PM +0100, Ian Jackson wrote:
> > Functions in libxl with external linkage should have the appropriate
> > namespacing (ie, their names must start with libxl__).
> > 
> > So, I'm afraid, contrary to Wei's opinion:
> > 
> > Nacked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> 
> I think if Chunyan moves that function to libxl__ namespace this patch
> should be fine, right?

Yes.

Thanks,
Ian.