From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST v3 02/11]
	mg-debian-installer-update: updates to better handle Jessie onwards.
Date: Fri, 19 Jun 2015 13:33:55 +0100
Message-ID: <21892.3123.703042.841463@mariner.uk.xensource.com>
References: <1434546404-2036-1-git-send-email-wei.liu2@citrix.com>
	<1434546404-2036-3-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6059487fc=Ian.Jackson@citrix.com>)
	id 1Z5vV8-00058A-Fh
	for xen-devel@lists.xenproject.org; Fri, 19 Jun 2015 12:34:30 +0000
In-Reply-To: <1434546404-2036-3-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("[PATCH OSSTEST v3 02/11] mg-debian-installer-update: updates to better handle Jessie onwards."):
> From: Ian Campbell <ian.campbell@citrix.com>
> 
> In mg-debian-installer-update:
> 
>   - Expand the list of (suite,arch) combinations which don't exist and
>     move it to the top.
...
> -    # Newer kernel often needs a newer initramfs-tools. Make that available
> -    echo >&2 "collecting backports initramfs-tools"
> -    pkgfile=`zcat Packages.gz | grep-dctrl -PX initramfs-tools -nsFilename | sort -n -r | head -n1`
> -    rc=$?
> -    set -e
> -    if [ $rc != 0 ]; then fail "initramfs-tools package not found"; fi
> -    fetch "$site/$pkgfile" >initramfs-tools.deb
> +    if [ x$need_initramfs = xy ]; then
> +        # Newer kernel often needs a newer initramfs-tools. Make that
> +        # available
> +        echo >&2 "collecting backports initramfs-tools"
> +        pkgfile=`zcat Packages.gz \
> +                 | grep-dctrl -PX initramfs-tools -nsFilename \
> +                 | sort -n -r | head -n1`

That looks much like this:

> -    pkgfile=`zcat Packages.gz | grep-dctrl -S linux | grep-dctrl -Pe ^linux-image-.*-armmp$ -nsFilename | sort -n -r | head -n1`
> +    pkgfile=`zcat Packages.gz | grep-dctrl -S linux \
> +             | grep-dctrl -Pe ^linux-image-.*-${bpok}$ -nsFilename \
> +             | sort -n -r | head -n1`

But since it was duplicated before I won't ask you to break it out.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>