From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [v7][PATCH 16/16] tools: parse to enable new rdm
	policy parameters
Date: Thu, 9 Jul 2015 19:23:59 +0100
Message-ID: <21918.48191.157583.452591@mariner.uk.xensource.com>
References: <1436420047-25356-1-git-send-email-tiejun.chen@intel.com>
	<1436420047-25356-17-git-send-email-tiejun.chen@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436420047-25356-17-git-send-email-tiejun.chen@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Tiejun Chen writes ("[v7][PATCH 16/16] tools: parse to enable new rdm policy parameters"):
> This patch parses to enable user configurable parameters to specify
> RDM resource and according policies,
> 
> Global RDM parameter:
>     rdm = "strategy=host,policy=strict/relaxed"
> Per-device RDM parameter:
>     pci = [ 'sbdf, rdm_policy=strict/relaxed' ]
> 
> Default per-device RDM policy is same as default global RDM policy as being
> 'relaxed'. And the per-device policy would override the global policy like
> others.

Thanks for this.  I have found a couple of things in this patch which
I would like to see improved.  See below.

Again, given how late I am, I do not feel that I should be nacking it
at this time.  You have a tools ack from Wei, so my comments are not a
blocker for this series.

But if you need to respin, please take these comments into account,
and consider which are feasible to fix in the time available.  If you
are respinning this series targeting Xen 4.7 or later, please address
all of the points I make below.

Thanks.


The first issue (which would really be relevant to the documentation
patch) is that the documentation is in a separate commit.  There are
sometimes valid reasons for doing this.  I'm not sure if they apply,
but if they do this should be explained in one of the commit
messages.  If this was done I'm afraid I have missed it.

> +                }else if ( !strcmp(optkey, "rdm_policy") ) {
> +                    if ( !strcmp(tok, "strict") ) {
> +                        pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_STRICT;
> +                    } else if ( !strcmp(tok, "relaxed") ) {
> +                        pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_RELAXED;
> +                    } else {
> +                        XLU__PCI_ERR(cfg, "%s is not an valid PCI RDM property"
> +                                          " policy: 'strict' or 'relaxed'.",
> +                                     tok);
> +                        goto parse_error;
> +                    }

This section has coding style (whitespace) problems and long lines.
If you need to respin, please fix them.

> +    for (tok = ptr, end = ptr + strlen(ptr) + 1; ptr < end; ptr++) {
> +        switch(state) {
> +        case STATE_TYPE:
> +            if (*ptr == '=') {
> +                state = STATE_RDM_STRATEGY;
> +                *ptr = '\0';
> +                if (strcmp(tok, "strategy")) {
> +                    XLU__PCI_ERR(cfg, "Unknown RDM state option: %s", tok);
> +                    goto parse_error;
> +                }
> +                tok = ptr + 1;
> +            }

This code is extremely repetitive.

Really I would prefer that this parsing was done with a miniature flex
parser, rather than ad-hoc pointer arithmetic and use of strtok.

Thanks,
Ian.