From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v3 17/28] tools/libxl: Infrastructure for
 reading a libxl migration v2 stream
Date: Mon, 13 Jul 2015 15:03:45 +0100
Message-ID: <21923.50497.123783.955687@mariner.uk.xensource.com>
References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com>
	<1436788907-1921-18-git-send-email-andrew.cooper3@citrix.com>
	<1436794934.25044.9.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436794934.25044.9.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [PATCH v3 17/28] tools/libxl: Infrastructure for reading a libxl migration v2 stream"):
> On Mon, 2015-07-13 at 13:01 +0100, Andrew Cooper wrote:
> 
> > +void libxl__stream_read_start(libxl__egc *egc,
> > +                              libxl__stream_read_state *stream)
> > +{
> > +    libxl__datacopier_state *dc = &stream->dc;
> > +    int rc = 0;
> > +
> > +    stream->running = true;
> 
> Did you drop the assert prior to this on purpose?

This was at my provocation, I think.

Ian.