From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v3 07/28] tools/libxl: Extra management APIs
	for the save helper
Date: Mon, 13 Jul 2015 16:01:33 +0100
Message-ID: <21923.53965.412759.259488@mariner.uk.xensource.com>
References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com>
	<1436788907-1921-8-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436788907-1921-8-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Andrew Cooper writes ("[PATCH v3 07/28] tools/libxl: Extra management APIs for the save helper"):
> With migration v2, there are several moving parts needing to be
> juggled at once.  This requires the error handling logic to be able to
> query the state of each moving part, possibly before they have been
> started, and be able to cancel them.

I have no objection to the introduction of libxl__save_helper_init and
_inuse.

But:

Contrary to usual practice, the two entrypoints
libxl__xc_domain_restore and _save require _init to be called first.

This needs to be left the way it was, or documented.


Thanks,
Ian.