From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v3 20/28] tools/libxc+libxl+xl: Restore v2 streams Date: Mon, 13 Jul 2015 16:02:59 +0100 Message-ID: <21923.54051.402304.738071@mariner.uk.xensource.com> References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com> <1436788907-1921-21-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436788907-1921-21-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org Andrew Cooper writes ("[PATCH v3 20/28] tools/libxc+libxl+xl: Restore v2 streams"): > This is a complicated set of changes which must be done together for > bisectability. > > * libxl-save-helper is updated to unconditionally use libxc migration > v2. > * libxl compatibility workarounds in libxc are disabled for restore > operations. > * libxl__stream_read_start() is logically spliced into the event > location where libxl__xc_domain_restore() used to reside. > * Ownership of the save_helper_state moves to stream_read_state. > > The parameters 'hvm', 'pae', and 'superpages' were previously > superfluous, and are completely unused in migration > v2. callbacks->toolstack_restore is handled via a migration v2 record > now, rather than via a callback from libxc. > > NB: this change breaks Remus. Further untangling needs to happen > before Remus will function. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu Acked-by: Ian Jackson