From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v3 21/28] tools/libxl: Infrastructure for
	writing a v2 stream
Date: Mon, 13 Jul 2015 16:21:42 +0100
Message-ID: <21923.55174.537923.565239@mariner.uk.xensource.com>
References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com>
	<1436788907-1921-22-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436788907-1921-22-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Andrew Cooper writes ("[PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream"):
...
> +void libxl__stream_write_start(libxl__egc *egc,
> +                               libxl__stream_write_state *stream)
> +{
> +    libxl__datacopier_state *dc = &stream->dc;
> +    STATE_AO_GC(stream->ao);
> +    struct libxl__sr_hdr hdr = { 0 };
...
> +    libxl__datacopier_prefixdata(egc, dc, &hdr, sizeof(hdr));

Sadly this pattern is not correct.  I don't think this initialisation
ensures that the memory in hdr is all-bits-0.  So you may leak
arbitrary data from the toolstack process stack into the migration or
save stream.

I think you need to use FILLZERO.

> +    struct libxl__sr_rec_hdr rec = { REC_TYPE_LIBXC_CONTEXT };
...
> +    setup_write(egc, stream, "libxc header",
> +                &rec, NULL, libxc_header_done);

Same again.

(I haven't searched thoroughly for these.)


> +/*----- Success/error/cleanup handling. -----*/

As with read, I would prefer these to be unified into one
stream_complete function.

> +    /* Don't fire the callback until all our parallel tasks have stopped. */
> +    if (!libxl__stream_write_inuse(stream) &&
> +        !libxl__save_helper_inuse(&dss->shs))
> +        stream->completion_callback(egc, stream, stream->rc);

My stylistic comment about the sense of the if applies here.  But as I
say it's a matter of taste.

Ian.