From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FC3C433DB for ; Mon, 11 Jan 2021 20:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE38D22CB1 for ; Mon, 11 Jan 2021 20:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403861AbhAKUJA (ORCPT ); Mon, 11 Jan 2021 15:09:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391513AbhAKUIx (ORCPT ); Mon, 11 Jan 2021 15:08:53 -0500 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B55C061794 for ; Mon, 11 Jan 2021 12:08:12 -0800 (PST) Received: by mail-qk1-x72e.google.com with SMTP id p14so6616qke.6 for ; Mon, 11 Jan 2021 12:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FHth/aaRGXw8bPkksN5hjPH+DYHe+92fn3EKoOPKveU=; b=xSKSRey0zDYxR9bJ7/hLqOBHXUc9MMX6Fkw6qu1x8skDncTMF78XOi1DpZ8ODOBDFY d9MwZXZ54AUoqB3Od0Q0Rj5vtrB86BQ8hrPzGc0bcfQ12izILc7cOxJ0xTXw2XPsXE1C DeAiElQ9+y2KeHsgZBdKDoJIjsEdFWH9EqDCj5O0Cd0KEg9MYI5bPUg4U4HINubTMDQ2 PSMfy269yHRn12ac5ISOsmbcC+p9ocWk7T/S4YhFxKSkk0mn/SOta9Ih6hseyLmwbiEV H1UHa9QrKyC5s6R9j7vTIQmHbTMP9322xXbsgV003Sh2Bhb02hoUbbTw1QDkgEacYpqt C4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FHth/aaRGXw8bPkksN5hjPH+DYHe+92fn3EKoOPKveU=; b=XX9sL3FQo8M5DP2MfxlqpKe7mAXk0NPueTIBLneStNkKV+j8du7PUuCRWaj/vzibhJ ENOJMnQXFnKBIgEWqiJ/2pyEXnKonMcI5fm1c1O6MPdItS8bWXmWEed8ArG7+qjnERKh QAc7D3d9SbazRz+LDh3oGcnwsDEtBLnLpn1xaDIIKDraV3Tdt+S1Ur0U8x4m1JxXG4qN 5YZUqjbEcNtuT24FI+o5GOUKkALoSrzTuDxAUrsXf0P+lfPkHvfZFmbZArvLrT5qTtI5 Ig4zNf9Br2FKpQXFb041KDi7fS22IDlRHi3p+FrHnXd9kbJSuwTY4IVkEmR3j0oMl3Sm F7oQ== X-Gm-Message-State: AOAM533NKzkBTz+gqwf3Cnk98zhcRMgMYXeGRGVUGwVf/9ddW2e5itKr aDe94vdeDqN0d1DKarCjq6o9VQ== X-Google-Smtp-Source: ABdhPJyHKp00d1h8tDaA+yMYqHjhyBUP9PWFx/rhtQ9gpobh9qAoUOCdrATVHf4Ij84rffpiFz5b2g== X-Received: by 2002:a05:620a:1467:: with SMTP id j7mr1064813qkl.266.1610395692123; Mon, 11 Jan 2021 12:08:12 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id a22sm443706qkl.121.2021.01.11.12.08.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 12:08:11 -0800 (PST) Subject: Re: [PATCH v11 06/40] btrfs: do not load fs_info->zoned from incompat flag To: Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com Cc: hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" , Johannes Thumshirn References: <06add214bc16ef08214de1594ecdfcc4cdcdbd78.1608608848.git.naohiro.aota@wdc.com> From: Josef Bacik Message-ID: <21c01c81-22fd-437f-4e41-ce4563d71dc9@toxicpanda.com> Date: Mon, 11 Jan 2021 15:08:10 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 12/21/20 10:48 PM, Naohiro Aota wrote: > From: Johannes Thumshirn > > Since fs_info->zoned is unioned with fs_info->zone_size, loading > fs_info->zoned from the incompat flag screw up the zone_size. So, let's > avoid to load it from the flag. It will be eventually set by > btrfs_get_dev_zone_info_all_devices(). > > Signed-off-by: Johannes Thumshirn May want to take another crack at that changelog, the grammar is way off. The code is fine tho Reviewed-by: Josef Bacik Thanks, Josef