From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B770C07E96 for ; Tue, 6 Jul 2021 12:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62732611AB for ; Tue, 6 Jul 2021 12:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236982AbhGFMxw (ORCPT ); Tue, 6 Jul 2021 08:53:52 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:54688 "EHLO fanzine.igalia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236666AbhGFMxr (ORCPT ); Tue, 6 Jul 2021 08:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID; bh=Ds9da9wtVE2KkfSs70Y6kMbyOH44F4R+xW3YesStoew=; b=Pdo6apdfeg8aHxg2rdLUm6FmM02rQK0VBvfB62AmC+r+4BmaV7ftO+VnstwklQqoXGsejRznOFFZIMb/bRz2NMGjkX6H6l7FgTS+i5gmsEMYTuU3X1Eq3gqnZv2uAaNB/4eIyjrdpBLlhaeeP1lcVw4w4jE1IA5pnhfFp1QgSwCWn4Kwi3zdbnTPgK2pDdZ0yGzd0yJzSLzqoKOCFQ71C0B+rCTtTdgAi4ov0zz4xaGFUkw9nA+JQSp2VaBoyiZjZZvSCksVblznxKcoKiJ8IJ7bJ3mzpfKUkhVwLMviVEcNl090UIaSxFRUXcSFrmILOv9xXewm6PPd0Dx/AH3pUg==; Received: from 152.red-88-9-105.dynamicip.rima-tde.net ([88.9.105.152] helo=[192.168.2.252]) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1m0kXK-00016F-T0; Tue, 06 Jul 2021 14:50:50 +0200 Message-ID: <22817b58fe78a803af3440b7571922289fdb87f8.camel@igalia.com> Subject: Re: [PATCH] bus: Make remove callback return void From: Samuel Iglesias =?ISO-8859-1?Q?Gons=E1lvez?= To: Heikki Krogerus , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov Date: Tue, 06 Jul 2021 14:50:40 +0200 In-Reply-To: References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-uS6BQyKaXrtbvHw9wwhA" User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-uS6BQyKaXrtbvHw9wwhA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-07-06 at 14:41 +0300, Heikki Krogerus wrote: > On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-K=C3=B6nig wrote: > > The driver core ignores the return value of this callback because > > there > > is only little it can do when a device disappears. > >=20 > > This is the final bit of a long lasting cleanup quest where several > > buses were converted to also return void from their remove callback. > > Additionally some resource leaks were fixed that were caused by > > drivers > > returning an error code in the expectation that the driver won't go > > away. > >=20 > > With struct bus_type::remove returning void it's prevented that newly > > implemented buses return an ignored error code and so don't > > anticipate > > wrong expectations for driver authors. > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig >=20 For ipack changes: Acked-by: Samuel Iglesias Gons=C3=A1lvez Thanks, Sam --=-uS6BQyKaXrtbvHw9wwhA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEQP+ZAvaXWkfuKXiEf/S6MvF9w0MFAmDkUaAACgkQf/S6MvF9 w0Mk4RAAk9b3Zpvche0TpvgnTBdQ299jNyNXX1pdTj1Kri+KpCE1xlNlFtaePrqT 6dmvkqFptJwtK2/uP+6WtHjdwP1dvXfjVNa9ZRbRUFP1he5wFPXGdVl7AULbB4we tsEmEvwmFlKM1YD0Pie6KZbw9hZzXIsYizc+nhiG48KYdeMxCM/ccGoScEjlaMU9 RPKFyDhCB3ehkABppIIti9UNhV4w8Ps6d9gSCsjGkLRj+YTrtFuUlxl/CNiNHej1 V4RM3ZlVNNByNPGEW3+mtEP/Pw/n7XLXw17IneOHxL134qYATMJVnNFuJOOAc3Es 3nLKHbvqihZE/rr1byLX2jH2jibj2jOXPOTW0MGENv0WylZvt53AB7dErstEalov ptVyNwFFnBOor6PnQWFqwnOQLhfxQNlChcVC/8bdqZ0EdF3ZRtecs25gfPR7AllQ nbcPAU0my+l+7I66j8uTna4C/ztKFs+8Zn5zVLa8zQToZifnDITDmR+jOSKz/vtz +YSDSQMMvCP3p9ue4GYfJr1z9SORNm6VVrdU2R3b6lp6uos1gmB7Z+YEYVWxTGKX alGgBCX78MCEHETydFT++LfT4teGlKNc/eYXDag8CWkqyyEi0y2IJe99UYiRimre 3M1NVSivqVMg4SqBh1yMKc/gjI7M1c9VGg6UbKrTzTXJjGRlAF4= =qOWU -----END PGP SIGNATURE----- --=-uS6BQyKaXrtbvHw9wwhA--