From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v7 3/7] hash: add new functionality to store
	data in hash table
Date: Mon, 13 Jul 2015 00:00:52 +0200
Message-ID: <2285145.Kg1Z1AH0fV@xps13>
References: <1436571020-16252-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1436573936-15956-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1436573936-15956-4-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com
 [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 15A5B5A7B
 for <dev@dpdk.org>; Mon, 13 Jul 2015 00:02:05 +0200 (CEST)
Received: by widjy10 with SMTP id jy10so53687305wid.1
 for <dev@dpdk.org>; Sun, 12 Jul 2015 15:02:05 -0700 (PDT)
In-Reply-To: <1436573936-15956-4-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Pablo,
There is a remaining error below:

2015-07-11 01:18, Pablo de Lara:
> +int
> +rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **key=
s,
> +                     uint32_t num_keys, uint64_t *hit_mask, void *da=
ta[])
> +{
> +       RETURN_IF_TRUE(((h =3D=3D NULL) || (keys =3D=3D NULL) || (num=
_keys =3D=3D 0) ||
> +                       (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
> +                       (hit_mask =3D=3D NULL)), -EINVAL);
>=20

lib/librte_hash/rte_cuckoo_hash.c: In function =E2=80=98rte_hash_lookup=
_bulk_data=E2=80=99:
lib/librte_hash/rte_cuckoo_hash.c:1073:41: error: left-hand operand of =
comma expression has no effect [-Werror=3Dunused-value]
    (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
                                         ^

The comma should be ||
Will be fixed before when applying.