From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1ZALVT-0001ix-1q
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 13:09:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1ZALVP-0002MC-Sa
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 13:09:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1ZALVP-0002Lu-NM
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 13:09:03 -0400
From: Paul Moore <pmoore@redhat.com>
Date: Wed, 01 Jul 2015 13:08:58 -0400
Message-ID: <2360688.WSXcfaFilj@sifl>
In-Reply-To: <20150701120749.GA2940@hawk.localdomain>
References: <1428670681-23032-1-git-send-email-peter.maydell@linaro.org>
	<1691300.PcMPTG641q@sifl> <20150701120749.GA2940@hawk.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it
	to be used on non-x86 architectures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Marcus Meissner <meissner@suse.de>, Karl-Philipp Richter <krichter722@aol.de>, Patch Tracking <patches@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Eduardo Otubo <eduardo.otubo@profitbricks.com>, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Wednesday, July 01, 2015 02:07:49 PM Andrew Jones wrote:
> On Tue, Jun 30, 2015 at 01:18:49PM -0400, Paul Moore wrote:
> > On Tuesday, June 30, 2015 06:07:40 PM Peter Maydell wrote:
> > > On 30 June 2015 at 18:01, Paul Moore <pmoore@redhat.com> wrote:
> > > > I'm starting to wonder if the 32-bit ARM build system didn't have
> > > > __NR_cacheflush defined in the system headers; that might explain some
> > > > of
> > > > the behavior.  Could you check your system to see if it has
> > > > __NR_cacheflush defined (try /usr/include/asm/unistd.h)?
> > > 
> > > The constant name is __ARM_NR_cacheflush, not __NR_cacheflush
> > > (all the ARM-specific syscalls are __ARM_NR_*). See
> > > http://lxr.free-electrons.com/source/arch/arm/include/uapi/asm/unistd.h#
> > > L418> 
> > /me smacks his forehead
> > 
> > Of course it is.  We already work around that in arch-syscall-validate. 
> > D'oh!
> > 
> > Good news though, I think we just found the bug ;)
> > 
> > I'm currently trying to put out another fire in a different project; as
> > soon as I've got that done I'll fix this.  However, if somebody wants to
> > play, I'm always happy to accept patches :)
> 
> Sent: https://groups.google.com/forum/#!topic/libseccomp/RD9RTmc2Lxo

Applied, thanks.

> I'll send the patch for qemu to add cacheflush to the whitelist shortly.

-- 
paul moore
security @ redhat