From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, alex@kazik.de
Subject: Re: [PATCH v3 1/2] m68k: io_mm.h - add APNE 100 MBit support
Date: Fri, 18 Jun 2021 09:42:13 +1200 [thread overview]
Message-ID: <239d6b7c-f159-6efc-4ba7-0a9810840aff@gmail.com> (raw)
In-Reply-To: <8fad435e-e541-befe-8e3c-ccd75b3db0db@linux-m68k.org>
Hi Finn,
thanks for your comments!
On 17/06/21 6:58 pm, Finn Thain wrote:
>> -#define isa_inb(port) in_8(isa_itb(port))
>> #define isa_inw(port) (ISA_SEX ? in_be16(isa_itw(port)) : in_le16(isa_itw(port)))
>> #define isa_inl(port) (ISA_SEX ? in_be32(isa_itl(port)) : in_le32(isa_itl(port)))
>> #define isa_outb(val,port) out_8(isa_itb(port),(val))
>> #define isa_outw(val,port) (ISA_SEX ? out_be16(isa_itw(port),(val)) : out_le16(isa_itw(port),(val)))
>> #define isa_outl(val,port) (ISA_SEX ? out_be32(isa_itl(port),(val)) : out_le32(isa_itl(port),(val)))
>>
>> +#define isa_inb(port) ((ISA_TYPE == ISA_TYPE_AG16) ? ((port) & 1 ? isa_inw((port) - 1) & 0xff : isa_inw(port) >> 8) : in_8(isa_itb(port)))
>> +
>> #define isa_readb(p) in_8(isa_mtb((unsigned long)(p)))
>> #define isa_readw(p) \
>> (ISA_SEX ? in_be16(isa_mtw((unsigned long)(p))) \
> Was the re-ordering of definitions deliberate?
Yes, it was. I remembered looking at a bug report for curl on the m68k
kernel that was due to ordering of #defines.
On second thought, there is no prior definition of isa_inw in our case,
so even this won't really be an issue.
>
>
>> @@ -270,6 +291,9 @@ static inline void isa_delay(void)
>> case ISA_TYPE_Q40: isa_outb(0,0x80); break;
>> #endif
>> #ifdef CONFIG_AMIGA_PCMCIA
>> +#ifdef CONFIG_APNE100MBIT
>> + case ISA_TYPE_AG16: break;
>> +#endif
>> case ISA_TYPE_AG: break;
>> #endif
>> #ifdef CONFIG_ATARI_ROM_ISA
>>
> I think most of these "#ifdef CONFIG_APNE100MBIT" conditionals are
> redundant. case ISA_TYPE_AG16 should be optimized away as dead code in the
> MULTI_ISA == 0 configuration. And in the MULTI_ISA == 1 configuration, the
> logic used to assign isa_type already depends on
> defined(CONFIG_APNE100MBIT).
You're right there, too. I'll drop those.
Cheers,
Michael
next prev parent reply other threads:[~2021-06-17 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 5:28 [PATCH v3 0/2] Add APNE PCMCIA 100 Mbit support Michael Schmitz
2021-06-17 5:28 ` [PATCH v3 1/2] m68k: io_mm.h - add APNE 100 MBit support Michael Schmitz
2021-06-17 6:58 ` Finn Thain
2021-06-17 21:42 ` Michael Schmitz [this message]
2021-06-17 5:28 ` [PATCH net-next v3 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver Michael Schmitz
2021-06-17 6:51 ` Finn Thain
2021-06-17 19:33 ` Michael Schmitz
2021-06-18 7:16 ` Geert Uytterhoeven
2021-06-18 8:06 ` Michael Schmitz
2021-06-18 8:13 ` Geert Uytterhoeven
2021-06-18 8:28 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239d6b7c-f159-6efc-4ba7-0a9810840aff@gmail.com \
--to=schmitzmic@gmail.com \
--cc=alex@kazik.de \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.