From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932271AbbHCRWU (ORCPT ); Mon, 3 Aug 2015 13:22:20 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35329 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbbHCRWQ convert rfc822-to-8bit (ORCPT ); Mon, 3 Aug 2015 13:22:16 -0400 Subject: Re: [RFC 2/3] arm64: refactor save_stack_trace() Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Jungseok Lee In-Reply-To: <20150803125711.65463359@gandalf.local.home> Date: Tue, 4 Aug 2015 02:22:16 +0900 Cc: Will Deacon , Mark Rutland , Catalin Marinas , "linux-kernel@vger.kernel.org" , AKASHI Takahiro , "broonie@kernel.org" , "david.griego@linaro.org" , "olof@lixom.net" , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 8BIT Message-Id: <24AFDCDB-55DE-4A23-A26A-750B48AC365C@gmail.com> References: <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> <20150717090009.720f6bd0@gandalf.local.home> <77EA0F10-D5F6-48BD-8652-3B979A978659@gmail.com> <20150717104144.6588b2f7@gandalf.local.home> <0886A996-40E1-49E9-823C-85E55A858716@gmail.com> <1357EA74-B972-4B99-ADB0-BC7E8F06DDB5@gmail.com> <20150720162004.GL9908@arm.com> <20150803090951.GA10501@arm.com> <20150803125711.65463359@gandalf.local.home> To: Steven Rostedt X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 4, 2015, at 1:57 AM, Steven Rostedt wrote: > On Tue, 4 Aug 2015 01:30:50 +0900 > Jungseok Lee wrote: > > >> There are two issues in the current version. >> 1) The change does not work correctly when function_graph feature is enabled. >> 2) Akashi have raised an issue that size field of stack tracer is inaccurate. >> >> So, I think this patch set is not ready yet. > > Do you still want me to add code that does: > > if (*p == (stack_dump_trace[i] + FTRACE_STACK_FRAME_OFFSET)) { > > ? > > If you expect to need that, I can get it into the next merge window and > you can base the code of that in the merge window after that. It would be better to add the snippet when a new version is ready. That way might help to figure out easily why the macro is introduced and how it can be used in architecture code. Best Regards Jungseok Lee From mboxrd@z Thu Jan 1 00:00:00 1970 From: jungseoklee85@gmail.com (Jungseok Lee) Date: Tue, 4 Aug 2015 02:22:16 +0900 Subject: [RFC 2/3] arm64: refactor save_stack_trace() In-Reply-To: <20150803125711.65463359@gandalf.local.home> References: <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> <20150717090009.720f6bd0@gandalf.local.home> <77EA0F10-D5F6-48BD-8652-3B979A978659@gmail.com> <20150717104144.6588b2f7@gandalf.local.home> <0886A996-40E1-49E9-823C-85E55A858716@gmail.com> <1357EA74-B972-4B99-ADB0-BC7E8F06DDB5@gmail.com> <20150720162004.GL9908@arm.com> <20150803090951.GA10501@arm.com> <20150803125711.65463359@gandalf.local.home> Message-ID: <24AFDCDB-55DE-4A23-A26A-750B48AC365C@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Aug 4, 2015, at 1:57 AM, Steven Rostedt wrote: > On Tue, 4 Aug 2015 01:30:50 +0900 > Jungseok Lee wrote: > > >> There are two issues in the current version. >> 1) The change does not work correctly when function_graph feature is enabled. >> 2) Akashi have raised an issue that size field of stack tracer is inaccurate. >> >> So, I think this patch set is not ready yet. > > Do you still want me to add code that does: > > if (*p == (stack_dump_trace[i] + FTRACE_STACK_FRAME_OFFSET)) { > > ? > > If you expect to need that, I can get it into the next merge window and > you can base the code of that in the merge window after that. It would be better to add the snippet when a new version is ready. That way might help to figure out easily why the macro is introduced and how it can be used in architecture code. Best Regards Jungseok Lee